From: "Barnabás Pőcze" <pobrn@protonmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Mark Pearson <markpearson@lenovo.com>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"mgross@linux.intel.com" <mgross@linux.intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"mario.limonciello@dell.com" <mario.limonciello@dell.com>,
"eliadevito@gmail.com" <eliadevito@gmail.com>,
"hadess@hadess.net" <hadess@hadess.net>,
"bberg@redhat.com" <bberg@redhat.com>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"dvhart@infradead.org" <dvhart@infradead.org>
Subject: Re: [PATCH v3] ACPI: platform-profile: Add platform profile support
Date: Sat, 21 Nov 2020 21:18:49 +0000 [thread overview]
Message-ID: <8c3pjwAeJVjl5ZLmnajCVHjcyBjoQeQTupHqZZostKJt3YZ0seAAvD-UIcBYFAFUNjsi0iWrEBNfX1l0tqN-4x07TGQbsiOMEqCpPAxgqJQ=@protonmail.com> (raw)
In-Reply-To: <761671b3-ad26-230b-e709-05ce3bd69498@redhat.com>
2020. november 21., szombat 15:27 keltezéssel, Hans de Goede írta:
> [...]
> > I just realized that the sysfs attributes are only created if a profile provider
> > is registered, and it is removed when the provide unregisters itself. I believe
> > it would be easier for system daemons if those attributes existed from module load
> > to module unload since they can just just open the file and watch it using poll,
> > select, etc. If it goes away when the provider unregisters itself, then I believe
> > a more complicated mechanism (like inotify) would need to be implemented in the
> > daemons to be notified when a new provider is registered. Thus my suggestion
> > for the next iteration is to create the sysfs attributes on module load,
> > and delete them on unload.
> >
> > What do you think?
>
> Actually I asked Mark to move this to the register / unregister time since
> having a non functioning files in sysfs is a bit weird.
> [...]
Ahh, I didn't know that, sorry. If a non-functioning sysfs attribute is a problem,
then there is another option: `platform_profile_choices` is always present;
if no provider is registered, it's empty. If a provider is (un)registered,
then `platform_profile_choices` is sysfs_notify()-ed. `platform_profile`
only exists while a provider is registered, so it is created on provider
registration and unregistered on provider unregistration.
Regards,
Barnabás Pőcze
next prev parent reply other threads:[~2020-11-21 21:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 0:44 [PATCH v3] ACPI: platform-profile: Add platform profile support Mark Pearson
2020-11-15 18:26 ` Barnabás Pőcze
2020-11-15 23:04 ` [External] " Mark Pearson
2020-11-16 10:24 ` Barnabás Pőcze
2020-11-16 15:25 ` Mark Pearson
2020-11-16 14:33 ` Hans de Goede
2020-11-16 15:19 ` Mark Pearson
2020-11-20 19:50 ` Barnabás Pőcze
2020-11-21 4:14 ` [External] " Mark Pearson
2020-11-21 14:27 ` Hans de Goede
2020-11-21 21:18 ` Barnabás Pőcze [this message]
2020-11-22 9:32 ` Hans de Goede
2020-11-24 15:30 ` Bastien Nocera
2020-11-25 16:42 ` Hans de Goede
2020-11-25 19:41 ` [External] " Mark Pearson
2020-11-25 22:32 ` Bastien Nocera
2020-11-26 10:36 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='8c3pjwAeJVjl5ZLmnajCVHjcyBjoQeQTupHqZZostKJt3YZ0seAAvD-UIcBYFAFUNjsi0iWrEBNfX1l0tqN-4x07TGQbsiOMEqCpPAxgqJQ=@protonmail.com' \
--to=pobrn@protonmail.com \
--cc=bberg@redhat.com \
--cc=dvhart@infradead.org \
--cc=eliadevito@gmail.com \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=markpearson@lenovo.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).