* [PATCH RFC v3 1/9] ACPI: NUMA: export pxm_to_node
[not found] <20190919142228.5483-1-david@redhat.com>
@ 2019-09-19 14:22 ` David Hildenbrand
2019-09-23 10:13 ` David Hildenbrand
0 siblings, 1 reply; 4+ messages in thread
From: David Hildenbrand @ 2019-09-19 14:22 UTC (permalink / raw)
To: linux-kernel
Cc: linux-mm, virtualization, Andrea Arcangeli, David Hildenbrand,
Rafael J. Wysocki, Len Brown, linux-acpi
Will be needed by virtio-mem to identify the node from a pxm.
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org
Signed-off-by: David Hildenbrand <david@redhat.com>
---
drivers/acpi/numa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/acpi/numa.c b/drivers/acpi/numa.c
index eadbf90e65d1..d5847fa7ac69 100644
--- a/drivers/acpi/numa.c
+++ b/drivers/acpi/numa.c
@@ -35,6 +35,7 @@ int pxm_to_node(int pxm)
return NUMA_NO_NODE;
return pxm_to_node_map[pxm];
}
+EXPORT_SYMBOL(pxm_to_node);
int node_to_pxm(int node)
{
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH RFC v3 1/9] ACPI: NUMA: export pxm_to_node
2019-09-19 14:22 ` [PATCH RFC v3 1/9] ACPI: NUMA: export pxm_to_node David Hildenbrand
@ 2019-09-23 10:13 ` David Hildenbrand
2019-09-23 10:36 ` Michal Hocko
0 siblings, 1 reply; 4+ messages in thread
From: David Hildenbrand @ 2019-09-23 10:13 UTC (permalink / raw)
To: linux-kernel
Cc: linux-mm, virtualization, Andrea Arcangeli, Rafael J. Wysocki,
Len Brown, linux-acpi
On 19.09.19 16:22, David Hildenbrand wrote:
> Will be needed by virtio-mem to identify the node from a pxm.
>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Len Brown <lenb@kernel.org>
> Cc: linux-acpi@vger.kernel.org
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> drivers/acpi/numa.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/numa.c b/drivers/acpi/numa.c
> index eadbf90e65d1..d5847fa7ac69 100644
> --- a/drivers/acpi/numa.c
> +++ b/drivers/acpi/numa.c
> @@ -35,6 +35,7 @@ int pxm_to_node(int pxm)
> return NUMA_NO_NODE;
> return pxm_to_node_map[pxm];
> }
> +EXPORT_SYMBOL(pxm_to_node);
FWIW, this is a fairly old patch I dragged along and I think I'll
convert this to EXPORT_SYMBOL_GPL now that I know better :)
>
> int node_to_pxm(int node)
> {
>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RFC v3 1/9] ACPI: NUMA: export pxm_to_node
2019-09-23 10:13 ` David Hildenbrand
@ 2019-09-23 10:36 ` Michal Hocko
2019-09-23 10:39 ` David Hildenbrand
0 siblings, 1 reply; 4+ messages in thread
From: Michal Hocko @ 2019-09-23 10:36 UTC (permalink / raw)
To: David Hildenbrand
Cc: linux-kernel, linux-mm, virtualization, Andrea Arcangeli,
Rafael J. Wysocki, Len Brown, linux-acpi
On Mon 23-09-19 12:13:11, David Hildenbrand wrote:
> On 19.09.19 16:22, David Hildenbrand wrote:
> > Will be needed by virtio-mem to identify the node from a pxm.
> >
> > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> > Cc: Len Brown <lenb@kernel.org>
> > Cc: linux-acpi@vger.kernel.org
> > Signed-off-by: David Hildenbrand <david@redhat.com>
> > ---
> > drivers/acpi/numa.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/acpi/numa.c b/drivers/acpi/numa.c
> > index eadbf90e65d1..d5847fa7ac69 100644
> > --- a/drivers/acpi/numa.c
> > +++ b/drivers/acpi/numa.c
> > @@ -35,6 +35,7 @@ int pxm_to_node(int pxm)
> > return NUMA_NO_NODE;
> > return pxm_to_node_map[pxm];
> > }
> > +EXPORT_SYMBOL(pxm_to_node);
>
> FWIW, this is a fairly old patch I dragged along and I think I'll
> convert this to EXPORT_SYMBOL_GPL now that I know better :)
All other exports in this file are EXPORT_SYMBOL. Why is this one
considered special to restrict the access?
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RFC v3 1/9] ACPI: NUMA: export pxm_to_node
2019-09-23 10:36 ` Michal Hocko
@ 2019-09-23 10:39 ` David Hildenbrand
0 siblings, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2019-09-23 10:39 UTC (permalink / raw)
To: Michal Hocko
Cc: linux-kernel, linux-mm, virtualization, Andrea Arcangeli,
Rafael J. Wysocki, Len Brown, linux-acpi
On 23.09.19 12:36, Michal Hocko wrote:
> On Mon 23-09-19 12:13:11, David Hildenbrand wrote:
>> On 19.09.19 16:22, David Hildenbrand wrote:
>>> Will be needed by virtio-mem to identify the node from a pxm.
>>>
>>> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
>>> Cc: Len Brown <lenb@kernel.org>
>>> Cc: linux-acpi@vger.kernel.org
>>> Signed-off-by: David Hildenbrand <david@redhat.com>
>>> ---
>>> drivers/acpi/numa.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/acpi/numa.c b/drivers/acpi/numa.c
>>> index eadbf90e65d1..d5847fa7ac69 100644
>>> --- a/drivers/acpi/numa.c
>>> +++ b/drivers/acpi/numa.c
>>> @@ -35,6 +35,7 @@ int pxm_to_node(int pxm)
>>> return NUMA_NO_NODE;
>>> return pxm_to_node_map[pxm];
>>> }
>>> +EXPORT_SYMBOL(pxm_to_node);
>>
>> FWIW, this is a fairly old patch I dragged along and I think I'll
>> convert this to EXPORT_SYMBOL_GPL now that I know better :)
>
> All other exports in this file are EXPORT_SYMBOL. Why is this one
> considered special to restrict the access?
>
Uh, so I did actually use my brain two years ago back when I was
crafting this patch :)
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-23 10:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190919142228.5483-1-david@redhat.com>
2019-09-19 14:22 ` [PATCH RFC v3 1/9] ACPI: NUMA: export pxm_to_node David Hildenbrand
2019-09-23 10:13 ` David Hildenbrand
2019-09-23 10:36 ` Michal Hocko
2019-09-23 10:39 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).