From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCD52CA9EAF for ; Thu, 24 Oct 2019 21:42:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F90021BE5 for ; Thu, 24 Oct 2019 21:42:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bqbk0H3k" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728062AbfJXVmr (ORCPT ); Thu, 24 Oct 2019 17:42:47 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:35030 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726443AbfJXVmr (ORCPT ); Thu, 24 Oct 2019 17:42:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571953366; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wGkV4YJUEO3qbrdqTa8x/8kmlCZ5hNe2TSncdT95RyM=; b=bqbk0H3kdaYXpesFAaAxhhv7KFlB8vT5yqtd+NS555EYTAJWZuP1nvBV+1naYFVGCvhNVC RdZv+4tRyZzhVYCft2R8c2G0uBBFvCPV9U7vKLVCznro/8jlfRZnQm5MEp8IknGGlC4vwV CaxhLxwwlcXnkzAbGs4XxJKhF/dj9KM= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-232-Mhz4guyCME6agaUQQCRdbg-1; Thu, 24 Oct 2019 17:42:43 -0400 Received: by mail-wr1-f69.google.com with SMTP id v8so12639742wrt.16 for ; Thu, 24 Oct 2019 14:42:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8CT1TODYQhVLZHx2+A61//ZvlfiWgxqGvqrGHfOtDiw=; b=eqhv7hMcnkbFb+E0P+k+jFh4d5RajYWYBPHFt7XxUeC64F2tXhwvVj6huFiK/cO6pl C6DZLR7D5rPFhKgYmXImTGsRB6wAJMNy5dqLmXIgF4NLbOAXx40QCP6xr5P6q9ayzc1h dKitczZuNaHpcVG7xMm2WMZJK3QnbMx2LhMF+Ghgfh1ouGmAJj/VwFbzC+fRMJ/QukWf REs+oocH+VHYcn5oeLlD/hT9nrFF94VaNNll4yeYAryWxZit+uIA/XFvSYlDuO32kSPy PQR1TI/rlss5ZwW98wnZUos/XPW7h0xEqXWzygw30IcP92tNimlINF52J2NO/KRj0KcQ ajtg== X-Gm-Message-State: APjAAAVWqUYvyfpm+J9fCUESvJYAxjJlZYGChTZ3d2l7QPn90KTq5DhZ t54Hcut5aaqubtMGmGRnm/TvAVIlKJRDVcJEnilC1oaahLiTW57Iiu1LC5UYybcBXlw2fR66Xs1 czYGCN7viDXhP3XGbvby0MA== X-Received: by 2002:a1c:ed0d:: with SMTP id l13mr406395wmh.54.1571953361924; Thu, 24 Oct 2019 14:42:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqyEFOq5uxVwPaAJjuPoDKqxQbRpwXNg/ynJ9pBdXdDtlhxOvBmgrTpO/uXLu4upkzZdh/jtcA== X-Received: by 2002:a1c:ed0d:: with SMTP id l13mr406386wmh.54.1571953361725; Thu, 24 Oct 2019 14:42:41 -0700 (PDT) Received: from shalem.localdomain (2001-1c00-0c14-2800-ec23-a060-24d5-2453.cable.dynamic.v6.ziggo.nl. [2001:1c00:c14:2800:ec23:a060:24d5:2453]) by smtp.gmail.com with ESMTPSA id i18sm149304wrx.14.2019.10.24.14.42.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Oct 2019 14:42:41 -0700 (PDT) Subject: Re: [PATCH 1/3] ACPI / LPSS: Add LNXVIDEO -> BYT I2C7 to lpss_device_links To: "Rafael J. Wysocki" Cc: "Rafael J . Wysocki" , Len Brown , Andy Shevchenko , Mika Westerberg , ACPI Devel Maling List , Pierre-Louis Bossart , Stable References: <20191024212936.144648-1-hdegoede@redhat.com> From: Hans de Goede Message-ID: <946835e4-10f0-4d3f-a151-983d54034aca@redhat.com> Date: Thu, 24 Oct 2019 23:42:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-MC-Unique: Mhz4guyCME6agaUQQCRdbg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi, On 24-10-2019 23:34, Rafael J. Wysocki wrote: > On Thu, Oct 24, 2019 at 11:29 PM Hans de Goede wrot= e: >> >> So far on Bay Trail (BYT) we only have been adding a device_link adding >> the iGPU (LNXVIDEO) device as consumer for the I2C controller for the >> PMIC for I2C5, but the PMIC only uses I2C5 on BYT CR (cost reduced) on >> regular BYT platforms I2C7 is used and we were not adding the device_lin= k >> sometimes causing resume ordering issues. >> >> This commit adds LNXVIDEO -> BYT I2C7 to the lpss_device_links table, >> fixing this. >> >> Cc: stable@vger.kernel.org >=20 > Thanks for these fixes, but it would be kind of nice to have Fixes: > tags for them too. Ok, v2 with fixes tag coming up. Regards, Hans >=20 >> Signed-off-by: Hans de Goede >> --- >> drivers/acpi/acpi_lpss.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c >> index 60bbc5090abe..e7a4504f0fbf 100644 >> --- a/drivers/acpi/acpi_lpss.c >> +++ b/drivers/acpi/acpi_lpss.c >> @@ -473,9 +473,14 @@ struct lpss_device_links { >> * the supplier is not enumerated until after the consumer is probed. >> */ >> static const struct lpss_device_links lpss_device_links[] =3D { >> + /* CHT External sdcard slot controller depends on PMIC I2C ctrl = */ >> {"808622C1", "7", "80860F14", "3", DL_FLAG_PM_RUNTIME}, >> + /* CHT iGPU depends on PMIC I2C controller */ >> {"808622C1", "7", "LNXVIDEO", NULL, DL_FLAG_PM_RUNTIME}, >> + /* BYT CR iGPU depends on PMIC I2C controller (UID 5 on CR) */ >> {"80860F41", "5", "LNXVIDEO", NULL, DL_FLAG_PM_RUNTIME}, >> + /* BYT iGPU depends on PMIC I2C controller (UID 7 on non CR) */ >> + {"80860F41", "7", "LNXVIDEO", NULL, DL_FLAG_PM_RUNTIME}, >> }; >> >> static bool hid_uid_match(struct acpi_device *adev, >> -- >> 2.23.0 >>