From: Florian Fainelli <f.fainelli@gmail.com>
To: Calvin Johnson <calvin.johnson@oss.nxp.com>,
Jeremy Linton <jeremy.linton@arm.com>,
Russell King - ARM Linux admin <linux@armlinux.org.uk>,
Jon <jon@solid-run.com>,
Cristi Sovaiala <cristian.sovaiala@nxp.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Andrew Lunn <andrew@lunn.ch>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Madalin Bucur <madalin.bucur@oss.nxp.com>
Cc: netdev@vger.kernel.org, linux.cj@gmail.com, linux-acpi@vger.kernel.org
Subject: Re: [net-next PATCH v6 5/6] phylink: introduce phylink_fwnode_phy_connect()
Date: Sat, 11 Jul 2020 14:37:49 -0700 [thread overview]
Message-ID: <998d1566-ede8-88f4-6c80-cda0c10ca7bf@gmail.com> (raw)
In-Reply-To: <20200711065600.9448-6-calvin.johnson@oss.nxp.com>
On 7/10/2020 11:55 PM, Calvin Johnson wrote:
> Define phylink_fwnode_phy_connect() to connect phy specified by
> a fwnode to a phylink instance.
>
> Signed-off-by: Calvin Johnson <calvin.johnson@oss.nxp.com>
>
> ---
[snip]
> +int phylink_fwnode_phy_connect(struct phylink *pl,
> + struct fwnode_handle *fwnode,
> + u32 flags)
> +{
> + struct phy_device *phy_dev;
> +
> + if (is_of_node(fwnode))
> + return phylink_of_phy_connect(pl, to_of_node(fwnode), flags);
> + if (is_acpi_device_node(fwnode)) {
> + phy_dev = phy_find_by_mdio_handle(fwnode);
> + if (!phy_dev)
> + return -ENODEV;
Please also assign dev_flags to the phy_dev for symmetry with the
phylink_of_phy_connect() function:
phy_dev->dev_flags |= flags;
With that fixed:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2020-07-11 21:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-11 6:55 [net-next PATCH v6 0/6] ACPI support for dpaa2 MAC driver Calvin Johnson
2020-07-11 6:55 ` [net-next PATCH v6 1/6] Documentation: ACPI: DSD: Document MDIO PHY Calvin Johnson
2020-07-11 6:55 ` [net-next PATCH v6 2/6] net: phy: introduce device_mdiobus_register() Calvin Johnson
2020-07-11 21:36 ` Florian Fainelli
2020-07-13 5:56 ` Calvin Johnson
2020-07-11 6:55 ` [net-next PATCH v6 3/6] net/fsl: use device_mdiobus_register() Calvin Johnson
2020-07-11 6:55 ` [net-next PATCH v6 4/6] net: phy: introduce phy_find_by_mdio_handle() Calvin Johnson
2020-07-11 21:41 ` Florian Fainelli
2020-07-13 6:04 ` Calvin Johnson
2020-07-13 11:04 ` Andy Shevchenko
2020-07-11 6:55 ` [net-next PATCH v6 5/6] phylink: introduce phylink_fwnode_phy_connect() Calvin Johnson
2020-07-11 21:37 ` Florian Fainelli [this message]
2020-07-11 6:56 ` [net-next PATCH v6 6/6] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver Calvin Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=998d1566-ede8-88f4-6c80-cda0c10ca7bf@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=andy.shevchenko@gmail.com \
--cc=calvin.johnson@oss.nxp.com \
--cc=cristian.sovaiala@nxp.com \
--cc=ioana.ciornei@nxp.com \
--cc=jeremy.linton@arm.com \
--cc=jon@solid-run.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux.cj@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=madalin.bucur@oss.nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).