From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81CD5C46499 for ; Fri, 5 Jul 2019 15:02:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D3BD21738 for ; Fri, 5 Jul 2019 15:02:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iJcJXmB5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726302AbfGEPCl (ORCPT ); Fri, 5 Jul 2019 11:02:41 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:41136 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726005AbfGEPCl (ORCPT ); Fri, 5 Jul 2019 11:02:41 -0400 Received: by mail-lf1-f67.google.com with SMTP id 62so6534357lfa.8; Fri, 05 Jul 2019 08:02:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dEDcm+IMzdH45vWKat38tOP6YtE82uRu/Nk82XO3Gqc=; b=iJcJXmB5wQwsHy7K+5FKnawavg8Vjb7KBII9CyBGGAGolFGWLmi693+1tRqJK0iza+ Vax3sfK3ogtihSJZN8rkQ8xF62RwdPkTPNnmIYall/HCRNgX/hSQPpMUPNyc7SR9cjV8 w4UNSfaeClgSjE2RoYDzRdHEsKTGJFGbllOMrS7YKUHFIOmPahUxNqmq1wXTMnJlKg0T mmRULlAmjKi58Kl294M68uDdva31t+w1vYZm00QyRnWHUgv/EeM+sCZcLt6Ol60G/nQl mMGHeE3qVPZXRfUEGul+PTXI1kPmIEjevh2ep+DvrwzRGLtAZDMiaXsiHMKqo14XS/Ih MW1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dEDcm+IMzdH45vWKat38tOP6YtE82uRu/Nk82XO3Gqc=; b=XyHk7f2CYI9p8xdIFXepRka38RRhhP84k3/x4ACAj4nMDm/xxb6wWalhTDDtQc4OlW b0t+tzmR8QM9L4GXuTtK8Mc/gSP1/LLq0AzDmQcjsSdjhPCM4EHVWifjE7WtdjaJrdUB NF9Ds7T3VNtZhY309vEZa7T1qhbaVPIkg3lkYPEdFRPU/jqc1vMRL+1uGctyJtb3ZAAc sR2SFf8JTB5HfP4UCbQoo5LiU9nxycQdinBu7vs0pIayDT9ATxi13L7GQt2plePoJSuw Sf6n2Mba7a1hp+MQVHHCckivdCaXzQoOCabVlFcH9PEhbm5UXV6FVTosnlKGnARlAWlI mIFw== X-Gm-Message-State: APjAAAVEJcvDQOyRIetk9dDcqJ+i/A6w1vkGNgjVADiE/H6v1tEAWlxy 23vx4l90uPcBNYOpCzbyPRdRF6DyeQVrUBUcK5ppnG1dFSQ= X-Google-Smtp-Source: APXvYqwVIcoJd9kDvRk37mrrvlpvYlJyK/L+Hv+l55llVIMFAR2Sz0JgXs++W+e3+31hnuyx2k3b7CXmnW4BdGM25nM= X-Received: by 2002:a19:7509:: with SMTP id y9mr2256015lfe.117.1562338959781; Fri, 05 Jul 2019 08:02:39 -0700 (PDT) MIME-Version: 1.0 References: <20190705095800.43534-1-mika.westerberg@linux.intel.com> <20190705095800.43534-8-mika.westerberg@linux.intel.com> <20190705145106.GA2640@lahna.fi.intel.com> In-Reply-To: <20190705145106.GA2640@lahna.fi.intel.com> From: Yehezkel Bernat Date: Fri, 5 Jul 2019 18:02:23 +0300 Message-ID: Subject: Re: [PATCH 7/8] thunderbolt: Add support for Intel Ice Lake To: Mika Westerberg Cc: LKML , Andreas Noever , Michael Jamet , "Rafael J . Wysocki" , Len Brown , Lukas Wunner , Mario Limonciello , Anthony Wong , linux-acpi@vger.kernel.org, Raanan Avargil Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Fri, Jul 5, 2019 at 5:51 PM Mika Westerberg wrote: > > > > +static int nhi_suspend_power_down(struct tb *tb) > > > +{ > > > + int ret; > > > + > > > + /* > > > + * If there is no device connected we need to perform an additional > > > + * handshake through LC mailbox and force power down before > > > + * entering D3. > > > + */ > > > + ret = device_for_each_child(&tb->root_switch->dev, NULL, > > > + nhi_device_connected); > > > + if (!ret) { > > > + lc_mailbox_cmd(tb->nhi, LC_PREPARE_FOR_RESET); > > > + ret = lc_mailbox_cmd_complete(tb->nhi, > > > + LC_MAILBOX_TIMEOUT); > > > + if (ret) > > > + return ret; > > > + > > > + return nhi_power_down(tb->nhi); > > > > Just to be sure: unforce power is done only if no device is connected? > > My understanding of the comment above was that unforce power should be done > > anyway (so it should be outside of this if block), and the difference between > > the cases is only about the additional LC mailbox message. I guess I misread it. > > nhi_power_down() should be only called if no device was connected so it > should be in correct place. I can try to clarify the comment a bit, > though. Maybe adding the word "both" ("to perform both an additional") will make it clearer. Maybe removing the "additional" (which to my ears sounds like "an additional operation besides the normal one, to unforce power") is enough. Again, your call. I'm not sure it's strictly needed, maybe it's just me. Thanks!