Linux-ACPI Archive on
 help / color / Atom feed
From: Chris Chiu <>
To: "Rafael J. Wysocki" <>,, Len Brown <>
Cc: ACPI Devel Maling List <>,
	Linux Kernel <>,
	Linux Upstreaming Team <>
Subject: System fails to exit s2idle by a keystroke on my laptop
Date: Tue, 5 May 2020 01:09:30 +0800
Message-ID: <> (raw)

    I have an Intel X5-Z8350 laptop which used to work fine on s2idle
enter/exit with kernel 5.3. After upgrading to kernel 5.4 and later,
the system can still exit s2idle by power button. However, if I try to
wake it up from a keystroke, the system will freeze and then no longer
respond even to the power button. I can only shut it down and power on

    I tried to 'git bisect' to find out which commit causes the
difference, it shows me the commit "ACPI: PM: s2idle: Prevent spurious
SCIs from waking up the system". My laptop can work as usual to exit
s2idle by a keystroke with reverting it on kernel 5.4.

    Then I tried to check whether I can reproduce it on the latest
mainline kernel, the same problem still there. But I can not fix it by
simply reverting. I found the acpi_s2idle_wake() has been refined on
the latest mainline kernel, and I have to make modifications as
follows to make my laptop work.

@@ -1024,7 +1024,7 @@ static bool acpi_s2idle_wake(void)
                 * regarded as a spurious one.
                if (!acpi_ec_dispatch_gpe())
-                       return false;
+                       return true;

                 * Cancel the wakeup and process all pending events in case

    Maybe there's something special on my laptop so a keystroke is
considered as a spurious event on this machine? Don't know if the DSDT
helps or not.

    Please let me know if there's anything I can help to address this
problem. Thanks


             reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-04 17:09 Chris Chiu [this message]
2020-05-06  9:32 ` Rafael J. Wysocki
2020-05-06 10:19   ` Rafael J. Wysocki
2020-05-07  3:38     ` Chris Chiu
2020-05-07 18:05       ` Rafael J. Wysocki
2020-05-08  8:22         ` Chris Chiu
2020-05-08 16:50           ` Rafael J. Wysocki
2020-05-11  6:54             ` Chris Chiu
2020-05-11  8:10               ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ACPI Archive on

Archives are clonable:
	git clone --mirror linux-acpi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-acpi linux-acpi/ \
	public-inbox-index linux-acpi

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone