From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF481C3A589 for ; Thu, 15 Aug 2019 14:35:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C96CB206C1 for ; Thu, 15 Aug 2019 14:35:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731564AbfHOOfh (ORCPT ); Thu, 15 Aug 2019 10:35:37 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:37960 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730915AbfHOOff (ORCPT ); Thu, 15 Aug 2019 10:35:35 -0400 Received: by mail-ot1-f65.google.com with SMTP id r20so6334072ota.5 for ; Thu, 15 Aug 2019 07:35:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BtTSn2uMyyP8QHhCiI6vaNdIzu8IHEHZhZ5nwC+nMAU=; b=SKCgJPMtqGWaAgPyBegFRU6EEdONVbu0j61P5gtoRE4UErFe+R7Ub66HzTc61+kbgV D8q9Sl+m1g/U+avBtVEQNUXF53Iz6r8GiwAkhR1E/qau580gcInBFwJYtEYscx/83qpw 86ijLE0oe3fq+5KonS9l7lSylfNEOs6TxOoQREuDk8Uc6adQOx3d6ul8W82jpykYxADV hcEPPbVYwXzkmvmoSIHrR+x9c95azEBuiHlrqD3TTcR4XsiD3zy4PBLOaS9jHsEcIJHT YyKjsgoZeTy6IwPXE6vWBHrXcCqaEGudpC/PXkqC+f5s2/EyvT2oDPT4BvDrQcKPoSxq V8kw== X-Gm-Message-State: APjAAAXYCTInSVxejmgvcanekOtL1RbnoEuELtDDVz6tp0aOVJbvqRVo PY46N2Hz1W9Gbq00V24O8iS6BIwwxTnXPntQqPy4kQ== X-Google-Smtp-Source: APXvYqzKOnt+7f9VOL89+ec428aBeZSnl2atgboE0ieQNu4BQtWa3L1DeSUe5NY6fj6Fh4lzcbXWphwAs3uyRC9CmKY= X-Received: by 2002:a6b:f906:: with SMTP id j6mr5800892iog.26.1565879733515; Thu, 15 Aug 2019 07:35:33 -0700 (PDT) MIME-Version: 1.0 References: <20190814213118.28473-1-kherbst@redhat.com> <20190814213118.28473-2-kherbst@redhat.com> <5e05532328324d01bc554c573f6298f8@AUSX13MPC101.AMER.DELL.COM> <6ed1c393ffeb4c24ab5875927d6a37ac@AUSX13MPC101.AMER.DELL.COM> In-Reply-To: <6ed1c393ffeb4c24ab5875927d6a37ac@AUSX13MPC101.AMER.DELL.COM> From: Karol Herbst Date: Thu, 15 Aug 2019 16:35:22 +0200 Message-ID: Subject: Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output" To: Mario.Limonciello@dell.com Cc: Alex Deucher , nouveau , "Rafael J . Wysocki" , LKML , dri-devel , Linux ACPI Mailing List , Alex Hung , Ben Skeggs , David Airlie Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Archived-At: List-Archive: List-Post: On Thu, Aug 15, 2019 at 4:30 PM wrote: > > > On Thu, Aug 15, 2019 at 10:15 AM Karol Herbst wrote: > > > > > > On Thu, Aug 15, 2019 at 4:13 PM Alex Deucher > > wrote: > > > > > > > > On Thu, Aug 15, 2019 at 10:04 AM Karol Herbst wrote: > > > > > > > > > > On Thu, Aug 15, 2019 at 3:56 PM wrote: > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: linux-acpi-owner@vger.kernel.org > owner@vger.kernel.org> On > > > > > > > Behalf Of Dave Airlie > > > > > > > Sent: Wednesday, August 14, 2019 5:48 PM > > > > > > > To: Karol Herbst > > > > > > > Cc: LKML; Linux ACPI; dri-devel; nouveau; Rafael J . Wysocki; Alex Hung; > > Ben > > > > > > > Skeggs; Dave Airlie > > > > > > > Subject: Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI > > string to > > > > > > > enable dGPU direct output" > > > > > > > > > > > > > > On Thu, 15 Aug 2019 at 07:31, Karol Herbst > > wrote: > > > > > > > > > > > > > > > > This reverts commit 28586a51eea666d5531bcaef2f68e4abbd87242c. > > > > > > > > > > > > > > > > The original commit message didn't even make sense. AMD _does_ > > support it and > > > > > > > > it works with Nouveau as well. > > > > > > > > > > > > > > > > Also what was the issue being solved here? No references to any bugs > > and not > > > > > > > > even explaining any issue at all isn't the way we do things. > > > > > > > > > > > > > > > > And even if it means a muxed design, then the fix is to make it work > > inside the > > > > > > > > driver, not adding some hacky workaround through ACPI tricks. > > > > > > > > > > > > > > > > And what out of tree drivers do or do not support we don't care one > > bit anyway. > > > > > > > > > > > > > > > > > > > > > > I think the reverts should be merged via Rafael's tree as the original > > > > > > > patches went in via there, and we should get them in asap. > > > > > > > > > > > > > > Acked-by: Dave Airlie > > > > > > > Dave. > > > > > > > > > > > > There are definitely going to be regressions on machines in the field with > > the > > > > > > in tree drivers by reverting this. I think we should have an answer for all > > of those > > > > > > before this revert is accepted. > > > > > > > > > > > > Regarding systems with Intel+NVIDIA, we'll have to work with partners to > > collect > > > > > > some information on the impact of reverting this. > > > > > > > > > > > > When this is used on a system with Intel+AMD the ASL configures AMD > > GPU to use > > > > > > "Hybrid Graphics" when on Windows and "Power Express" and > > "Switchable Graphics" > > > > > > when on Linux. > > > > > > > > > > and what's exactly the difference between those? And what's the actual > > > > > issue here? > > > > > > > > Hybrid Graphics is the new "standard" way of handling these laptops. > > > > It uses the standard _PR3 APCI method to handle dGPU power. Support > > > > for this was added to Linux relatively later compared to when the > > > > laptops were launched. "Power Express" used the other AMD specific > > > > ATPX ACPI method to handle dGPU power. The driver supports both so > > > > either method will work. > > > > > > > > Alex > > > > > > > > > > thanks for clarifying. But that still means that we won't need such > > > workarounds for AMD users, right? amdgpu handles hybrid graphics just > > > fine, right? > > > > Yeah it should, assuming you have a new enough kernel which supports > > HG, which has been several years at this point IIRC. > > > > Alex > > > > Can you define how new of a kernel is a new enough kernel? > > Looking on my side these problems were on new hardware (Precision 7740) and > are checked as recently as start of this summer, w/ kernel 4.15. That's not even a long term one. And it shouldn't get any fixes. I just checked, last update was 16 months ago. > > We can arrange to have it checked again on 5.3rcX w/ the OSI disabled. yeah, please do. If there are any issues, we (as in drm developers) are happy to fix the issues inside the drivers.