From: Karol Herbst <firstname.lastname@example.org> To: Mario.Limonciello@dell.com Cc: Dave Airlie <email@example.com>, LKML <firstname.lastname@example.org>, Linux ACPI Mailing List <email@example.com>, dri-devel <firstname.lastname@example.org>, nouveau <email@example.com>, "Rafael J . Wysocki" <firstname.lastname@example.org>, Alex Hung <email@example.com>, Ben Skeggs <firstname.lastname@example.org>, David Airlie <email@example.com> Subject: Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output" Date: Thu, 15 Aug 2019 16:36:54 +0200 Message-ID: <CACO55tthEUVKJN_yCuGU95e8Zc+q-sJEsxML+ZYz7rpU9zDGCg@mail.gmail.com> (raw) In-Reply-To: <54add026bb6f45fd94a2dc2bae4adf9f@AUSX13MPC101.AMER.DELL.COM> On Thu, Aug 15, 2019 at 4:34 PM <Mario.Limonciello@dell.com> wrote: > > > -----Original Message----- > > From: Karol Herbst <firstname.lastname@example.org> > > Sent: Thursday, August 15, 2019 9:25 AM > > To: Limonciello, Mario > > Cc: Dave Airlie; LKML; Linux ACPI Mailing List; dri-devel; nouveau; Rafael J . > > Wysocki; Alex Hung; Ben Skeggs; David Airlie > > Subject: Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to > > enable dGPU direct output" > > > > > > [EXTERNAL EMAIL] > > > > On Thu, Aug 15, 2019 at 4:20 PM <Mario.Limonciello@dell.com> wrote: > > > > > > > > There are definitely going to be regressions on machines in the field with > > the > > > > > in tree drivers by reverting this. I think we should have an answer for all of > > > > those > > > > > before this revert is accepted. > > > > > > > > > > Regarding systems with Intel+NVIDIA, we'll have to work with partners to > > > > collect > > > > > some information on the impact of reverting this. > > > > > > > > > > When this is used on a system with Intel+AMD the ASL configures AMD > > GPU to > > > > use > > > > > "Hybrid Graphics" when on Windows and "Power Express" and "Switchable > > > > Graphics" > > > > > when on Linux. > > > > > > > > and what's exactly the difference between those? And what's the actual > > > > issue here? > > > > > > DP/HDMI is not detected unless plugged in at bootup. It's due to missing HPD > > > events. > > > > > > > afaik Lyude was working on fixing all that, at least for some drivers. > > If there is something wrong, we still should fix the drivers, not > > adding ACPI workarounds. > > I don't disagree, but timing is frequently a limitation if you want the hardware to > work when you put it on the market. > > The whole idea behind the OSI string was that it could be reverted when the time > was right. From this discussion it very well may be for systems with AMD GPU, but > it needs to be checked again. > > > > > Alex: do you know if there are remaining issues regarding that with amdgpu? > > > > > > > > > > We already have the PRIME offloading in place and if that's not > > > > enough, we should work on extending it, not adding some ACPI based > > > > workarounds, because that's exactly how that looks like. > > > > > > > > Also, was this discussed with anybody involved in the drm subsystem? > > > > > > > > > > > > > > I feel we need a knob and/or DMI detection to affect the changes that the > > ASL > > > > > normally performs. > > > > > > > > Why do we have to do that on a firmware level at all? > > > > > > Folks from AMD Graphics team recommended this approach. > > I should clarify this is from the folks on AMD graphics team that interact to OEMs > like Dell which are not necessarily the same folks who work on the drivers directly. > yeah, I understand the pressure, and it might have been fine if we would have this discussion upstream, if it's about pushing things upstream. The commits itself didn't even make the impression that anybody with the drm drivers involved even looked at those patches and this is the worst part of those commits. > > From their perspective > > > it's not a workaround. They view this as a different architecture for AMD > > graphics driver on > > > Windows and AMD graphics w/ amdgpu driver. They have different ASL paths > > used for > > > each. > > > > @alex: is this true?
next prev parent reply index Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-14 21:31 [PATCH 0/7] Adding a proper workaround for fixing RTD3 issues with Nouveau Karol Herbst 2019-08-14 21:31 ` [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output" Karol Herbst 2019-08-14 21:49 ` Alex Hung 2019-08-14 22:47 ` [Nouveau] " Dave Airlie 2019-08-15 13:55 ` Mario.Limonciello 2019-08-15 14:04 ` Karol Herbst 2019-08-15 14:13 ` Alex Deucher 2019-08-15 14:15 ` Karol Herbst 2019-08-15 14:17 ` Alex Deucher 2019-08-15 14:23 ` Mario.Limonciello 2019-08-15 14:35 ` Karol Herbst 2019-08-15 14:41 ` Alex Deucher 2019-08-15 14:19 ` Mario.Limonciello 2019-08-15 14:25 ` Karol Herbst 2019-08-15 14:34 ` Mario.Limonciello 2019-08-15 14:36 ` Karol Herbst [this message] 2019-08-15 14:37 ` Alex Deucher 2019-08-15 14:56 ` Takashi Iwai 2019-08-15 16:19 ` Mario.Limonciello 2019-08-15 17:43 ` Takashi Iwai 2019-08-15 18:34 ` Alex Deucher 2019-08-15 14:59 ` Alex Deucher 2019-08-15 14:11 ` Daniel Vetter 2019-08-19 9:52 ` Rafael J. Wysocki 2019-09-05 15:51 ` Karol Herbst 2019-09-05 16:26 ` Rafael J. Wysocki 2019-09-09 21:07 ` Alex Hung 2019-10-21 2:14 ` Alex Hung 2019-10-21 8:14 ` Rafael J. Wysocki 2019-10-21 8:48 ` Karol Herbst 2019-10-21 8:54 ` Rafael J. Wysocki 2019-09-05 16:35 ` Alex Deucher 2019-08-14 21:31 ` [PATCH 2/7] Revert "ACPI / OSI: Add OEM _OSI string to enable NVidia HDMI audio" Karol Herbst 2019-08-14 21:31 ` [PATCH 3/7] Revert "ACPI / OSI: Add OEM _OSI strings to disable NVidia RTD3" Karol Herbst 2019-08-14 23:34 ` Alex Hung 2019-08-15 4:44 ` Karol Herbst 2019-08-14 21:31 ` [PATCH 4/7] drm/nouveau/pci: enable pcie link changes for pascal Karol Herbst 2019-08-14 21:31 ` [PATCH 5/7] drm/nouveau/pci: add nvkm_pcie_get_speed Karol Herbst 2019-08-14 21:31 ` [PATCH 6/7] drm/nouveau/pci: save the boot pcie link speed and restore it on fini Karol Herbst 2019-08-14 21:31 ` [PATCH 7/7] drm/nouveau: abort runtime suspend if we hit an error Karol Herbst
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CACO55tthEUVKJN_yCuGU95e8Zc+q-sJEsxML+ZYz7rpU9zDGCg@mail.gmail.com \ --email@example.com \ --cc=Mario.Limonciello@dell.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-ACPI Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-acpi/0 linux-acpi/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-acpi linux-acpi/ https://lore.kernel.org/linux-acpi \ email@example.com public-inbox-index linux-acpi Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-acpi AGPL code for this site: git clone https://public-inbox.org/public-inbox.git