From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0821C3A589 for ; Thu, 15 Aug 2019 14:37:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CCBB3206C1 for ; Thu, 15 Aug 2019 14:37:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732999AbfHOOhG (ORCPT ); Thu, 15 Aug 2019 10:37:06 -0400 Received: from mail-oi1-f194.google.com ([209.85.167.194]:37838 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731845AbfHOOhF (ORCPT ); Thu, 15 Aug 2019 10:37:05 -0400 Received: by mail-oi1-f194.google.com with SMTP id a21so2240314oie.4 for ; Thu, 15 Aug 2019 07:37:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IlFIaDmZ+sHHQP0mYa1mFOngV+vFJdYPAInzrgtIt0M=; b=OcndMqxtCcX25w64KBolaL++K9RdwxoelaFyE8ZglECgM01QRzUn7hYTma7HBhRQTh VW10Ysjfg6jAal4b2LH5HsRgntL6tKu6woVfS1Sb/HJjCaSGpcFGbx4p3SJM8V2jRmhs X1Koux1VYGIhPbxmCANOTRz3qFhegujnkQPDlouHzdadAoQpvXzkZj2Z2yWRcJIT476h fBRfA10mFaET1byO9RzTGi1UM6iGWYGEm85YHyJT8evLTAlzhIMgFz30eYvKsVy1Y0QL +eARxMrXp1rpeemABen+PO29vPXYCsRlbNuuUlfTNYh4RhOSrDFR7q1/XQZfoZqP7CB9 coqQ== X-Gm-Message-State: APjAAAWT6dLYgsRNDT818cTsJ9bazepBDLFgG06yHJBG8z/uZQ0ijQkf pGaMwo0b+StWvu13OS/VXnNBtq1CGXsOV85WNUGXMQ== X-Google-Smtp-Source: APXvYqxgZqfNjbixzTHbLRjdTOD1wqqdFX6azztBPpwrX8nyQmZuIbb1CWjlCWpdontsW35jrvxftk//41Vlnhpur4Y= X-Received: by 2002:a02:c487:: with SMTP id t7mr5232047jam.99.1565879825035; Thu, 15 Aug 2019 07:37:05 -0700 (PDT) MIME-Version: 1.0 References: <20190814213118.28473-1-kherbst@redhat.com> <20190814213118.28473-2-kherbst@redhat.com> <5e05532328324d01bc554c573f6298f8@AUSX13MPC101.AMER.DELL.COM> <3fc22fe8bcaf4304bb07534b61c4de90@AUSX13MPC101.AMER.DELL.COM> <54add026bb6f45fd94a2dc2bae4adf9f@AUSX13MPC101.AMER.DELL.COM> In-Reply-To: <54add026bb6f45fd94a2dc2bae4adf9f@AUSX13MPC101.AMER.DELL.COM> From: Karol Herbst Date: Thu, 15 Aug 2019 16:36:54 +0200 Message-ID: Subject: Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output" To: Mario.Limonciello@dell.com Cc: Dave Airlie , LKML , Linux ACPI Mailing List , dri-devel , nouveau , "Rafael J . Wysocki" , Alex Hung , Ben Skeggs , David Airlie Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Aug 15, 2019 at 4:34 PM wrote: > > > -----Original Message----- > > From: Karol Herbst > > Sent: Thursday, August 15, 2019 9:25 AM > > To: Limonciello, Mario > > Cc: Dave Airlie; LKML; Linux ACPI Mailing List; dri-devel; nouveau; Rafael J . > > Wysocki; Alex Hung; Ben Skeggs; David Airlie > > Subject: Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to > > enable dGPU direct output" > > > > > > [EXTERNAL EMAIL] > > > > On Thu, Aug 15, 2019 at 4:20 PM wrote: > > > > > > > > There are definitely going to be regressions on machines in the field with > > the > > > > > in tree drivers by reverting this. I think we should have an answer for all of > > > > those > > > > > before this revert is accepted. > > > > > > > > > > Regarding systems with Intel+NVIDIA, we'll have to work with partners to > > > > collect > > > > > some information on the impact of reverting this. > > > > > > > > > > When this is used on a system with Intel+AMD the ASL configures AMD > > GPU to > > > > use > > > > > "Hybrid Graphics" when on Windows and "Power Express" and "Switchable > > > > Graphics" > > > > > when on Linux. > > > > > > > > and what's exactly the difference between those? And what's the actual > > > > issue here? > > > > > > DP/HDMI is not detected unless plugged in at bootup. It's due to missing HPD > > > events. > > > > > > > afaik Lyude was working on fixing all that, at least for some drivers. > > If there is something wrong, we still should fix the drivers, not > > adding ACPI workarounds. > > I don't disagree, but timing is frequently a limitation if you want the hardware to > work when you put it on the market. > > The whole idea behind the OSI string was that it could be reverted when the time > was right. From this discussion it very well may be for systems with AMD GPU, but > it needs to be checked again. > > > > > Alex: do you know if there are remaining issues regarding that with amdgpu? > > > > > > > > > > We already have the PRIME offloading in place and if that's not > > > > enough, we should work on extending it, not adding some ACPI based > > > > workarounds, because that's exactly how that looks like. > > > > > > > > Also, was this discussed with anybody involved in the drm subsystem? > > > > > > > > > > > > > > I feel we need a knob and/or DMI detection to affect the changes that the > > ASL > > > > > normally performs. > > > > > > > > Why do we have to do that on a firmware level at all? > > > > > > Folks from AMD Graphics team recommended this approach. > > I should clarify this is from the folks on AMD graphics team that interact to OEMs > like Dell which are not necessarily the same folks who work on the drivers directly. > yeah, I understand the pressure, and it might have been fine if we would have this discussion upstream, if it's about pushing things upstream. The commits itself didn't even make the impression that anybody with the drm drivers involved even looked at those patches and this is the worst part of those commits. > > From their perspective > > > it's not a workaround. They view this as a different architecture for AMD > > graphics driver on > > > Windows and AMD graphics w/ amdgpu driver. They have different ASL paths > > used for > > > each. > > > > @alex: is this true?