From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA875C3A59C for ; Thu, 15 Aug 2019 14:15:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AAAF4208C2 for ; Thu, 15 Aug 2019 14:15:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731849AbfHOOP3 (ORCPT ); Thu, 15 Aug 2019 10:15:29 -0400 Received: from mail-oi1-f194.google.com ([209.85.167.194]:39863 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732151AbfHOOP2 (ORCPT ); Thu, 15 Aug 2019 10:15:28 -0400 Received: by mail-oi1-f194.google.com with SMTP id 16so2126140oiq.6 for ; Thu, 15 Aug 2019 07:15:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b9jb062JktpIPx3XCuJv3YXZ+jyDnT3aSJG503OYARU=; b=ZPfknyeVkNGUtc0WICbS5DTtG+IXH+R9lJLngg0AePNQ3gQmyvdRLnl1rwYQ3lSNd7 /JWY3o4vK+eilYnWmkJfzciNqAYi2zqDuG40xvGUWGlrpHQdCGOXeevjoZK8FciCN582 LGfa1OFtuCynYzf1gGXXLFNCucoi851rylO8g3vxcENXLW3rBWrwAxU6rA2NDZrQ3qU1 qMiC3hl5mYTwErAKHi7MSrnJdYgOevjcOwR+YswamdHcCXDOftqF2MgdIOwF/HvmZjAH nDbaqwdeInmZb6SbtPzjD5sWYn32u9/WsxT9vS8czNxRM2RaLcPV7OJa7ejlxY4w1cSQ oWlA== X-Gm-Message-State: APjAAAVw/iW/uFHeitkavjdeLtu7t46fFp3F7gSc/s4ESNYuotwN2Yf4 rBdttxSWnQHavxmODaT4qVQF5pVoRLjjLSIDgy0iuQ== X-Google-Smtp-Source: APXvYqxpnadQ2kgqSZUiV7ajsvFWIFx/uIZmcJ+cCemlrXrZgp22YXUqzkttXhECALkTzksoff48J80wrn/BFUt2Yt8= X-Received: by 2002:a02:69d1:: with SMTP id e200mr5260698jac.138.1565878527612; Thu, 15 Aug 2019 07:15:27 -0700 (PDT) MIME-Version: 1.0 References: <20190814213118.28473-1-kherbst@redhat.com> <20190814213118.28473-2-kherbst@redhat.com> <5e05532328324d01bc554c573f6298f8@AUSX13MPC101.AMER.DELL.COM> In-Reply-To: From: Karol Herbst Date: Thu, 15 Aug 2019 16:15:16 +0200 Message-ID: Subject: Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output" To: Alex Deucher Cc: Mario.Limonciello@dell.com, nouveau , "Rafael J . Wysocki" , LKML , dri-devel , Linux ACPI Mailing List , Alex Hung , Ben Skeggs , David Airlie Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Aug 15, 2019 at 4:13 PM Alex Deucher wrote: > > On Thu, Aug 15, 2019 at 10:04 AM Karol Herbst wrote: > > > > On Thu, Aug 15, 2019 at 3:56 PM wrote: > > > > > > > -----Original Message----- > > > > From: linux-acpi-owner@vger.kernel.org On > > > > Behalf Of Dave Airlie > > > > Sent: Wednesday, August 14, 2019 5:48 PM > > > > To: Karol Herbst > > > > Cc: LKML; Linux ACPI; dri-devel; nouveau; Rafael J . Wysocki; Alex Hung; Ben > > > > Skeggs; Dave Airlie > > > > Subject: Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to > > > > enable dGPU direct output" > > > > > > > > On Thu, 15 Aug 2019 at 07:31, Karol Herbst wrote: > > > > > > > > > > This reverts commit 28586a51eea666d5531bcaef2f68e4abbd87242c. > > > > > > > > > > The original commit message didn't even make sense. AMD _does_ support it and > > > > > it works with Nouveau as well. > > > > > > > > > > Also what was the issue being solved here? No references to any bugs and not > > > > > even explaining any issue at all isn't the way we do things. > > > > > > > > > > And even if it means a muxed design, then the fix is to make it work inside the > > > > > driver, not adding some hacky workaround through ACPI tricks. > > > > > > > > > > And what out of tree drivers do or do not support we don't care one bit anyway. > > > > > > > > > > > > > I think the reverts should be merged via Rafael's tree as the original > > > > patches went in via there, and we should get them in asap. > > > > > > > > Acked-by: Dave Airlie > > > > Dave. > > > > > > There are definitely going to be regressions on machines in the field with the > > > in tree drivers by reverting this. I think we should have an answer for all of those > > > before this revert is accepted. > > > > > > Regarding systems with Intel+NVIDIA, we'll have to work with partners to collect > > > some information on the impact of reverting this. > > > > > > When this is used on a system with Intel+AMD the ASL configures AMD GPU to use > > > "Hybrid Graphics" when on Windows and "Power Express" and "Switchable Graphics" > > > when on Linux. > > > > and what's exactly the difference between those? And what's the actual > > issue here? > > Hybrid Graphics is the new "standard" way of handling these laptops. > It uses the standard _PR3 APCI method to handle dGPU power. Support > for this was added to Linux relatively later compared to when the > laptops were launched. "Power Express" used the other AMD specific > ATPX ACPI method to handle dGPU power. The driver supports both so > either method will work. > > Alex > thanks for clarifying. But that still means that we won't need such workarounds for AMD users, right? amdgpu handles hybrid graphics just fine, right? > > > > We already have the PRIME offloading in place and if that's not > > enough, we should work on extending it, not adding some ACPI based > > workarounds, because that's exactly how that looks like. > > > > Also, was this discussed with anybody involved in the drm subsystem? > > > > > > > > I feel we need a knob and/or DMI detection to affect the changes that the ASL > > > normally performs. > > > > Why do we have to do that on a firmware level at all? > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel