From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D01DC32750 for ; Tue, 30 Jul 2019 22:56:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5ACE920679 for ; Tue, 30 Jul 2019 22:56:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZAkqDL2W" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726574AbfG3W44 (ORCPT ); Tue, 30 Jul 2019 18:56:56 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:36236 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726369AbfG3W4z (ORCPT ); Tue, 30 Jul 2019 18:56:55 -0400 Received: by mail-lj1-f195.google.com with SMTP id i21so63688438ljj.3 for ; Tue, 30 Jul 2019 15:56:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+wN4+Z8EREwCReGzTsl/8rDGQQqk+naMOiOedp6zWJ8=; b=ZAkqDL2WcRbEdbMCJfQ4ECnHrL3z9ekD2j9BetxyfB9dxe3kPqE6rzzpWXPQ4RazWz fkNO9gMIEKquR8OTHMphn6TH28OV/6L3wVIEOhYMMuqkvlPsarUt2xgCkB2qQal7P2ua lOXzYgq2/52OT3d6sooWP/JwIyogxYJQTAwX7OKTUXKwcz6l2jaSLrMVBViuEllp7+9H yiKrTvoAX5zKhd/M7ED3HdtbwIPJ0jrDTmKnSWu5VbBGfGUQuJq21umrdXUDPemTilTJ bd3/ieRg6cStN5wWN9gc/aYUOCv5VcH2HSBLCFiyzUX6EyayebKsyzQuHnxFefSveKvG j9mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+wN4+Z8EREwCReGzTsl/8rDGQQqk+naMOiOedp6zWJ8=; b=Huo794PqBichlN9tMlhJsVoFyM7OMM/LkiNR4IrQY7tYG+LLUUhH6IortO73J5OAFp l8wUeCiCcIpqm78xkJswj+jzqsQvQK41Mnm8NwWWbiImhDKXkMle6QMOgQP29ZoxSm4+ /aHx22z5Y5b2fpArAzaCaAfDV6+/DySEJnQXW/xTPrI/YkJ2YUbeqlk4mO1gl7ZSPl1Y Ioo9GW5CwqZIZ+VrjlQMNxZhi4j2vYCwoU74cA9uUc+HbbJjFB84RmvchEriuhLYcpAT 9yVmZzWOwP1XKxXefOnvIr6egcwQ7K5zVutdziE08YfX6QwoxoPADTp2GbhFBB6ohKal RhGA== X-Gm-Message-State: APjAAAWmyEuvH51/CffL9ccDr4u81RYNoYTPHD6p6zD2lsldn/KECCFe xuKOqvWoBVT0fVnPReDT8n68nJ6QPEhNlH47Cxji4bmu X-Google-Smtp-Source: APXvYqwgS2kvfds6buKdfqOySHYCa8XdVeMDL2lQfLz5OmrNB5zEBhwjL3FIjxO+wKpUnAP2aRtqcANGhUidIP+h+AE= X-Received: by 2002:a2e:8195:: with SMTP id e21mr59317626ljg.62.1564527413858; Tue, 30 Jul 2019 15:56:53 -0700 (PDT) MIME-Version: 1.0 References: <20190730104337.21235-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20190730104337.21235-1-andriy.shevchenko@linux.intel.com> From: Linus Walleij Date: Wed, 31 Jul 2019 00:56:41 +0200 Message-ID: Subject: Re: [PATCH v2 1/3] gpiolib: of: Reshuffle contents of consumer.h for new library layout To: Andy Shevchenko Cc: Bartosz Golaszewski , "open list:GPIO SUBSYSTEM" , Mika Westerberg , "Rafael J. Wysocki" , ACPI Devel Maling List , kbuild test robot Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Jul 30, 2019 at 12:43 PM Andy Shevchenko wrote: > Kernel build bot reported a compilation error after the commit > > f626d6dfb709 ("gpio: of: Break out OF-only code"): > > drivers/gpio/gpiolib-devres.o: In function `devm_gpiod_get_from_of_node': > gpiolib-devres.c:(.text+0x19a): undefined reference to `gpiod_get_from_of_node' > > This happens due to move the latter under umbrella of CONFIG_OF_GPIO while > customer.h contains staled data. > > Fix it by reshuffling contents of consumer.h to satisfy build dependencies. > > Reported-by: kbuild test robot > Fixes: f626d6dfb709 ("gpio: of: Break out OF-only code"): > Signed-off-by: Andy Shevchenko > --- > v2: no change Patch applied. THANKS for fixing this, I am on vacation so working on this a bit left-handedly. Yours, Linus Walleij