From: Linus Walleij <linus.walleij@linaro.org>
To: "Michał Stanek" <mst@semihalf.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
stanekm@google.com, stable <stable@vger.kernel.org>,
Marcin Wojtas <mw@semihalf.com>,
levinale@chromium.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH] pinctrl: cherryview: Add quirk with custom translation of ACPI GPIO numbers
Date: Mon, 10 Feb 2020 13:13:23 +0100 [thread overview]
Message-ID: <CACRpkdbBOfYQ9kxaDG4vwtnm1eu3yMDM-ZGJPyev-P4Fz5QT5A@mail.gmail.com> (raw)
In-Reply-To: <CAMiGqYjmd2edUezEXsX4JBSyOozzks1Pu8miPEviGsx=x59nZQ@mail.gmail.com>
On Sat, Feb 8, 2020 at 7:43 PM Michał Stanek <mst@semihalf.com> wrote:
> Actually it is a GPIO offset in ACPI tables for Braswell that was
> hardcoded in the old firmware to match the previous (consecutive)
> Linux GPIO numbering.
That's bad practice by the firmware authors. (Sad face)
We have enough problem saving ourselves from our own
legacy ABIs without someone handling out more guns to shoot
oneself in the foot with. :(
I'm also speaking on behalf of Microsoft and others in this I
think. In the past we would find Windowsisms in the BIOSes
and get really annoyed that we had to work around them.
Now there are Linuxisms in the BIOS, that's not any better.
Yours,
Linus Walleij
next prev parent reply other threads:[~2020-02-10 12:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 19:48 [PATCH] pinctrl: cherryview: Add quirk with custom translation of ACPI GPIO numbers Michal Stanek
2020-02-06 8:31 ` Mika Westerberg
2020-02-06 22:26 ` Michał Stanek
2020-02-07 7:56 ` Mika Westerberg
2020-02-08 18:43 ` Michał Stanek
2020-02-10 10:14 ` Mika Westerberg
2020-03-10 14:12 ` Michał Stanek
2020-03-10 14:49 ` Mika Westerberg
2020-03-25 22:50 ` Linus Walleij
2020-04-17 2:06 ` Brian Norris
2020-04-17 9:05 ` Mika Westerberg
2020-04-18 0:55 ` Brian Norris
2020-08-18 13:59 ` Andy Shevchenko
2020-02-10 12:13 ` Linus Walleij [this message]
2020-02-06 9:25 ` Andy Shevchenko
2020-02-06 18:31 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbBOfYQ9kxaDG4vwtnm1eu3yMDM-ZGJPyev-P4Fz5QT5A@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=dmitry.torokhov@gmail.com \
--cc=levinale@chromium.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mst@semihalf.com \
--cc=mw@semihalf.com \
--cc=rafael.j.wysocki@intel.com \
--cc=stable@vger.kernel.org \
--cc=stanekm@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).