From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29AE9C433EF for ; Sun, 2 Jan 2022 05:50:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230521AbiABFu2 (ORCPT ); Sun, 2 Jan 2022 00:50:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230502AbiABFu1 (ORCPT ); Sun, 2 Jan 2022 00:50:27 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39834C06173E for ; Sat, 1 Jan 2022 21:50:27 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id bp20so68457316lfb.6 for ; Sat, 01 Jan 2022 21:50:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nhN7NWahO9J/KN17ys1dyhTURCCVE5feduyNTBCD4xM=; b=n/TD9+cCUnrBWb1Y58ieKNbFn60JI2jFQKV2YEBjPI64whoto8M8+MwAAqxzOan8vs uS992VBDhpbqXVlRaeYGypHTx0YphkvM0KjCpM9L4DFqTyTirAr/ojZKMkRiZ4h3Kasg DbkdXHAFqUzXMtZTJTRq0iyB0xKNiJQpiQu6D4IRz9Q+bLZGJ5U3nXT/EfLeb+G5fsER 9fNzDFi/fGjX5JcPRTI+WT36n9OUnWk0djDmBRVhzNpm7HEGKTDKXOAmHUydwm77Tog9 SDUoWE3AmDVstIlBx9m/PXdl83AL/O+4cP/o4zxSA/s0ujJCUtLuvzfhxJAQgNm6N7yF kkqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nhN7NWahO9J/KN17ys1dyhTURCCVE5feduyNTBCD4xM=; b=ZJ1ciQvPzWMFd3MgL27SCnqRxfVjtqaXDwjs6VLGBWGnn5F98m0nLTOqYu2zsm5/+Z pXoNsQiCxiHcKOerFGtX0arsP1JLQVP+ZvT2z7ijkUfXVvMUNXsFHFk1gfFc0HoaV8sq rPYquQNTg5RsqeP1I7UO0wrJFkupJVw4PMI3LsyKyBd80qrM3pxzCCqdZYQsQb02gERO oB0y42/4FjV9ii/DsOiBPRIYkzlnE7+eVcqDGbGpJ5f97Sso3cwyt02bb4G9rH+iJYgf BcSi+F+2cZDqsPgQgaLNrNQpIJz3QYo0lmZmICbrXkuks8NvhwWBAK03kIGIl1VXqCHd pH+A== X-Gm-Message-State: AOAM53177SJ9/+0gQjKfgsV1KrUavdBW0Hw8baKwRE6kLwvdWJbKGPZG wIxcFpTfBPKdQjZW2MzAvUqLwFYimTaShZ93unNR8g== X-Google-Smtp-Source: ABdhPJxHWrcdDvJHL6Eo2PnCIxuGE9o8ruut2xQF63lFp6SbHL/k+lqi4MUG2iE58N3HEMEz7ldXBICcoY0TohhP++Q= X-Received: by 2002:a05:6512:261f:: with SMTP id bt31mr20407633lfb.400.1641102625444; Sat, 01 Jan 2022 21:50:25 -0800 (PST) MIME-Version: 1.0 References: <20211226153624.162281-1-marcan@marcan.st> <20211226153624.162281-11-marcan@marcan.st> In-Reply-To: <20211226153624.162281-11-marcan@marcan.st> From: Linus Walleij Date: Sun, 2 Jan 2022 06:50:13 +0100 Message-ID: Subject: Re: [PATCH 10/34] brcmfmac: firmware: Allow platform to override macaddr To: Hector Martin Cc: Kalle Valo , "David S. Miller" , Jakub Kicinski , Rob Herring , "Rafael J. Wysocki" , Len Brown , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Chung-hsien Hsu , Sven Peter , Alyssa Rosenzweig , Mark Kettenis , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Pieter-Paul Giesberts , Hans de Goede , "John W. Linville" , "Daniel (Deognyoun) Kim" , "brian m. carlson" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Sun, Dec 26, 2021 at 4:37 PM Hector Martin wrote: > On Device Tree platforms, it is customary to be able to set the MAC > address via the Device Tree, as it is often stored in system firmware. > This is particularly relevant for Apple ARM64 platforms, where this > information comes from system configuration and passed through by the > bootloader into the DT. > > Implement support for this by fetching the platform MAC address and > adding or replacing the macaddr= property in nvram. This becomes the > dongle's default MAC address. > > On platforms with an SROM MAC address, this overrides it. On platforms > without one, such as Apple ARM64 devices, this is required for the > firmware to boot (it will fail if it does not have a valid MAC at all). > > Signed-off-by: Hector Martin This looks very helpful. > + /* Add space for properties we may add */ > + size += strlen(BRCMF_FW_DEFAULT_BOARDREV) + 1; > + size += BRCMF_FW_MACADDR_LEN + 1; Add some note to the commit log why you also make space for boardrev? (Looks useful.) Is the boardrev spacing in the right patch? With that addressed: Reviewed-by: Linus Walleij Yours, Linus Walleij