From: Alex Deucher <alexdeucher@gmail.com> To: Karol Herbst <kherbst@redhat.com> Cc: Mario.Limonciello@dell.com, nouveau <nouveau@lists.freedesktop.org>, "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>, LKML <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, Linux ACPI Mailing List <linux-acpi@vger.kernel.org>, Alex Hung <alex.hung@canonical.com>, Ben Skeggs <bskeggs@redhat.com>, David Airlie <airlied@redhat.com> Subject: Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output" Date: Thu, 15 Aug 2019 10:59:09 -0400 Message-ID: <CADnq5_Oo4CMSx3Bi-41xXDCYKB9RRX33Gke9UyvAGZq1i+VOLA@mail.gmail.com> (raw) In-Reply-To: <CADnq5_Nv6tsW0J20td5rQSLq048HtTcw1b4c25jP6ZR6XWZ-eA@mail.gmail.com> On Thu, Aug 15, 2019 at 10:37 AM Alex Deucher <alexdeucher@gmail.com> wrote: > > On Thu, Aug 15, 2019 at 10:25 AM Karol Herbst <kherbst@redhat.com> wrote: > > > > On Thu, Aug 15, 2019 at 4:20 PM <Mario.Limonciello@dell.com> wrote: > > > > > > > > There are definitely going to be regressions on machines in the field with the > > > > > in tree drivers by reverting this. I think we should have an answer for all of > > > > those > > > > > before this revert is accepted. > > > > > > > > > > Regarding systems with Intel+NVIDIA, we'll have to work with partners to > > > > collect > > > > > some information on the impact of reverting this. > > > > > > > > > > When this is used on a system with Intel+AMD the ASL configures AMD GPU to > > > > use > > > > > "Hybrid Graphics" when on Windows and "Power Express" and "Switchable > > > > Graphics" > > > > > when on Linux. > > > > > > > > and what's exactly the difference between those? And what's the actual > > > > issue here? > > > > > > DP/HDMI is not detected unless plugged in at bootup. It's due to missing HPD > > > events. > > > > > > > afaik Lyude was working on fixing all that, at least for some drivers. > > If there is something wrong, we still should fix the drivers, not > > adding ACPI workarounds. > > > > Alex: do you know if there are remaining issues regarding that with amdgpu? > > There was an issue with hpd events not making it to the audio side > when things were powered down that was fixed with this patch set: > https://patchwork.freedesktop.org/patch/316793/ > Those patches depended on a bunch of alsa changes as well which may > have not been available in the distro used for a particular OEM > program. > > > > > > > > > > > We already have the PRIME offloading in place and if that's not > > > > enough, we should work on extending it, not adding some ACPI based > > > > workarounds, because that's exactly how that looks like. > > > > > > > > Also, was this discussed with anybody involved in the drm subsystem? > > > > > > > > > > > > > > I feel we need a knob and/or DMI detection to affect the changes that the ASL > > > > > normally performs. > > > > > > > > Why do we have to do that on a firmware level at all? > > > > > > Folks from AMD Graphics team recommended this approach. From their perspective > > > it's not a workaround. They view this as a different architecture for AMD graphics driver on > > > Windows and AMD graphics w/ amdgpu driver. They have different ASL paths used for > > > each. > > > > @alex: is this true? > > I'm not familiar with this patches in particular, but I know we've > done things with OEM programs to support Linux on platforms where > Linux support is lacking for in new features for the target distros. > E.g., when the first hybrid graphics laptops were coming out, Linux > didn't support it too well or at all depending on the timing, so the > bios exposed power express which was working well at the time if the > OS told ACPI it was Linux. FWIW, windows does something similar. I don't think windows 7 supports hybrid graphics either so if the OS tells ACPI it's windows 7, it gets power express instead of hybrid graphics as well. At least on laptops that support windows 7 in the first place. Alex > > Alex
next prev parent reply index Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-14 21:31 [PATCH 0/7] Adding a proper workaround for fixing RTD3 issues with Nouveau Karol Herbst 2019-08-14 21:31 ` [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output" Karol Herbst 2019-08-14 21:49 ` Alex Hung 2019-08-14 22:47 ` [Nouveau] " Dave Airlie 2019-08-15 13:55 ` Mario.Limonciello 2019-08-15 14:04 ` Karol Herbst 2019-08-15 14:13 ` Alex Deucher 2019-08-15 14:15 ` Karol Herbst 2019-08-15 14:17 ` Alex Deucher 2019-08-15 14:23 ` Mario.Limonciello 2019-08-15 14:35 ` Karol Herbst 2019-08-15 14:41 ` Alex Deucher 2019-08-15 14:19 ` Mario.Limonciello 2019-08-15 14:25 ` Karol Herbst 2019-08-15 14:34 ` Mario.Limonciello 2019-08-15 14:36 ` Karol Herbst 2019-08-15 14:37 ` Alex Deucher 2019-08-15 14:56 ` Takashi Iwai 2019-08-15 16:19 ` Mario.Limonciello 2019-08-15 17:43 ` Takashi Iwai 2019-08-15 18:34 ` Alex Deucher 2019-08-15 14:59 ` Alex Deucher [this message] 2019-08-15 14:11 ` Daniel Vetter 2019-08-19 9:52 ` Rafael J. Wysocki 2019-09-05 15:51 ` Karol Herbst 2019-09-05 16:26 ` Rafael J. Wysocki 2019-09-09 21:07 ` Alex Hung 2019-10-21 2:14 ` Alex Hung 2019-10-21 8:14 ` Rafael J. Wysocki 2019-10-21 8:48 ` Karol Herbst 2019-10-21 8:54 ` Rafael J. Wysocki 2019-09-05 16:35 ` Alex Deucher 2019-08-14 21:31 ` [PATCH 2/7] Revert "ACPI / OSI: Add OEM _OSI string to enable NVidia HDMI audio" Karol Herbst 2020-12-10 17:59 ` Lyude Paul 2019-08-14 21:31 ` [PATCH 3/7] Revert "ACPI / OSI: Add OEM _OSI strings to disable NVidia RTD3" Karol Herbst 2019-08-14 23:34 ` Alex Hung 2019-08-15 4:44 ` Karol Herbst 2019-08-14 21:31 ` [PATCH 4/7] drm/nouveau/pci: enable pcie link changes for pascal Karol Herbst 2019-08-14 21:31 ` [PATCH 5/7] drm/nouveau/pci: add nvkm_pcie_get_speed Karol Herbst 2019-08-14 21:31 ` [PATCH 6/7] drm/nouveau/pci: save the boot pcie link speed and restore it on fini Karol Herbst 2019-08-14 21:31 ` [PATCH 7/7] drm/nouveau: abort runtime suspend if we hit an error Karol Herbst
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CADnq5_Oo4CMSx3Bi-41xXDCYKB9RRX33Gke9UyvAGZq1i+VOLA@mail.gmail.com \ --to=alexdeucher@gmail.com \ --cc=Mario.Limonciello@dell.com \ --cc=airlied@redhat.com \ --cc=alex.hung@canonical.com \ --cc=bskeggs@redhat.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=kherbst@redhat.com \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=nouveau@lists.freedesktop.org \ --cc=rafael.j.wysocki@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-ACPI Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-acpi/0 linux-acpi/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-acpi linux-acpi/ https://lore.kernel.org/linux-acpi \ linux-acpi@vger.kernel.org public-inbox-index linux-acpi Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-acpi AGPL code for this site: git clone https://public-inbox.org/public-inbox.git