From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 424DFC282DC for ; Sun, 2 Jun 2019 12:24:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 184D427906 for ; Sun, 2 Jun 2019 12:24:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="eIiL2pGu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726691AbfFBMYt (ORCPT ); Sun, 2 Jun 2019 08:24:49 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:35119 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725977AbfFBMYs (ORCPT ); Sun, 2 Jun 2019 08:24:48 -0400 Received: by mail-lf1-f67.google.com with SMTP id a25so11434763lfg.2 for ; Sun, 02 Jun 2019 05:24:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d9XL3Kdg/XwAAZpeQtzVh3EdhTNcfgE61MkHiEb6f6I=; b=eIiL2pGuoT1uPZ6iXK+26kX3ON9RbP1IPb/stloJPcBPj9Zo94HojRPxXy/OkFOiPK X9H9+xcdJRrG5OhcVzQf2kFWuTRAl5KXardR/13k2qRA9L3/8mMVGyJhfmvfa1CKQ5lZ kXMSBhJU+EcziEfH4B1bkn1X38iaVN/7RnDp8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d9XL3Kdg/XwAAZpeQtzVh3EdhTNcfgE61MkHiEb6f6I=; b=ijZDt8YqiPAMK4VmdAkveAVQp7xINT3cdTxsxtdra8MnHIisQJQSfDVh/tDQ3/8th1 4hoWYRL7SXLrcnLn+XP/YS5pfNfo5TCCfjdUYqM5Xr4hQlyI5MY4MrzNhSPup88Zzf7f TzDwFTTX9JChANvzxICvU9eQ3IaEWn31onFNBWCz3KSK2UYYaOinxR+BPcvhUmfL/D6t KICiQ0t79Pu37yItBQGl3kuLwTy8SNBd/dQXjguFSjDdAZcl3z0kYocsYHUA7+G8Uax5 iKm4dOjSmyiPdpttE2zJXweffindtthhtEBe1FnB5fSGxAXJ340i1WfB8VMqJ4I2bW8r TFag== X-Gm-Message-State: APjAAAUdTANh7ENLQdiqhGXimzjY02NhNbMp4dTteRQaisvP7rwxjjPI SsNPVL4VgupUmN4GlSj46qb7RP0o4j904PXmLRjVxg== X-Google-Smtp-Source: APXvYqx4YBeHBoQTcjTH8I7UAKp3m6GHYEI6h8xOHmlpzR1QFhMBG6BANgkDDCynETKbf79fFNw+DGqbIxcWNN3SHnE= X-Received: by 2002:ac2:4544:: with SMTP id j4mr10902247lfm.176.1559478286535; Sun, 02 Jun 2019 05:24:46 -0700 (PDT) MIME-Version: 1.0 References: <20190601222738.6856-1-joel@joelfernandes.org> <20190601222738.6856-3-joel@joelfernandes.org> <20190602070014.GA543@amd> In-Reply-To: From: Joel Fernandes Date: Sun, 2 Jun 2019 08:24:35 -0400 Message-ID: Subject: Re: [RFC 2/6] ipv4: add lockdep condition to fix for_each_entry To: Pavel Machek Cc: LKML , Alexey Kuznetsov , Bjorn Helgaas , Borislav Petkov , "David S. Miller" , Eric Dumazet , Greg Kroah-Hartman , Hideaki YOSHIFUJI , "H. Peter Anvin" , Ingo Molnar , Josh Triplett , Kees Cook , Kernel Hardening , Lai Jiangshan , Len Brown , linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, Linux PM , Mathieu Desnoyers , Neil Brown , netdev , Oleg Nesterov , "Paul E. McKenney" , Peter Zilstra , "Rafael J. Wysocki" , rcu , Steven Rostedt , Tejun Heo , Thomas Gleixner , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Sun, Jun 2, 2019 at 8:20 AM Joel Fernandes wrote: > > On Sun, Jun 2, 2019 at 3:00 AM Pavel Machek wrote: > > > > On Sat 2019-06-01 18:27:34, Joel Fernandes (Google) wrote: > > > Signed-off-by: Joel Fernandes (Google) > > > > This really needs to be merged to previous patch, you can't break > > compilation in middle of series... > > > > Or probably you need hlist_for_each_entry_rcu_lockdep() macro with > > additional argument, and switch users to it. > > Good point. I can also just add a temporary transition macro, and then > remove it in the last patch. That way no new macro is needed. Actually, no. There is no compilation break so I did not follow what you mean. The fourth argument to the hlist_for_each_entry_rcu is optional. The only thing that happens is new lockdep warnings will arise which later parts of the series fix by passing in that fourth argument.