From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C427C388F7 for ; Thu, 5 Nov 2020 23:32:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D4542083B for ; Thu, 5 Nov 2020 23:32:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="R+M6ljMb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732396AbgKEXcm (ORCPT ); Thu, 5 Nov 2020 18:32:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726801AbgKEXcm (ORCPT ); Thu, 5 Nov 2020 18:32:42 -0500 Received: from mail-yb1-xb44.google.com (mail-yb1-xb44.google.com [IPv6:2607:f8b0:4864:20::b44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DEB1C0613CF for ; Thu, 5 Nov 2020 15:32:42 -0800 (PST) Received: by mail-yb1-xb44.google.com with SMTP id f6so2889969ybr.0 for ; Thu, 05 Nov 2020 15:32:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZlNXU8L3sc+m7lobXj6lchl7ijTptw1kaCcOIcaSPgI=; b=R+M6ljMb9p4EF+j7hVsSP50JIlCK4OhEmIi3kc0Oh9OJR5LX1PxyfNuxHV7xoDEaYE YdpO4m2sYjOBPMJz6KzYkTcEoROM/DNnXLCHIfFI/SmCDRg/sEqQVeXbtbEBup48wOxi Aohr3p8VnAHrN05tjYwRRNOQWEbjpjZNas1UOYx/fXIKTv5CY4SZDEpu7crHEP/b/RZp 7cQlnjQgz2Fmpom7VisiX7UsijfBXNZT6Nlx68P+BvmK4p8szYCBc65XhRXujuBf4vm0 arAC3YN02XoSO+Z01CbvIYBuFPshAZgA8jhXGU4p6aK6qD2dAI9kMysBuLdftf+BSuh6 bqSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZlNXU8L3sc+m7lobXj6lchl7ijTptw1kaCcOIcaSPgI=; b=Se15GPymfO06l+wsnL2sLJp7gCYu2QWkZ+ZX51/DXtQQ5ls1KN4TlGc1k/4xDBHh5H oKNIY78lB5leL4SMi7WZcNgP64Im/V9iJ+cDGSyralVaSBBRZTSM7vE7Ai8/wq86ktsL i1djwbFA1jyxlbnhHIBKcbMLrTwxhz/lHfTVpb0RRQCyMtim4wYyBgSWbOI7MTXIkrii LYP0YWpZlGkm9xCQi2OGT0nBPL+t/5gztVcXHpVHvRsjN5U1laHbU7Cknwx/3UiNShKr 3CWbFWJdr2rqIVy6yXXPuNuiwO41Gu6n1HdQkSUTm3yNTGshHihni+EwSUxOFbTo0yqQ 49Xw== X-Gm-Message-State: AOAM531BArHb9uk2miAY/r3crhPX/12zEyfTglth/ErGQ+ZCmWjPAaUv ChHuGGsM6UUFimD/qygRuWStMTIhptWinmv7gK46qA== X-Google-Smtp-Source: ABdhPJzzCr4BmURLVuAhnOzfU3X5o0Y4eA3x9j/YnSiCup69qb3WT2w/EdMw5wqJ7dawJsOTC6R4sqZFiyjNF8xV/bc= X-Received: by 2002:a25:f817:: with SMTP id u23mr7312436ybd.466.1604619161422; Thu, 05 Nov 2020 15:32:41 -0800 (PST) MIME-Version: 1.0 References: <20201104232356.4038506-1-saravanak@google.com> <20201104232356.4038506-18-saravanak@google.com> <20201105094350.GG3439341@kroah.com> In-Reply-To: <20201105094350.GG3439341@kroah.com> From: Saravana Kannan Date: Thu, 5 Nov 2020 15:32:05 -0800 Message-ID: Subject: Re: [PATCH v1 17/18] driver core: Add helper functions to convert fwnode links to device links To: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" , "Rafael J. Wysocki" , Len Brown , Ard Biesheuvel , Rob Herring , Frank Rowand , Marc Zyngier , Thomas Gleixner , Tomi Valkeinen , Laurent Pinchart , Grygorii Strashko , Android Kernel Team , ACPI Devel Maling List , LKML , linux-efi , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Nov 5, 2020 at 1:43 AM Greg Kroah-Hartman wrote: > > On Wed, Nov 04, 2020 at 03:23:54PM -0800, Saravana Kannan wrote: > > Add helper functions __fw_devlink_link_to_consumers() and > > __fw_devlink_link_to_suppliers() that convert fwnode links to device > > links. > > > > __fw_devlink_link_to_consumers() is for creating: > > - Device links between a newly added device and all its consumer devices > > that have been added to driver core. > > - Proxy SYNC_STATE_ONLY device links between the newly added device and > > the parent devices of all its consumers that have not been added to > > driver core yet. > > > > __fw_devlink_link_to_suppliers() is for creating: > > - Device links between a newly added device and all its supplier devices > > - Proxy SYNC_STATE_ONLY device links between the newly added device and > > all the supplier devices of its child device nodes. > > > > Signed-off-by: Saravana Kannan > > Did you just add build warnings with these static functions that no one > calls? The next patch in this series uses it. I'm just splitting it up into a separate patch so that it's digestible and I can provide more details in the commit text. Couple of options: 1. Drop the static in this patch and add it back when it's used in patch 18/18. 2. Drop the commit text and squash this with 18/18 if you think the function documentation is clear enough and it won't make patch 18/18 too hard to review. Please let me know which one you'd prefer or if you have other options. I don't have a strong opinion on how the patches are split up as long as it's easy for the reviewers and future folks who look at git log to understand stuff. -Saravana