From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C59E6C4320A for ; Thu, 26 Aug 2021 17:30:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE89D61058 for ; Thu, 26 Aug 2021 17:30:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243216AbhHZRbL (ORCPT ); Thu, 26 Aug 2021 13:31:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243135AbhHZRa6 (ORCPT ); Thu, 26 Aug 2021 13:30:58 -0400 Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD5EFC061757 for ; Thu, 26 Aug 2021 10:30:10 -0700 (PDT) Received: by mail-yb1-xb32.google.com with SMTP id e129so7370407yba.5 for ; Thu, 26 Aug 2021 10:30:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H1pLhNC6KYj6xtSbCEQcYzGpmuVWT9FKhX5+K+Ucayk=; b=t6pmA5rCyKM9N2sknfWDZ4LbPR1e1amqTFZLvR6wK2Zc1weiFrqMrE4a8FfVI45LMb mrRrMdXpdgPYNWX10KTSA4PYeOSwrf2mtDR/+nPOYBV+tuN0fyu8Q/5COhoXGcfrPNKG RQ+CzuANiF9QrnkL21ISoXWdp+OF2WAaJ1Uz4e8UvbaL6M28M6/a197Bc4G5HwZCJa2P flsIOQ/0EJlaOIjsgnyN4xf/ow74S0OPdRp1W/Bn1lAJRqEVpGAVKQx3xViMLm55xSCx ySRl2dmdnWh3PckyE2or7bxfNbFmfARLFQFJofDJWE8Nx4uz40rI4JAn0wGGco3ZH32O ODJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H1pLhNC6KYj6xtSbCEQcYzGpmuVWT9FKhX5+K+Ucayk=; b=BYdREvo8paWCxyc+B2oB6wlKDlknl7aPNDSQrc1d/EfUM4I9AvGxnoypA9iv3aU661 FaOWyOzReXeaITw+Op0fpNuKAhnGwKdFmCJpDivajovOq5lhA5hHpx5FUeL2JwATkfWC pQKavLZBqEYPdur9uNr77ggv/ZrI1EoUHrHjZGXGYnYNwIaafq7NfLmkE1HP0rKtvQFc bAoAHMzOEeTQ+yNeXC+EdDb85UOVYi+2Bf8LtOm40hS2c9VC+1Mx8iaa+uqq2CHDc1KU uUbK/lYzSiVG5UFzMNfcWAdD3Q9QzWN/1V5A6CJwpjO1D5Xumb+BZ2+8ZEVtA6DD9+Ie nQcw== X-Gm-Message-State: AOAM5313QtL1OoWpRXiaoOjjTwuvluDNr2aYJlWbMKFn2Po5qzvzQ1DG u4rPYCMXTe7coiJKXv/yzDqfxqFhvFJ7rx8kceUpEQ== X-Google-Smtp-Source: ABdhPJwofSmgGzYxpPFeSD3kewypH8C/hs/fMe8d3LyZt0QJ0QMPeZWUM6rZY0aBZXiBWIlwZRZEEVkixK7Uqv47zeY= X-Received: by 2002:a25:d213:: with SMTP id j19mr4915512ybg.20.1629999009793; Thu, 26 Aug 2021 10:30:09 -0700 (PDT) MIME-Version: 1.0 References: <20210826074526.825517-1-saravanak@google.com> <20210826074526.825517-3-saravanak@google.com> <96014c79-44f6-dea2-2b53-6cbfebac9351@gmail.com> In-Reply-To: <96014c79-44f6-dea2-2b53-6cbfebac9351@gmail.com> From: Saravana Kannan Date: Thu, 26 Aug 2021 10:29:33 -0700 Message-ID: Subject: Re: [PATCH v1 2/2] net: dsa: rtl8366rb: Quick fix to work with fw_devlink=on To: Florian Fainelli Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Linus Walleij , Andrew Lunn , Vivien Didelot , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Len Brown , Alvin Sipraga , kernel-team@android.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-acpi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Aug 26, 2021 at 4:25 AM Florian Fainelli wrote: > > > > On 8/26/2021 9:45 AM, Saravana Kannan wrote: > > This is just a quick fix to make this driver work with fw_devlink=on. > > The proper fix might need a significant amount of rework of the driver > > of the framework to use a component device model. > > > > Signed-off-by: Saravana Kannan > > --- > > drivers/net/dsa/realtek-smi-core.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/net/dsa/realtek-smi-core.c b/drivers/net/dsa/realtek-smi-core.c > > index 8e49d4f85d48..f79c174f4954 100644 > > --- a/drivers/net/dsa/realtek-smi-core.c > > +++ b/drivers/net/dsa/realtek-smi-core.c > > @@ -394,6 +394,13 @@ static int realtek_smi_probe(struct platform_device *pdev) > > var = of_device_get_match_data(dev); > > np = dev->of_node; > > > > + /* This driver assumes the child PHYs would be probed successfully > > + * before this functions returns. That's not a valid assumption, but > > + * let fw_devlink know so that this driver continues to function with > > + * fw_devlink=on. > > + */ > > + np->fwnode.flags |= FWNODE_FLAG_BROKEN_PARENT; > > Are we positive this is not an issue that applies generally to all DSA > drivers? Possibly, but I don't know enough about that framework. Let me respond to the email from Andrew[1] and give a summary there. We can go from there. [1] - https://lore.kernel.org/lkml/YSeTdb6DbHbBYabN@lunn.ch/#t -Saravana