From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98882C433F5 for ; Wed, 15 Sep 2021 16:44:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 74F5360FC0 for ; Wed, 15 Sep 2021 16:44:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229676AbhIOQqO (ORCPT ); Wed, 15 Sep 2021 12:46:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229665AbhIOQqO (ORCPT ); Wed, 15 Sep 2021 12:46:14 -0400 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32708C061575 for ; Wed, 15 Sep 2021 09:44:55 -0700 (PDT) Received: by mail-yb1-xb29.google.com with SMTP id c206so6911180ybb.12 for ; Wed, 15 Sep 2021 09:44:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SoEro/pOot3RDQ6oHi20QrcukaWZiRl8hEvD0rocWMM=; b=h84HDKGSfFbvCCheUBvsV5ZXDbwYVjGSIKtBjTdvax/i4LEqGK3JrAEhwzUpMhZyBS cSnWQtBb2krYDxK7KjZWFWVtR5cq55F+pXvJq22D1JOhDVuahKYAYTsKWqDKmuLkN/+t UuaakJFAQYaaB1mzq4SgCTkJXuMyLCGT/7kvxl+n2mxzgUHyfscnJJSQtQ38zeQ9u+Le LT8i1jv/j2J0P674H5M+bvBFngQT80M/Yy1lkDIvza7zhdACAKZmZHOfRJ+nwM0+wf8z K+ZMxh6Vr7320YJinCwXo/8H7lQVHMTREPlgXgXK9sn6FTQZGlrFfiBpuk/Ecqc4XBtK FS2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SoEro/pOot3RDQ6oHi20QrcukaWZiRl8hEvD0rocWMM=; b=BtWIElWysyAUi29inQbYMCVhzPBS7AdAO+uUZG+5iwxSoynZZLSISRphu1t9wo9m9j tcWCvSQbgGetpDTtBTWabSi4XYN/bE/g4IrJhI7Tc3i9D4AoG9sdqB+jICSJ9ftvygeJ Tru9vOHFejmzXHUzyNrp8XrUoTxxADTuuqkUMOuTtrewsxC0wdsn7eAFNq+LtX4HVvOF 9Y5KBmXafJDB93H4ZHGDfUbTizRHFso91mVloyCFy8o6OEwfmtfz65TJNA5pluRmFrnS 1KMHqT1w0BfRwbk5CPy/W+9GkSzGhlHq6XjptKSSwYQj4uiZj7Ffcqx/reuaV5MTO9DU rSXw== X-Gm-Message-State: AOAM532YVT3OFexVHXdvUTTG3FjO3JMEESddagNjKahfM7JaeAPl6kn4 6UAY4sruOZTEJif61ho7qgsya5galA8bbewIui3CHw== X-Google-Smtp-Source: ABdhPJynAzZvXI3gSdy0YPIzVlH0PpPiIWWFob0j+Akw0Mx/NnZ6oq39PZR9NHlAxE9NtA1aCYvps4T2VvDzG9qPvCs= X-Received: by 2002:a25:2b07:: with SMTP id r7mr1047682ybr.296.1631724294182; Wed, 15 Sep 2021 09:44:54 -0700 (PDT) MIME-Version: 1.0 References: <20210915081139.480263-1-saravanak@google.com> <9c437d41-05b2-8e22-a537-d9aa7865f01b@samsung.com> In-Reply-To: <9c437d41-05b2-8e22-a537-d9aa7865f01b@samsung.com> From: Saravana Kannan Date: Wed, 15 Sep 2021 09:44:16 -0700 Message-ID: Subject: Re: [PATCH v2 0/6] fw_devlink improvements To: Marek Szyprowski Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , Len Brown , John Stultz , Rob Herring , Geert Uytterhoeven , Vladimir Oltean , kernel-team@android.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-acpi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Wed, Sep 15, 2021 at 1:44 AM Marek Szyprowski wrote: > > Hi Saravana, > > On 15.09.2021 10:11, Saravana Kannan wrote: > > Patches ready for picking up: > > Patch 1 fixes a bug in fw_devlink. > > Patch 2-4 are meant to make debugging easier > > Patch 5 and 6 fix fw_devlink issues with PHYs and networking > > Is this patchset supposed to fix the PHY related issues I've experienced > or does it also require the Andrew's patch for 'mdio-parent-bus'? If the > first, then applying only this patchset on top of today's linux-next > doesn't fix the ethernet issue on my Amlogic SoC based test boards. Marek, The issue you hit was actually a general issue with fw_devlink and that's fixed by Patch 1. But I also needed to revert the phy-handle patch for other reasons (see commit text) and that fixes the issue you were hitting without needing the 'mdio-parent-bus' patch. https://lore.kernel.org/lkml/20210915081933.485112-1-saravanak@google.com/ When I eventually bring back phy-handle support, I'll need the 'mdio-parent-bus' to not break your use case. Hope that clarifies things. -Saravana > > > Andrew, > > > > I think Patch 5 and 6 should be picked up be Greg too. Let me know if > > you disagree. > > > > -Saravana > > > > Cc: John Stultz > > Cc: Marek Szyprowski > > Cc: Rob Herring > > Cc: Geert Uytterhoeven > > Cc: Andrew Lunn > > Cc: Vladimir Oltean > > > > v1->v2: > > - Added a few Reviewed-by and Tested-by tags > > - Addressed Geert's comments in patches 3 and 5 > > - Dropped the fw_devlink.debug patch > > - Added 2 more patches to the series to address other fw_devlink issues > > > > Thanks, > > Saravana > > > > Saravana Kannan (6): > > driver core: fw_devlink: Improve handling of cyclic dependencies > > driver core: Set deferred probe reason when deferred by driver core > > driver core: Create __fwnode_link_del() helper function > > driver core: Add debug logs when fwnode links are added/deleted > > driver core: fw_devlink: Add support for FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD > > net: mdiobus: Set FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD for mdiobus parents > > > > drivers/base/core.c | 90 ++++++++++++++++++++++++++------------ > > drivers/net/phy/mdio_bus.c | 4 ++ > > include/linux/fwnode.h | 11 +++-- > > 3 files changed, 75 insertions(+), 30 deletions(-) > > > Best regards > -- > Marek Szyprowski, PhD > Samsung R&D Institute Poland >