From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C7C1C433EF for ; Tue, 21 Sep 2021 22:27:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3557C61107 for ; Tue, 21 Sep 2021 22:27:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235939AbhIUW2i (ORCPT ); Tue, 21 Sep 2021 18:28:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233160AbhIUW2h (ORCPT ); Tue, 21 Sep 2021 18:28:37 -0400 Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C223C061574 for ; Tue, 21 Sep 2021 15:27:08 -0700 (PDT) Received: by mail-qk1-x729.google.com with SMTP id c7so2956909qka.2 for ; Tue, 21 Sep 2021 15:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=w/NniegAPsrqQovylT0x9NdPmzuMLuCowwMM3/4Onrw=; b=ghpssHVgObsePZG2YaoSQ2quCtUJuEd+tpwL75F4+ZiQHCroqi5rVSH2ZqzuJPKDyE miQF0K4xr278cH3ExdUkk7Kew9L0K1HdsgX1dhdCizJxDByC9ZylYWb7lMVnwOPwHK9G WmQReFJ1UZxLZLt2WnU+bf3PwrEIWEfcMGnBtPtW9w+vIilWCiAGXvhB7wZGSzoifFeP BKP261L03zHAU4mK0No44udA4T9V/oVsFItOWAU8WZAB89A7BEeEjCehQ/aEhJ/fstbi 30nFWBr7aifNRAa8U9mptzSxjfS4zQ7Cbi345F6RzpMaocweM5q1G0SYPhoOCK+z+/BB 1SSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w/NniegAPsrqQovylT0x9NdPmzuMLuCowwMM3/4Onrw=; b=eU1SDbZGqUnRdtYxPTjZ4+MxXdTWaRP5TgY+b66W/0L+Ej1ylZJZOsAZt2uhnRhtlW HmGS7tHPkn19WYqGcDMYzJ6j748o/U5cAfDkRoeOY4IOPh/BNzgtxL3MCuRxjIXAhaUU KEkpitMsYZ5f3NAyIp3mElSoJKm6XVTDG3vO0xtuYLL3xknsJb+qiF6qQCZVy8LsuCCf mQSrQpb3mVxvxYQxW2fsktoiBsNy/iwDiqHv8MP4yUpG3x3EFsMFW2eJ88i6lihf5/9t BO7FOvDHj+3kKSgZdq3j+sGUYYpgxKPe9nEwhkeA1HGaM/y2QLHIwUpVcrOcDu7Ytw29 wRsw== X-Gm-Message-State: AOAM5308xFLyhYVJm5uhWMx0dPqFUs3JYnXd79wrzd84GVYDWIkFlBkn MbQFkWhMoCrzkN8BfwyH+YbhmX1IFn0IszjBSwWzSQ== X-Google-Smtp-Source: ABdhPJxcziC4sfd1j8S82m5DEO1q33o86vhq5rhsTYZKiMFbaEe6ncY4ZucVAUPhAY3Ew7XWld4rers0+g8ztdMSLYA= X-Received: by 2002:a25:6543:: with SMTP id z64mr5960602ybb.486.1632263227316; Tue, 21 Sep 2021 15:27:07 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Saravana Kannan Date: Tue, 21 Sep 2021 15:26:31 -0700 Message-ID: Subject: Re: [PATCH v3 2/3] driver core: fw_devlink: Add support for FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD To: Andrew Lunn Cc: "Rafael J. Wysocki" , Greg Kroah-Hartman , Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , Len Brown , Geert Uytterhoeven , Vladimir Oltean , "Cc: Android Kernel" , Linux Kernel Mailing List , netdev , ACPI Devel Maling List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Sep 21, 2021 at 3:04 PM Andrew Lunn wrote: > > On Tue, Sep 21, 2021 at 02:54:47PM -0700, Saravana Kannan wrote: > > On Tue, Sep 21, 2021 at 2:03 PM Andrew Lunn wrote: > > > > > > > There are cases where the children try to probe too quickly (before > > > > the parent has had time to set up all the resources it's setting up) > > > > and the child defers the probe. Even Andrew had an example of that > > > > with some ethernet driver where the deferred probe is attempted > > > > multiple times wasting time and then it eventually succeeds. > > > > > > And i prefer an occasional EPROBE_DEFER over a broken Ethernet switch, > > > which is the current state. I'm happy to see optimisations, but not at > > > the expense of breaking working stuff. > > > > Right, but in that case, the long term solution should be to make > > changes so we don't expect the child to be bound as soon as it's > > added. Not disable the optimization. Agree? > > Maybe. Lets see how you fix what is currently broken. At the moment, i > don't care too much about the long term solution. The current quick > fix for stable does not seem to be making any progress. So we need the > real fix now, to unbreak what is currently broken, then we can think > about the long term. Wait, what's the difference between a real fix vs a long term fix? To me those are the same. I agree that having DSA be broken till we have the final fix isn't good. Especially because DSA is complicated and the over eager gen PHY driver makes it even harder to fix it quickly. Merging this patch gives an exception to DSA, while we figure out a good fix. It also makes sure more drivers don't get merged with the same assumptions (because fw_devlink=on won't give them the exception). Greg/Rafael, can we merge this please while we figure out a fix for DSA/PHY. It's a non-trivial problem to solve because PHYs need some kind of driver "match rating". -Saravana