From: Saravana Kannan <saravanak@google.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Tudor Ambarus <tudor.ambarus@microchip.com>,
Jonathan Corbet <corbet@lwn.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
"Brown, Len" <len.brown@intel.com>, Len Brown <lenb@kernel.org>,
Pavel Machek <pavel@ucw.cz>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Marc Zyngier <maz@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Linux Doc Mailing List <linux-doc@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Android Kernel Team <kernel-team@android.com>
Subject: Re: [PATCH] clk: Mark fwnodes when their clock provider is added
Date: Wed, 21 Apr 2021 00:00:41 -0700 [thread overview]
Message-ID: <CAGETcx_nb4HTGqAME_pVu3gjZ9UQabsi7hsXzB47_Qsp7vRcdA@mail.gmail.com> (raw)
In-Reply-To: <20210421032653.GA179924@roeck-us.net>
On Tue, Apr 20, 2021 at 8:27 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> Hi,
>
> On Wed, Feb 10, 2021 at 01:44:35PM +0200, Tudor Ambarus wrote:
> > This is a follow-up for:
> > commit 3c9ea42802a1 ("clk: Mark fwnodes when their clock provider is added/removed")
> >
> > The above commit updated the deprecated of_clk_add_provider(),
> > but missed to update the preferred of_clk_add_hw_provider().
> > Update it now.
> >
> > Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>
> This patch still causes a crash when booting a raspi2 image in linux-next.
Stephen,
Can we please just pick any one of the proposed fixes? This bug has
been unfixed for so long!
-Saravana
>
> [ 21.456500] Unable to handle kernel NULL pointer dereference at virtual address 00000028
> [ 21.456750] pgd = (ptrval)
> [ 21.456927] [00000028] *pgd=00000000
> [ 21.457567] Internal error: Oops: 5 [#1] SMP ARM
> [ 21.457882] Modules linked in:
> [ 21.458077] CPU: 0 PID: 77 Comm: kworker/u8:10 Not tainted 5.12.0-rc8-next-20210420 #1
> [ 21.458291] Hardware name: BCM2835
> [ 21.458525] Workqueue: events_unbound deferred_probe_work_func
> [ 21.458997] PC is at of_clk_add_hw_provider+0xbc/0xe8
> [ 21.459176] LR is at of_clk_add_hw_provider+0xa8/0xe8
> ...
> [ 21.477603] [<c0a32aec>] (of_clk_add_hw_provider) from [<c0a32b60>] (devm_of_clk_add_hw_provider+0x48/0x80)
> [ 21.477861] [<c0a32b60>] (devm_of_clk_add_hw_provider) from [<c0a471e4>] (raspberrypi_clk_probe+0x260/0x388)
> [ 21.478087] [<c0a471e4>] (raspberrypi_clk_probe) from [<c0c1c4d0>] (platform_probe+0x5c/0xb8)
> [ 21.478287] [<c0c1c4d0>] (platform_probe) from [<c0c19d84>] (really_probe+0xf0/0x39c)
> [ 21.478471] [<c0c19d84>] (really_probe) from [<c0c1a098>] (driver_probe_device+0x68/0xc0)
> [ 21.478659] [<c0c1a098>] (driver_probe_device) from [<c0c17f54>] (bus_for_each_drv+0x84/0xc8)
> [ 21.478860] [<c0c17f54>] (bus_for_each_drv) from [<c0c19c20>] (__device_attach+0xec/0x158)
> [ 21.479050] [<c0c19c20>] (__device_attach) from [<c0c18de8>] (bus_probe_device+0x88/0x90)
> [ 21.479236] [<c0c18de8>] (bus_probe_device) from [<c0c16a68>] (device_add+0x398/0x8ac)
> [ 21.479421] [<c0c16a68>] (device_add) from [<c0c1c1b4>] (platform_device_add+0xf0/0x200)
> [ 21.479607] [<c0c1c1b4>] (platform_device_add) from [<c0c1ccc0>] (platform_device_register_full+0xd0/0x110)
> [ 21.479836] [<c0c1ccc0>] (platform_device_register_full) from [<c104c130>] (rpi_firmware_probe+0x1a4/0x20c)
> [ 21.480061] [<c104c130>] (rpi_firmware_probe) from [<c0c1c4d0>] (platform_probe+0x5c/0xb8)
> [ 21.480255] [<c0c1c4d0>] (platform_probe) from [<c0c19d84>] (really_probe+0xf0/0x39c)
> [ 21.480437] [<c0c19d84>] (really_probe) from [<c0c1a098>] (driver_probe_device+0x68/0xc0)
> [ 21.480626] [<c0c1a098>] (driver_probe_device) from [<c0c17f54>] (bus_for_each_drv+0x84/0xc8)
> [ 21.480829] [<c0c17f54>] (bus_for_each_drv) from [<c0c19c20>] (__device_attach+0xec/0x158)
> [ 21.481018] [<c0c19c20>] (__device_attach) from [<c0c18de8>] (bus_probe_device+0x88/0x90)
> [ 21.481205] [<c0c18de8>] (bus_probe_device) from [<c0c192bc>] (deferred_probe_work_func+0x8c/0xbc)
> [ 21.481413] [<c0c192bc>] (deferred_probe_work_func) from [<c036802c>] (process_one_work+0x268/0x798)
> [ 21.481624] [<c036802c>] (process_one_work) from [<c0368774>] (worker_thread+0x218/0x4f4)
> [ 21.481822] [<c0368774>] (worker_thread) from [<c0370f28>] (kthread+0x140/0x174)
> [ 21.481999] [<c0370f28>] (kthread) from [<c030017c>] (ret_from_fork+0x14/0x38)
> [ 21.482185] Exception stack(0xc42b7fb0 to 0xc42b7ff8)
>
> Updated bisect log is attached.
>
> Guenter
>
> ---
> # bad: [50b8b1d699ac313c0a07a3c185ffb23aecab8abb] Add linux-next specific files for 20210419
> # good: [bf05bf16c76bb44ab5156223e1e58e26dfe30a88] Linux 5.12-rc8
> git bisect start 'HEAD' 'v5.12-rc8'
> # good: [c4bb91fc07e59241cde97f913d7a2fbedc248f0d] Merge remote-tracking branch 'crypto/master'
> git bisect good c4bb91fc07e59241cde97f913d7a2fbedc248f0d
> # good: [f15bbf170b40b48a43ed7076ce9f8ac9380e5752] Merge remote-tracking branch 'edac/edac-for-next'
> git bisect good f15bbf170b40b48a43ed7076ce9f8ac9380e5752
> # bad: [550a78090dcc4061e191312a757a127f0b6e6323] Merge remote-tracking branch 'vfio/next'
> git bisect bad 550a78090dcc4061e191312a757a127f0b6e6323
> # bad: [9f074d2a7bf49b2c9e1609703757b18de7611aef] Merge remote-tracking branch 'usb/usb-next'
> git bisect bad 9f074d2a7bf49b2c9e1609703757b18de7611aef
> # good: [855b2fdb7c543c94e7623e6ad0b492f04a5317db] Merge remote-tracking branch 'percpu/for-next'
> git bisect good 855b2fdb7c543c94e7623e6ad0b492f04a5317db
> # good: [1d08ed588c6a85a35a24c82eb4cf0807ec2b366a] usbip: vudc: fix missing unlock on error in usbip_sockfd_store()
> git bisect good 1d08ed588c6a85a35a24c82eb4cf0807ec2b366a
> # good: [1b7ce8fab5fd0c406dbf165b12d44b301decf589] Merge remote-tracking branch 'ipmi/for-next'
> git bisect good 1b7ce8fab5fd0c406dbf165b12d44b301decf589
> # good: [fe8e488058c47e9a8a2c85321f7198a0a17b0131] dt-bindings: usb: mtk-xhci: add wakeup interrupt
> git bisect good fe8e488058c47e9a8a2c85321f7198a0a17b0131
> # bad: [3c652132ce9052e626bf509932fcacfebed1ccb4] platform-msi: fix kernel-doc warnings
> git bisect bad 3c652132ce9052e626bf509932fcacfebed1ccb4
> # bad: [7f2fac70b729d68a34e5eba8d1fb68eb69b05169] device property: Add test cases for fwnode_property_count_*() APIs
> git bisect bad 7f2fac70b729d68a34e5eba8d1fb68eb69b05169
> # good: [38f087de8947700d3b06d3d1594490e0f611c5d1] devtmpfs: fix placement of complete() call
> git bisect good 38f087de8947700d3b06d3d1594490e0f611c5d1
> # good: [b6f617df4fa936c1ab1831c2b23563f6c1add6c4] driver core: Update device link status properly for device_bind_driver()
> git bisect good b6f617df4fa936c1ab1831c2b23563f6c1add6c4
> # bad: [6579c8d97ad7fc5671ee60234f3b8388abee5f77] clk: Mark fwnodes when their clock provider is added
> git bisect bad 6579c8d97ad7fc5671ee60234f3b8388abee5f77
> # good: [ea718c699055c8566eb64432388a04974c43b2ea] Revert "Revert "driver core: Set fw_devlink=on by default""
> git bisect good ea718c699055c8566eb64432388a04974c43b2ea
> # first bad commit: [6579c8d97ad7fc5671ee60234f3b8388abee5f77] clk: Mark fwnodes when their clock provider is added
next prev parent reply other threads:[~2021-04-21 7:01 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210205222651eucas1p28ef87073dea33c1c5224c14aa203bec5@eucas1p2.samsung.com>
2021-02-05 22:26 ` [PATCH v4 0/8] Make fw_devlink=on more forgiving Saravana Kannan
2021-02-05 22:26 ` [PATCH v4 1/8] driver core: fw_devlink: Detect supplier devices that will never be added Saravana Kannan
2021-02-05 22:26 ` [PATCH v4 2/8] of: property: Don't add links to absent suppliers Saravana Kannan
2021-02-09 21:25 ` Rob Herring
2021-02-05 22:26 ` [PATCH v4 3/8] driver core: Add fw_devlink.strict kernel param Saravana Kannan
2021-02-05 22:26 ` [PATCH v4 4/8] of: property: Add fw_devlink support for optional properties Saravana Kannan
2021-02-09 21:33 ` Rob Herring
2021-02-09 21:54 ` Saravana Kannan
2021-02-10 8:25 ` Geert Uytterhoeven
2021-02-05 22:26 ` [PATCH v4 5/8] driver core: fw_devlink: Handle suppliers that don't use driver core Saravana Kannan
2021-02-05 22:26 ` [PATCH v4 6/8] irqdomain: Mark fwnodes when their irqdomain is added/removed Saravana Kannan
2021-02-05 22:26 ` [PATCH v4 7/8] PM: domains: Mark fwnodes when their powerdomain " Saravana Kannan
2021-02-05 22:26 ` [PATCH v4 8/8] clk: Mark fwnodes when their clock provider " Saravana Kannan
2021-02-08 15:38 ` Rob Herring
2021-02-08 23:34 ` Saravana Kannan
2021-02-10 11:44 ` [PATCH] clk: Mark fwnodes when their clock provider is added Tudor Ambarus
2021-02-10 11:44 ` Tudor Ambarus
2021-02-11 13:00 ` Greg KH
2021-02-13 0:37 ` Stephen Boyd
[not found] ` <CGME20210325133159eucas1p297b769beb681743fb32d362a86cc6e3e@eucas1p2.samsung.com>
2021-03-25 13:31 ` Marek Szyprowski
2021-03-25 15:47 ` Geert Uytterhoeven
2021-03-25 18:25 ` Nicolas Saenz Julienne
2021-03-26 18:13 ` Stephen Boyd
2021-03-26 18:29 ` Geert Uytterhoeven
2021-04-21 3:26 ` Guenter Roeck
2021-04-21 7:00 ` Saravana Kannan [this message]
2021-02-10 19:13 ` Saravana Kannan
2021-03-30 15:42 ` Guenter Roeck
2021-03-30 16:26 ` Saravana Kannan
[not found] ` <161317679292.1254594.15797939257637374295@swboyd.mtv.corp.google.com>
2021-02-14 21:15 ` [PATCH v4 8/8] clk: Mark fwnodes when their clock provider is added/removed Saravana Kannan
2021-02-06 2:45 ` [PATCH v4 0/8] Make fw_devlink=on more forgiving Saravana Kannan
2021-02-06 19:41 ` Geert Uytterhoeven
2021-02-06 20:47 ` Saravana Kannan
2021-02-08 8:40 ` Marek Szyprowski
2021-02-08 23:57 ` Saravana Kannan
2021-02-10 8:19 ` Tudor.Ambarus
2021-02-10 8:54 ` Saravana Kannan
2021-02-10 10:02 ` Tudor.Ambarus
2021-02-10 19:14 ` Saravana Kannan
2021-02-11 13:00 ` Geert Uytterhoeven
2021-02-11 13:05 ` Geert Uytterhoeven
2021-02-12 2:59 ` Saravana Kannan
2021-02-12 8:14 ` Geert Uytterhoeven
2021-02-12 20:57 ` Saravana Kannan
2021-02-15 12:38 ` Geert Uytterhoeven
2021-02-15 21:26 ` Saravana Kannan
2021-02-16 8:05 ` Geert Uytterhoeven
2021-02-16 18:48 ` Saravana Kannan
2021-02-16 20:31 ` Geert Uytterhoeven
2021-02-17 23:57 ` Saravana Kannan
2021-02-25 9:21 ` Geert Uytterhoeven
2021-02-15 15:16 ` Geert Uytterhoeven
2021-02-15 21:57 ` Saravana Kannan
2021-02-16 12:58 ` Geert Uytterhoeven
2021-02-15 11:19 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGETcx_nb4HTGqAME_pVu3gjZ9UQabsi7hsXzB47_Qsp7vRcdA@mail.gmail.com \
--to=saravanak@google.com \
--cc=claudiu.beznea@microchip.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=khilman@kernel.org \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=m.szyprowski@samsung.com \
--cc=maz@kernel.org \
--cc=mturquette@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=tudor.ambarus@microchip.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).