From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 504A5C433EF for ; Mon, 21 Mar 2022 17:06:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351595AbiCURHt (ORCPT ); Mon, 21 Mar 2022 13:07:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351585AbiCURHo (ORCPT ); Mon, 21 Mar 2022 13:07:44 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C65686351E for ; Mon, 21 Mar 2022 10:06:17 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id w7so25644166lfd.6 for ; Mon, 21 Mar 2022 10:06:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R/7FJJ7qSAHgZRJnHXKO5tZ1Hgqiu2AMH/REX+ZRS18=; b=CcgHOId2RyMEcxGfJARNzZUbdlGCM1utZBV6z2njMf4aotZ5ZdYT92P6HnVd9xeSDn 6SKI9lq8krPDyV7w1W69qTqXWW/ZdAWa6Mrom2kCjhCKYZp8s9hila6IncLMwIkz1Ozv Oq53zzxlEASFXHt6+NFvB+ficHM9zDUPGzfao= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R/7FJJ7qSAHgZRJnHXKO5tZ1Hgqiu2AMH/REX+ZRS18=; b=I3qw1e+QUIx1cpxoypd3HeuUT6+YqHZuc+QhlB5rvmHhm6zFzUyg65ylZkC9In40v2 slIF1e56fVo3oQ8xZHd7TFQifr3/zzYDgU6rcbNiuQ4McGAWqOxUgnxh6EB9KziWgZrT ibM+nL7uKVNw1AuoaXb+1xBi3iBv8ROrqNUhWpz59kWZvZoTOtTA6xqNaTL22mSHUGll CToR4QQl3wwf8Yv2Msx+roMRe6WHb6+e2Zp95LeS3ecFAxP6SHSGWHQQwuTJUPXBnda8 K1m1SJiD5sd/wL1nBNi3hUHaW9YGDYJVtg9xXYHtbdYHBAk4RcQUPTwb/at2S1du0oAj Y94w== X-Gm-Message-State: AOAM532pdwOIK1Le6r0DF3RSocFuWPIAoWDZmYBjM6JquAJAtTeqdStI LVsvbN7/2clbcNAIk4890ltm0NaoLHGfl/u0xqM= X-Google-Smtp-Source: ABdhPJy45LAanSYJqKsvwhtiBlKSB1RWf1bARZlvpLcXJT0Mt/KbNf2/o8t4G8LgQ+ReeneReBnnzQ== X-Received: by 2002:a05:6512:2308:b0:449:f7eb:cc2f with SMTP id o8-20020a056512230800b00449f7ebcc2fmr13842046lfu.37.1647882373051; Mon, 21 Mar 2022 10:06:13 -0700 (PDT) Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com. [209.85.167.49]) by smtp.gmail.com with ESMTPSA id d25-20020a194f19000000b0044a2ad98dcasm395729lfb.167.2022.03.21.10.06.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Mar 2022 10:06:12 -0700 (PDT) Received: by mail-lf1-f49.google.com with SMTP id bu29so25718640lfb.0 for ; Mon, 21 Mar 2022 10:06:11 -0700 (PDT) X-Received: by 2002:a05:6512:b13:b0:448:90c6:dc49 with SMTP id w19-20020a0565120b1300b0044890c6dc49mr15823991lfu.542.1647882371543; Mon, 21 Mar 2022 10:06:11 -0700 (PDT) MIME-Version: 1.0 References: <20220316213055.2351342-1-morbo@google.com> <20220319222228.4160598-1-morbo@google.com> In-Reply-To: From: Linus Torvalds Date: Mon, 21 Mar 2022 10:05:55 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] gpiolib: acpi: use correct format characters To: Andy Shevchenko Cc: Bill Wendling , Mika Westerberg , Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , Nathan Chancellor , Nick Desaulniers , "open list:GPIO SUBSYSTEM" , ACPI Devel Maling List , Linux Kernel Mailing List , llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Mar 21, 2022 at 3:09 AM Andy Shevchenko wrote: > > Would you sign off on this? I will then replace the original patch > with your version. Sure. Note that I (intentionally) do bogus indentation of my inline patches, because that thing wasn't actually _tested_. It's obvious enough and should fix the issue, but I just wanted to point that out. With that said, it's _so_ obviously correct (famous last words) that I'll happily add my sign-off to it: Signed-off-by: Linus Torvalds and I suspect the explanations in the email could probably be used as much of a commit message. > And for the record I have a follow up patch to clearly show that pin > is always unsigned, induced by this discussion. Yeah, that sounds like a good idea - for a compiler it was obvious due to the load from a 'u16' array, but a human would actually have to go and check what that pin_table[] array was to see that "yup, that can't be negative in 'int'". Linus