From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:ACPI COMPONENT ARCHITECTURE (ACPICA)"
<devel@acpica.org>, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
Robert Moore <robert.moore@intel.com>,
Erik Kaneda <erik.kaneda@intel.com>,
Daniel Scally <djrscally@gmail.com>
Subject: Re: [PATCH v1 1/1] ACPI: utils: Document for_each_acpi_dev_match() macro
Date: Mon, 12 Apr 2021 20:50:28 +0300 [thread overview]
Message-ID: <CAHp75Vc3e4FcqKMn3YGGK+sNXLi5UqUL75_GcF-27hyn+iZp9Q@mail.gmail.com> (raw)
In-Reply-To: <CAJZ5v0jJoWnnx7ce82trnzsnBTMEDf1oXwFBDc0RUj-=p7hjLQ@mail.gmail.com>
On Mon, Apr 12, 2021 at 8:27 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Sat, Apr 10, 2021 at 3:29 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> >
> > The macro requires to call acpi_dev_put() on each iteration.
> > Due to this it doesn't tolerate sudden disappearence of the devices.
And should be "disappearance" :-)
> >
> > Document all these nuances to prevent users blindly call it without
> > understanding the possible issues.
> >
> > While at it, add the note to the acpi_dev_get_next_match_dev() and
> > advertise acpi_dev_put() instead of put_device() in the whole family
> > of the helper functions.
Thanks for reviewing this, I'll address all in v2.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-04-12 17:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 13:13 [PATCH v1 1/1] ACPI: utils: Document for_each_acpi_dev_match() macro Andy Shevchenko
2021-04-12 17:27 ` Rafael J. Wysocki
2021-04-12 17:50 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vc3e4FcqKMn3YGGK+sNXLi5UqUL75_GcF-27hyn+iZp9Q@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=devel@acpica.org \
--cc=djrscally@gmail.com \
--cc=erik.kaneda@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).