From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v2 5/5] ACPI: property: Refactor acpi_data_prop_read_single()
Date: Fri, 12 Feb 2021 18:24:28 +0200 [thread overview]
Message-ID: <CAHp75VcvVuZR-dyKZcPW2TwgT8RDT6z78kbdarv79YG_NY=C3Q@mail.gmail.com> (raw)
In-Reply-To: <CAJZ5v0i=YT_pqSC+WJoZYOvA0oM4nwJhnPuD46WjezQGPJGJXw@mail.gmail.com>
On Fri, Feb 12, 2021 at 6:11 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
> On Fri, Feb 12, 2021 at 5:01 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Fri, Feb 12, 2021 at 03:31:24PM +0100, Rafael J. Wysocki wrote:
> > > On Fri, Feb 12, 2021 at 3:14 PM Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
...
> > > > + if (ret)
> > > > + return ret;
> > >
> > > else if (!val)
> > > ret = 1;
> >
> > But then it become a bug again :-)
>
> I'm not sure why? The checks below will still happen and they may
> cause an error to be returned.
Oh, I misinterpreted ret = as plain return. Right. Seems okay.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-02-12 16:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 14:11 [PATCH v2 1/5] ACPI: property: Remove dead code Andy Shevchenko
2021-02-12 14:11 ` [PATCH v2 2/5] ACPI: property: Make acpi_node_prop_read() static Andy Shevchenko
2021-02-12 14:11 ` [PATCH v2 3/5] ACPI: property: Satisfy kernel doc validator (part 1) Andy Shevchenko
2021-02-12 14:11 ` [PATCH v2 4/5] ACPI: property: Satisfy kernel doc validator (part 2) Andy Shevchenko
2021-02-12 14:11 ` [PATCH v2 5/5] ACPI: property: Refactor acpi_data_prop_read_single() Andy Shevchenko
2021-02-12 14:31 ` Rafael J. Wysocki
2021-02-12 16:00 ` Andy Shevchenko
2021-02-12 16:07 ` Rafael J. Wysocki
2021-02-12 16:24 ` Andy Shevchenko [this message]
2021-02-12 14:36 ` [PATCH v2 1/5] ACPI: property: Remove dead code Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VcvVuZR-dyKZcPW2TwgT8RDT6z78kbdarv79YG_NY=C3Q@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).