From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Shiju Jose <shiju.jose@huawei.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"helgaas@kernel.org" <helgaas@kernel.org>,
"bp@alien8.de" <bp@alien8.de>,
"james.morse@arm.com" <james.morse@arm.com>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"robh@kernel.org" <robh@kernel.org>,
"lenb@kernel.org" <lenb@kernel.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
yangyicong <yangyicong@huawei.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
tanxiaofei <tanxiaofei@huawei.com>,
Linuxarm <linuxarm@huawei.com>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [RESEND PATCH v14 2/2] PCI: hip: Add handling of HiSilicon HIP PCIe controller errors
Date: Thu, 3 Sep 2020 14:01:08 +0300 [thread overview]
Message-ID: <CAHp75Vd3wjNHdYC_A1EVV+kzN=6SGqP2qQ0Wb6pdZWWt9qMMLw@mail.gmail.com> (raw)
In-Reply-To: <7f5146dba8ac4ac0a258742551f204fb@huawei.com>
On Thu, Sep 3, 2020 at 1:43 PM Shiju Jose <shiju.jose@huawei.com> wrote:
> >From: Andy Shevchenko [mailto:andriy.shevchenko@linux.intel.com]
> >Sent: 01 September 2020 09:26
> >On Mon, Aug 31, 2020 at 10:26:06PM +0100, Shiju Jose wrote:
> >> From: Yicong Yang <yangyicong@hisilicon.com>
...
> >> +config PCIE_HISI_ERR
> >> + depends on ACPI_APEI_GHES && (ARM64 || COMPILE_TEST)
> >
> >> + depends on ACPI
> >
> >Isn't this implied by
> > drivers/acpi/Kconfig:45:if ACPI
> >?
>
> This can be removed as ACPI_APEI_GHES depends on ACPI.
>
> Do you have any other comments on this patch?
Nope. The rest is fine to me.
> >> + bool "HiSilicon HIP PCIe controller error handling driver"
> >> + help
> >> + Say Y here if you want error handling support
> >> + for the PCIe controller's errors on HiSilicon HIP SoCs
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-09-03 11:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 21:26 [RESEND PATCH v14 0/2] ACPI / APEI: Add support to notify the vendor specific HW errors Shiju Jose
2020-08-31 21:26 ` [RESEND PATCH v14 1/2] ACPI / APEI: Add a notifier chain for unknown (vendor) CPER records Shiju Jose
2020-08-31 21:26 ` [RESEND PATCH v14 2/2] PCI: hip: Add handling of HiSilicon HIP PCIe controller errors Shiju Jose
2020-09-01 8:26 ` Andy Shevchenko
2020-09-03 10:38 ` Shiju Jose
2020-09-03 11:01 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vd3wjNHdYC_A1EVV+kzN=6SGqP2qQ0Wb6pdZWWt9qMMLw@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=dan.carpenter@oracle.com \
--cc=helgaas@kernel.org \
--cc=james.morse@arm.com \
--cc=jonathan.cameron@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=shiju.jose@huawei.com \
--cc=tanxiaofei@huawei.com \
--cc=tony.luck@intel.com \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).