From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Calvin Johnson <calvin.johnson@oss.nxp.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Russell King - ARM Linux admin <linux@armlinux.org.uk>,
linux.cj@gmail.com, Jeremy Linton <jeremy.linton@arm.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Cristi Sovaiala <cristian.sovaiala@nxp.com>,
Florin Laurentiu Chiculita <florinlaurentiu.chiculita@nxp.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Madalin Bucur <madalin.bucur@oss.nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Varun Sethi <V.Sethi@nxp.com>,
"Rajesh V . Bikkina" <rajesh.bikkina@nxp.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Diana Madalina Craciun <diana.craciun@nxp.com>,
netdev <netdev@vger.kernel.org>, Marcin Wojtas <mw@semihalf.com>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>,
Makarand Pawagi <makarand.pawagi@nxp.com>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Pankaj Bansal <pankaj.bansal@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [net-next PATCH v3 5/5] net: mdiobus: Introduce fwnode_mdiobus_register_phy()
Date: Thu, 7 May 2020 12:10:48 +0300 [thread overview]
Message-ID: <CAHp75VeFCzJ97c7AZD8ksA-r3C-XyM24Rt30+Obw6tCaR4xprA@mail.gmail.com> (raw)
In-Reply-To: <20200507074435.GA10296@lsv03152.swis.in-blr01.nxp.com>
On Thu, May 7, 2020 at 10:44 AM Calvin Johnson
<calvin.johnson@oss.nxp.com> wrote:
>
> On Tue, May 05, 2020 at 05:22:00PM +0300, Andy Shevchenko wrote:
> > On Tue, May 5, 2020 at 4:30 PM Calvin Johnson
> > <calvin.johnson@oss.nxp.com> wrote:
...
> > > + bool is_c45 = false;
> >
> > Redundant assignment, see below.
> >
> > > + const char *cp;
> > > + u32 phy_id;
> > > + int rc;
> > > + fwnode_property_read_string(child, "compatible", &cp);
> >
> > Consider rc = ...; otherwise you will have UB below.
> >
> > > + if (!strcmp(cp, "ethernet-phy-ieee802.3-c45"))
> >
> > UB!
>
> Thanks for the comments! I've considered all of them.
> What is UB, by the way? :)-
Undefined Behaviour.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-05-07 9:11 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 13:29 [net-next PATCH v3 0/5] Introduce new fwnode based APIs to support phylink and phy layers Calvin Johnson
2020-05-05 13:29 ` [net-next PATCH v3 1/5] net: phy: Introduce phy related fwnode functions Calvin Johnson
2020-05-05 14:44 ` Russell King - ARM Linux admin
2020-05-05 23:21 ` kbuild test robot
2020-05-05 23:39 ` Russell King - ARM Linux admin
2020-05-06 0:07 ` kbuild test robot
2020-05-05 13:29 ` [net-next PATCH v3 2/5] net: phy: alphabetically sort header includes Calvin Johnson
2020-05-05 13:29 ` [net-next PATCH v3 3/5] phylink: Introduce phylink_fwnode_phy_connect() Calvin Johnson
2020-05-05 14:13 ` Andy Shevchenko
2020-05-05 14:35 ` Russell King - ARM Linux admin
2020-05-05 13:29 ` [net-next PATCH v3 4/5] net: phy: Introduce fwnode_get_phy_id() Calvin Johnson
2020-05-05 14:15 ` Andy Shevchenko
2020-05-05 14:20 ` Russell King - ARM Linux admin
2020-05-07 13:26 ` Jeremy Linton
2020-05-07 17:27 ` Andy Shevchenko
2020-05-07 19:54 ` Jeremy Linton
2020-05-08 16:07 ` Calvin Johnson
2020-05-08 18:13 ` Andrew Lunn
2020-05-08 19:18 ` Jeremy Linton
2020-05-08 20:27 ` Andrew Lunn
2020-05-08 22:48 ` Jeremy Linton
2020-05-08 23:42 ` Andrew Lunn
2020-05-09 0:11 ` Jeremy Linton
2020-05-11 8:00 ` Calvin Johnson
2020-05-11 9:38 ` Russell King - ARM Linux admin
2020-05-11 10:29 ` Calvin Johnson
2020-05-11 10:48 ` Russell King - ARM Linux admin
2020-05-11 12:02 ` Calvin Johnson
2020-05-11 13:04 ` Andrew Lunn
2020-05-11 13:35 ` Russell King - ARM Linux admin
2020-05-11 14:59 ` Calvin Johnson
2020-05-11 7:39 ` Calvin Johnson
2020-05-11 5:52 ` Calvin Johnson
2020-05-11 12:53 ` Andrew Lunn
2020-05-05 13:29 ` [net-next PATCH v3 5/5] net: mdiobus: Introduce fwnode_mdiobus_register_phy() Calvin Johnson
2020-05-05 14:22 ` Andy Shevchenko
2020-05-07 7:44 ` Calvin Johnson
2020-05-07 9:10 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VeFCzJ97c7AZD8ksA-r3C-XyM24Rt30+Obw6tCaR4xprA@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=V.Sethi@nxp.com \
--cc=andrew@lunn.ch \
--cc=calvin.johnson@oss.nxp.com \
--cc=cristian.sovaiala@nxp.com \
--cc=davem@davemloft.net \
--cc=diana.craciun@nxp.com \
--cc=f.fainelli@gmail.com \
--cc=florinlaurentiu.chiculita@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=jeremy.linton@arm.com \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.cj@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=madalin.bucur@oss.nxp.com \
--cc=makarand.pawagi@nxp.com \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=pankaj.bansal@nxp.com \
--cc=rafael@kernel.org \
--cc=rajesh.bikkina@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).