From: Alex Hung <alex.hung@canonical.com> To: Karol Herbst <kherbst@redhat.com> Cc: LKML <linux-kernel@vger.kernel.org>, Linux ACPI Mailing List <linux-acpi@vger.kernel.org>, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>, Dave Airlie <airlied@redhat.com>, Lyude Paul <lyude@redhat.com>, Ben Skeggs <bskeggs@redhat.com> Subject: Re: [PATCH 3/7] Revert "ACPI / OSI: Add OEM _OSI strings to disable NVidia RTD3" Date: Wed, 14 Aug 2019 17:34:49 -0600 Message-ID: <CAJ=jquaVcWisQ3Qw-_GMktcOq4zqFmeYXztfwNAVKZJO=_+yLA@mail.gmail.com> (raw) In-Reply-To: <20190814213118.28473-4-kherbst@redhat.com> On Wed, Aug 14, 2019 at 3:31 PM Karol Herbst <kherbst@redhat.com> wrote: > > This reverts commit 9251a71db62ca9cc7e7cf364218610b0f018c291. > > This was never discussed with anybody Nouveau related and we would have NACKed > this change immediately. > > We have a better workaround, which makes it actually work with Nouveau. No idea > why the comment mentions the Nvidia driver and assumes it gives any weight to > the reasoning.... we don't care about out of tree drivers. > > Nouveau does support RTD3, but we had some issues with that. And we even have > a better fix for this issue. Also, can we _please_ do it in a way worthy of an > upstream community the next time? > > If some distribution feels like they have to please companies not wanting to > be part of the linux community, please do so downstream and don't try to push > something like this upstream. Hi Karol, A lot of appreciation for your hard-work on this issue, but unfriendly comments aren't necessary. At the time this was discussed with hardware vendors and platform vendors and it worked for many systems and benefit for many people buying these platforms. Last but not least, I do appreciate better fixes and want to retire the hacks too. I am going to notify hardware owners to test these patches on the original intended systems, and will report whether there are regressions. > > Signed-off-by: Karol Herbst <kherbst@redhat.com> > CC: Alex Hung <alex.hung@canonical.com> > CC: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > CC: Dave Airlie <airlied@redhat.com> > CC: Lyude Paul <lyude@redhat.com> > CC: Ben Skeggs <bskeggs@redhat.com> > --- > drivers/acpi/osi.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/drivers/acpi/osi.c b/drivers/acpi/osi.c > index 56cc95b6b724..f5d559a2ff14 100644 > --- a/drivers/acpi/osi.c > +++ b/drivers/acpi/osi.c > @@ -44,15 +44,6 @@ osi_setup_entries[OSI_STRING_ENTRIES_MAX] __initdata = { > {"Processor Device", true}, > {"3.0 _SCP Extensions", true}, > {"Processor Aggregator Device", true}, > - /* > - * Linux-Dell-Video is used by BIOS to disable RTD3 for NVidia graphics > - * cards as RTD3 is not supported by drivers now. Systems with NVidia > - * cards will hang without RTD3 disabled. > - * > - * Once NVidia drivers officially support RTD3, this _OSI strings can > - * be removed if both new and old graphics cards are supported. > - */ > - {"Linux-Dell-Video", true}, > }; > > static u32 acpi_osi_handler(acpi_string interface, u32 supported) > -- > 2.21.0 > -- Cheers, Alex Hung
next prev parent reply index Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-14 21:31 [PATCH 0/7] Adding a proper workaround for fixing RTD3 issues with Nouveau Karol Herbst 2019-08-14 21:31 ` [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output" Karol Herbst 2019-08-14 21:49 ` Alex Hung 2019-08-14 22:47 ` [Nouveau] " Dave Airlie 2019-08-15 13:55 ` Mario.Limonciello 2019-08-15 14:04 ` Karol Herbst 2019-08-15 14:13 ` Alex Deucher 2019-08-15 14:15 ` Karol Herbst 2019-08-15 14:17 ` Alex Deucher 2019-08-15 14:23 ` Mario.Limonciello 2019-08-15 14:35 ` Karol Herbst 2019-08-15 14:41 ` Alex Deucher 2019-08-15 14:19 ` Mario.Limonciello 2019-08-15 14:25 ` Karol Herbst 2019-08-15 14:34 ` Mario.Limonciello 2019-08-15 14:36 ` Karol Herbst 2019-08-15 14:37 ` Alex Deucher 2019-08-15 14:56 ` Takashi Iwai 2019-08-15 16:19 ` Mario.Limonciello 2019-08-15 17:43 ` Takashi Iwai 2019-08-15 18:34 ` Alex Deucher 2019-08-15 14:59 ` Alex Deucher 2019-08-15 14:11 ` Daniel Vetter 2019-08-19 9:52 ` Rafael J. Wysocki 2019-09-05 15:51 ` Karol Herbst 2019-09-05 16:26 ` Rafael J. Wysocki 2019-09-09 21:07 ` Alex Hung 2019-10-21 2:14 ` Alex Hung 2019-10-21 8:14 ` Rafael J. Wysocki 2019-10-21 8:48 ` Karol Herbst 2019-10-21 8:54 ` Rafael J. Wysocki 2019-09-05 16:35 ` Alex Deucher 2019-08-14 21:31 ` [PATCH 2/7] Revert "ACPI / OSI: Add OEM _OSI string to enable NVidia HDMI audio" Karol Herbst 2020-12-10 17:59 ` Lyude Paul 2019-08-14 21:31 ` [PATCH 3/7] Revert "ACPI / OSI: Add OEM _OSI strings to disable NVidia RTD3" Karol Herbst 2019-08-14 23:34 ` Alex Hung [this message] 2019-08-15 4:44 ` Karol Herbst 2019-08-14 21:31 ` [PATCH 4/7] drm/nouveau/pci: enable pcie link changes for pascal Karol Herbst 2019-08-14 21:31 ` [PATCH 5/7] drm/nouveau/pci: add nvkm_pcie_get_speed Karol Herbst 2019-08-14 21:31 ` [PATCH 6/7] drm/nouveau/pci: save the boot pcie link speed and restore it on fini Karol Herbst 2019-08-14 21:31 ` [PATCH 7/7] drm/nouveau: abort runtime suspend if we hit an error Karol Herbst
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAJ=jquaVcWisQ3Qw-_GMktcOq4zqFmeYXztfwNAVKZJO=_+yLA@mail.gmail.com' \ --to=alex.hung@canonical.com \ --cc=airlied@redhat.com \ --cc=bskeggs@redhat.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=kherbst@redhat.com \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lyude@redhat.com \ --cc=nouveau@lists.freedesktop.org \ --cc=rafael.j.wysocki@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-ACPI Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-acpi/0 linux-acpi/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-acpi linux-acpi/ https://lore.kernel.org/linux-acpi \ linux-acpi@vger.kernel.org public-inbox-index linux-acpi Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-acpi AGPL code for this site: git clone https://public-inbox.org/public-inbox.git