From: Alex Hung <alex.hung@canonical.com>
To: Karol Herbst <kherbst@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux ACPI Mailing List <linux-acpi@vger.kernel.org>,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Dave Airlie <airlied@redhat.com>, Lyude Paul <lyude@redhat.com>,
Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"
Date: Wed, 14 Aug 2019 15:49:32 -0600
Message-ID: <CAJ=jquaoA+_WmTJtcGq4b0A_Sb=Aw_3_TsUR-8nxJ+rJTdoFPA@mail.gmail.com> (raw)
In-Reply-To: <20190814213118.28473-2-kherbst@redhat.com>
Thanks for the series of fixes. I will check whether these fixes work
on the original intended systems.
On Wed, Aug 14, 2019 at 3:31 PM Karol Herbst <kherbst@redhat.com> wrote:
>
> This reverts commit 28586a51eea666d5531bcaef2f68e4abbd87242c.
>
> The original commit message didn't even make sense. AMD _does_ support it and
> it works with Nouveau as well.
>
> Also what was the issue being solved here? No references to any bugs and not
> even explaining any issue at all isn't the way we do things.
>
> And even if it means a muxed design, then the fix is to make it work inside the
> driver, not adding some hacky workaround through ACPI tricks.
>
> And what out of tree drivers do or do not support we don't care one bit anyway.
>
> Signed-off-by: Karol Herbst <kherbst@redhat.com>
> CC: Alex Hung <alex.hung@canonical.com>
> CC: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> CC: Dave Airlie <airlied@redhat.com>
> CC: Lyude Paul <lyude@redhat.com>
> CC: Ben Skeggs <bskeggs@redhat.com>
> ---
> drivers/acpi/osi.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/acpi/osi.c b/drivers/acpi/osi.c
> index bec0bebc7f52..9b20ac4d79a0 100644
> --- a/drivers/acpi/osi.c
> +++ b/drivers/acpi/osi.c
> @@ -61,13 +61,6 @@ osi_setup_entries[OSI_STRING_ENTRIES_MAX] __initdata = {
> * a BIOS workaround.
> */
> {"Linux-Lenovo-NV-HDMI-Audio", true},
> - /*
> - * Linux-HPI-Hybrid-Graphics is used by BIOS to enable dGPU to
> - * output video directly to external monitors on HP Inc. mobile
> - * workstations as Nvidia and AMD VGA drivers provide limited
> - * hybrid graphics supports.
> - */
> - {"Linux-HPI-Hybrid-Graphics", true},
> };
>
> static u32 acpi_osi_handler(acpi_string interface, u32 supported)
> --
> 2.21.0
>
--
Cheers,
Alex Hung
next prev parent reply index
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 21:31 [PATCH 0/7] Adding a proper workaround for fixing RTD3 issues with Nouveau Karol Herbst
2019-08-14 21:31 ` [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output" Karol Herbst
2019-08-14 21:49 ` Alex Hung [this message]
2019-08-14 22:47 ` [Nouveau] " Dave Airlie
2019-08-15 13:55 ` Mario.Limonciello
2019-08-15 14:04 ` Karol Herbst
2019-08-15 14:13 ` Alex Deucher
2019-08-15 14:15 ` Karol Herbst
2019-08-15 14:17 ` Alex Deucher
2019-08-15 14:23 ` Mario.Limonciello
2019-08-15 14:35 ` Karol Herbst
2019-08-15 14:41 ` Alex Deucher
2019-08-15 14:19 ` Mario.Limonciello
2019-08-15 14:25 ` Karol Herbst
2019-08-15 14:34 ` Mario.Limonciello
2019-08-15 14:36 ` Karol Herbst
2019-08-15 14:37 ` Alex Deucher
2019-08-15 14:56 ` Takashi Iwai
2019-08-15 16:19 ` Mario.Limonciello
2019-08-15 17:43 ` Takashi Iwai
2019-08-15 18:34 ` Alex Deucher
2019-08-15 14:59 ` Alex Deucher
2019-08-15 14:11 ` Daniel Vetter
2019-08-19 9:52 ` Rafael J. Wysocki
2019-09-05 15:51 ` Karol Herbst
2019-09-05 16:26 ` Rafael J. Wysocki
2019-09-09 21:07 ` Alex Hung
2019-10-21 2:14 ` Alex Hung
2019-10-21 8:14 ` Rafael J. Wysocki
2019-10-21 8:48 ` Karol Herbst
2019-10-21 8:54 ` Rafael J. Wysocki
2019-09-05 16:35 ` Alex Deucher
2019-08-14 21:31 ` [PATCH 2/7] Revert "ACPI / OSI: Add OEM _OSI string to enable NVidia HDMI audio" Karol Herbst
2020-12-10 17:59 ` Lyude Paul
2019-08-14 21:31 ` [PATCH 3/7] Revert "ACPI / OSI: Add OEM _OSI strings to disable NVidia RTD3" Karol Herbst
2019-08-14 23:34 ` Alex Hung
2019-08-15 4:44 ` Karol Herbst
2019-08-14 21:31 ` [PATCH 4/7] drm/nouveau/pci: enable pcie link changes for pascal Karol Herbst
2019-08-14 21:31 ` [PATCH 5/7] drm/nouveau/pci: add nvkm_pcie_get_speed Karol Herbst
2019-08-14 21:31 ` [PATCH 6/7] drm/nouveau/pci: save the boot pcie link speed and restore it on fini Karol Herbst
2019-08-14 21:31 ` [PATCH 7/7] drm/nouveau: abort runtime suspend if we hit an error Karol Herbst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ=jquaoA+_WmTJtcGq4b0A_Sb=Aw_3_TsUR-8nxJ+rJTdoFPA@mail.gmail.com' \
--to=alex.hung@canonical.com \
--cc=airlied@redhat.com \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kherbst@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux-ACPI Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/linux-acpi/0 linux-acpi/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-acpi linux-acpi/ https://lore.kernel.org/linux-acpi \
linux-acpi@vger.kernel.org
public-inbox-index linux-acpi
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-acpi
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git