Linux-ACPI Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] ACPI: processor: remove unnecessary string  _UID comments
@ 2020-10-14  1:03 Alex Hung
  2020-10-16 16:14 ` Rafael J. Wysocki
  0 siblings, 1 reply; 2+ messages in thread
From: Alex Hung @ 2020-10-14  1:03 UTC (permalink / raw)
  To: rjw, lenb, linux-acpi, alex.hung

ACPI 6.3 Errata A no longer allows _UID to be string except Itanium
for historical reasons as stated in section 5.2.12. Therefore, it is
redundant to comment "we don't handle string _UIDs yet" which implies a
feature is missing.

"From ACPI Specification 6.3 onward, all processor objects for all
architectures except Itanium must now use Device() objects with an _HID
of ACPI0007, and use only integer _UID values."

Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 drivers/acpi/acpi_processor.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c
index b51ddf3..710605f 100644
--- a/drivers/acpi/acpi_processor.c
+++ b/drivers/acpi/acpi_processor.c
@@ -264,7 +264,6 @@ static int acpi_processor_get_info(struct acpi_device *device)
 	} else {
 		/*
 		 * Declared with "Device" statement; match _UID.
-		 * Note that we don't handle string _UIDs yet.
 		 */
 		status = acpi_evaluate_integer(pr->handle, METHOD_NAME__UID,
 						NULL, &value);
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ACPI: processor: remove unnecessary string _UID comments
  2020-10-14  1:03 [PATCH] ACPI: processor: remove unnecessary string _UID comments Alex Hung
@ 2020-10-16 16:14 ` Rafael J. Wysocki
  0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2020-10-16 16:14 UTC (permalink / raw)
  To: Alex Hung; +Cc: Rafael J. Wysocki, Len Brown, ACPI Devel Maling List

On Wed, Oct 14, 2020 at 3:03 AM Alex Hung <alex.hung@canonical.com> wrote:
>
> ACPI 6.3 Errata A no longer allows _UID to be string except Itanium
> for historical reasons as stated in section 5.2.12. Therefore, it is
> redundant to comment "we don't handle string _UIDs yet" which implies a
> feature is missing.
>
> "From ACPI Specification 6.3 onward, all processor objects for all
> architectures except Itanium must now use Device() objects with an _HID
> of ACPI0007, and use only integer _UID values."
>
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  drivers/acpi/acpi_processor.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c
> index b51ddf3..710605f 100644
> --- a/drivers/acpi/acpi_processor.c
> +++ b/drivers/acpi/acpi_processor.c
> @@ -264,7 +264,6 @@ static int acpi_processor_get_info(struct acpi_device *device)
>         } else {
>                 /*
>                  * Declared with "Device" statement; match _UID.
> -                * Note that we don't handle string _UIDs yet.
>                  */
>                 status = acpi_evaluate_integer(pr->handle, METHOD_NAME__UID,
>                                                 NULL, &value);
> --

Applied as 5.10-rc material with edited changelog and subject, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-14  1:03 [PATCH] ACPI: processor: remove unnecessary string _UID comments Alex Hung
2020-10-16 16:14 ` Rafael J. Wysocki

Linux-ACPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-acpi/0 linux-acpi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-acpi linux-acpi/ https://lore.kernel.org/linux-acpi \
		linux-acpi@vger.kernel.org
	public-inbox-index linux-acpi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-acpi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git