From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 946C3C3F2D2 for ; Mon, 2 Mar 2020 10:38:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 637E8217F4 for ; Mon, 2 Mar 2020 10:38:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583145525; bh=0mvRf+SAaOE7Usyf6yLvIyPFGpMahiDu5R9HVRI5Mcg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=rHLn9w0yQ9kpa2gb58CJAgdi+TDdV75nbTlBosEmS3qDMC3/QpOimDyb3chxKf/gp Ol8Upj83MUjsZP92jtFFhERtwOakuI6W/1F0vvH2D42Cy/Q+IvkXIE8OFVWkqk0axy 2SQqmOK0QKCeJa97mniZ99L5pHDjDIbQaN8YGKCY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727511AbgCBKip convert rfc822-to-8bit (ORCPT ); Mon, 2 Mar 2020 05:38:45 -0500 Received: from mail-ot1-f67.google.com ([209.85.210.67]:45611 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727365AbgCBKio (ORCPT ); Mon, 2 Mar 2020 05:38:44 -0500 Received: by mail-ot1-f67.google.com with SMTP id f21so629100otp.12; Mon, 02 Mar 2020 02:38:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MwWsoH3lbguISoV3Xmb+APpQTE7w8muFrbuI4gr/DUc=; b=MNRvfqPYfSDoi1ID6LgQ+c6vyDPkEN/TJuw6KfXrPs3mhLVoUzMsqMHKRNny9VxCXw eBY+PfOwIpiQ0hy7NvuMlmDtMZv7f+Y51JAJfEPaFfHzGaavhxSA4B4jPfY0Y6ZoWyRC ekKj5ZNiHsaY+0vHyn9ZPOIB/phtHj8Il83/5PQMLfOOa9lTPXVktQeX0Sw9koIvY7FX UO49livVATS0eHT1ysX7YQmRpIf07k4ILGh4TUueWrUcB7TpMCZsVzrfERboSXjf/IYn MDiRrVpvFLHbj8F0OnyyiqswoPZONzmmifXfU9Jqbi1yeVMnePEevGK2ajbkzyOXnXmr F/9Q== X-Gm-Message-State: APjAAAVsz4U3CDzQgz/6ow5x2I4MztOBiIgQRTNhBYEry6oAX00U8oyJ JPCphGTKyv4apdoL0JQs78BJrqVgjHk2zAY5wXhX2j3i X-Google-Smtp-Source: APXvYqwuqeK4Mzm3RU2tsEbKB/ADLbtbRGkvKRUCWJZj2FRf77xO4xC3hxyCGIR8gyg4OX3X8h7AqaxfpZbfqbHhNew= X-Received: by 2002:a9d:67d7:: with SMTP id c23mr12866890otn.262.1583145524239; Mon, 02 Mar 2020 02:38:44 -0800 (PST) MIME-Version: 1.0 References: <2094703.CetWLLyMuz@kreacher> In-Reply-To: From: "Rafael J. Wysocki" Date: Mon, 2 Mar 2020 11:38:32 +0100 Message-ID: Subject: Re: [PATCH 0/6] ACPI: EC: Updates related to initialization To: Jian-Hong Pan Cc: "Rafael J. Wysocki" , Daniel Drake , Linux ACPI , LKML , "Rafael J. Wysocki" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Mar 2, 2020 at 6:54 AM Jian-Hong Pan wrote: > > Daniel Drake 於 2020年2月28日 週五 下午5:43寫道： > > > > On Thu, Feb 27, 2020 at 10:25 PM Rafael J. Wysocki wrote: > > > The purpose of this series of update of the ACPI EC driver is to make its > > > initialization more straightforward. > > > > > > They fix a couple of issues, clean up some things, remove redundant code etc. > > > > > > Please refer to the changelogs of individual patches for details. > > > > > > For easier access, the series is available in the git branch at > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ > > > acpi-ec-work > > > > > > on top of 5.6-rc3. > > > > Jian-Hong, can you please test this on Asus UX434DA? > > Check if the screen brightness hotkeys are still working after these changes. > > Hi Rafael, > > Thanks for your patches, but we found an issue: > The laptops like ASUS UX434DA's screen brightness hotkeys work before > this patch series. However, the hotkeys are failed with the patch > "ACPI: EC: Unify handling of event handler installation failures". So I have modified the series to avoid the change that can possibly break this. Can you please pull the new series from git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ acpi-ec-work (same branch) and retest? I'll post the updated patches later this week, but it would be good to try them on now if possible. Thanks!