From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Daniel Scally <djrscally@gmail.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Mark Gross <markgross@kernel.org>,
Robert Moore <robert.moore@intel.com>
Subject: Re: [PATCH v3 0/5] Add multiple-consumer support to int3472-tps68470 driver
Date: Sat, 24 Sep 2022 19:15:49 +0200 [thread overview]
Message-ID: <CAJZ5v0gB=jztBtmcfmuXNiNd2s+ftQRF1fqYHQApFsX_yEvkMQ@mail.gmail.com> (raw)
In-Reply-To: <b3855fe0-4b85-a442-1835-3e62456b3206@redhat.com>
On Thu, Sep 22, 2022 at 10:55 AM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi All,
>
> On 9/22/22 01:04, Daniel Scally wrote:
> > Hello all
> >
> > At the moment there are a few places in the int3472-tps68470 driver that are
> > limited to just working with a single consuming device dependent on the PMIC.
> > There are systems where multiple camera sensors share a single TPS68470, so
> > we need to extend the driver to support them. This requires a couple of tweaks
> > to the ACPI functions to fetch dependent devices, which also assumes that only
> > a single dependent will be found.
> >
> > The v2 for this series was some time ago...it's kept falling to the back of my
> > to-do list so I've only just gotten round to it; sorry about that. v2 here:
> >
> > https://lore.kernel.org/linux-acpi/20220327161344.50477-1-djrscally@gmail.com/
>
> Rafael, I would like to merge this through the pdx86 tree may I have your
> ack for patches 1 + 2 for this. As a reminder (since it has been a while)
> here are your review remarks to v2 of patch 1:
>
> https://lore.kernel.org/platform-driver-x86/CAJZ5v0i2ciLHP-=8eQcZc0v0xCzhKHKpxLC=Kgv6W5E_5=HQJA@mail.gmail.com/
>
> (which both seem to have been addressed)
>
> AFAICT you did not have any remarks for v2 of patch 2.
No, I didn't.
However, because acpi_bus_get_acpi_device() becomes
acpi_get_acpi_dev() in my tree, I think it's better to route this
material through it, if that's not a problem.
I've tentatively queued it up for 6.1.
Thanks!
> p.s.
>
> Dan, if I want to give the IR cam a test run on my own Surface Go (version 1)
> I guess I may need a sensor driver? Where can I find that sensor driver and
> what do I need in userspace to test this ?
>
>
>
> > Daniel Scally (5):
> > ACPI: scan: Add acpi_dev_get_next_consumer_dev()
> > ACPI: bus: Add iterator for dependent devices
> > platform/x86: int3472: Support multiple clock consumers
> > platform/x86: int3472: Support multiple gpio lookups in board data
> > platform/x86: int3472: Add board data for Surface Go2 IR camera
> >
> > drivers/acpi/scan.c | 40 +++++++---
> > drivers/clk/clk-tps68470.c | 13 +++-
> > drivers/platform/x86/intel/int3472/common.c | 2 +-
> > drivers/platform/x86/intel/int3472/tps68470.c | 76 ++++++++++++++++---
> > drivers/platform/x86/intel/int3472/tps68470.h | 3 +-
> > .../x86/intel/int3472/tps68470_board_data.c | 54 ++++++++++++-
> > include/acpi/acpi_bus.h | 15 +++-
> > include/linux/platform_data/tps68470.h | 7 +-
> > 8 files changed, 177 insertions(+), 33 deletions(-)
> >
>
next prev parent reply other threads:[~2022-09-24 17:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 23:04 [PATCH v3 0/5] Add multiple-consumer support to int3472-tps68470 driver Daniel Scally
2022-09-21 23:04 ` [PATCH v3 1/5] ACPI: scan: Add acpi_dev_get_next_consumer_dev() Daniel Scally
2022-09-21 23:04 ` [PATCH v3 2/5] ACPI: bus: Add iterator for dependent devices Daniel Scally
2022-09-21 23:04 ` [PATCH v3 3/5] platform/x86: int3472: Support multiple clock consumers Daniel Scally
2022-09-22 8:49 ` Hans de Goede
2022-09-27 12:47 ` Andy Shevchenko
2022-09-27 12:48 ` Andy Shevchenko
2022-09-21 23:04 ` [PATCH v3 4/5] platform/x86: int3472: Support multiple gpio lookups in board data Daniel Scally
2022-09-21 23:04 ` [PATCH v3 5/5] platform/x86: int3472: Add board data for Surface Go2 IR camera Daniel Scally
2022-09-22 8:55 ` [PATCH v3 0/5] Add multiple-consumer support to int3472-tps68470 driver Hans de Goede
2022-09-22 9:07 ` Daniel Scally
2022-09-24 17:15 ` Rafael J. Wysocki [this message]
2022-09-25 9:23 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0gB=jztBtmcfmuXNiNd2s+ftQRF1fqYHQApFsX_yEvkMQ@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=djrscally@gmail.com \
--cc=hdegoede@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=mturquette@baylibre.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robert.moore@intel.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).