From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87081C433F5 for ; Tue, 21 Sep 2021 13:08:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 719AD60E08 for ; Tue, 21 Sep 2021 13:08:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232727AbhIUNKT (ORCPT ); Tue, 21 Sep 2021 09:10:19 -0400 Received: from mail-ot1-f46.google.com ([209.85.210.46]:41850 "EHLO mail-ot1-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232344AbhIUNKT (ORCPT ); Tue, 21 Sep 2021 09:10:19 -0400 Received: by mail-ot1-f46.google.com with SMTP id 97-20020a9d006a000000b00545420bff9eso21257129ota.8; Tue, 21 Sep 2021 06:08:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VxkNFPBC461YfQgocr3vAKBRyMLGM7PbdciNNlGgvoQ=; b=nFvHGDNpcqFpsyJAOrgxxvq6rceJ+26Cc6Ft3SSdQ43ORVFz+ycalqF4aDohX5y1UO kS/mRKxCRVy2X4AeTh51L1qPDlQ7nPbBxCZvyQfX09bWgcYt35xjNbRxZ/0HaeEDJWQ1 7HTEzpmL+udikZnKIhBgZ7ITGOmTE6XpP4CM4RKKyuVfAbOpP36IVGuOWKxOr+IT3VZv FldVKgPpSj0W7SlN1Gpq0/mzwvii07KCVdt6cPfQ+f4JPw6goTR7erRh30cofb3UvBYV KaX60/zCvlxqKgjibJkoN2y0W9NB4UnLFlh4BvaxFi4wlrsPOCR2JD1xz36VxvylMIbF BOvg== X-Gm-Message-State: AOAM533cF1IODpgV9xcpdP+Uskvo9hMBbyc31ycJkK5SvyLTZpKKGfc2 hB/+9PBZmnkAeASzY1UI1grkhcxpTWaqnovHXG/+LhIv X-Google-Smtp-Source: ABdhPJy2lq2k9wr64rRinyx/OmSeoNOiP1icCASohpi+LrzO1geQDEpVRb3a/EXOsGBfCNvC1YkFnAxRrSc5LuaIDgo= X-Received: by 2002:a9d:4d93:: with SMTP id u19mr25968827otk.86.1632229730204; Tue, 21 Sep 2021 06:08:50 -0700 (PDT) MIME-Version: 1.0 References: <20210916170054.136790-1-krzysztof.kozlowski@canonical.com> <20210916170054.136790-2-krzysztof.kozlowski@canonical.com> In-Reply-To: From: "Rafael J. Wysocki" Date: Tue, 21 Sep 2021 15:08:39 +0200 Message-ID: Subject: Re: [PATCH 2/2] acpi: pnp: remove duplicated BRI0A49 and BDP3336 entries To: Hans de Goede Cc: Krzysztof Kozlowski , "Rafael J. Wysocki" , Len Brown , Matan Ziv-Av , Mark Gross , ACPI Devel Maling List , Linux Kernel Mailing List , Platform Driver Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Sep 21, 2021 at 2:52 PM Hans de Goede wrote: > > Hi, > > On 9/16/21 7:00 PM, Krzysztof Kozlowski wrote: > > BRI0A49 and BDP3336 are already on the list. > > > > Signed-off-by: Krzysztof Kozlowski > > Thanks, patch looks good to me: > > Reviewed-by: Hans de Goede > > Rafael, I've picked up 1/2 since that applies to a drivers/platform/x86 > driver. I'll leave picking this one up to you. I'll pick it up, thanks! > > --- > > drivers/acpi/acpi_pnp.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/acpi/acpi_pnp.c b/drivers/acpi/acpi_pnp.c > > index 8f2dc176bb41..ffdcfcd4a10d 100644 > > --- a/drivers/acpi/acpi_pnp.c > > +++ b/drivers/acpi/acpi_pnp.c > > @@ -156,8 +156,6 @@ static const struct acpi_device_id acpi_pnp_device_ids[] = { > > {"BRI0A49"}, /* Boca Complete Ofc Communicator 14.4 Data-FAX */ > > {"BRI1400"}, /* Boca Research 33,600 ACF Modem */ > > {"BRI3400"}, /* Boca 33.6 Kbps Internal FD34FSVD */ > > - {"BRI0A49"}, /* Boca 33.6 Kbps Internal FD34FSVD */ > > - {"BDP3336"}, /* Best Data Products Inc. Smart One 336F PnP Modem */ > > {"CPI4050"}, /* Computer Peripherals Inc. EuroViVa CommCenter-33.6 SP PnP */ > > {"CTL3001"}, /* Creative Labs Phone Blaster 28.8 DSVD PnP Voice */ > > {"CTL3011"}, /* Creative Labs Modem Blaster 28.8 DSVD PnP Voice */ > > >