From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1433EC433EF for ; Thu, 23 Sep 2021 18:42:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EEB3561214 for ; Thu, 23 Sep 2021 18:42:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242626AbhIWSoE (ORCPT ); Thu, 23 Sep 2021 14:44:04 -0400 Received: from mail-ot1-f44.google.com ([209.85.210.44]:44947 "EHLO mail-ot1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242708AbhIWSoD (ORCPT ); Thu, 23 Sep 2021 14:44:03 -0400 Received: by mail-ot1-f44.google.com with SMTP id h9-20020a9d2f09000000b005453f95356cso9761059otb.11; Thu, 23 Sep 2021 11:42:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A1nz/2r9dfa/43uvC8GU09aHy0M9gShwuzvCZZpWMOk=; b=u6Z5l3LOmwcsWooXQF/uIJCT6/Ztv9sqPbDypgRAe5RdoSeca8AgRhvll/f2mEGDM7 0hlTSAq/x+JZuUzvaPnfB8oyocOcvn5RsvgGi72e86IJl330qwPQX/LEfu3jBp+K34yg 1aprIM1bbkR6ettAW9T3M8+Mim/J0RQhB1fynA9+So3fp/2/kottzZZnMUnGweZfTG7Q 4KWj6Tkhe6sd0lQDhOprEzk3xC1dYzRL3stnlP5TUq4jUduhnfPRo66iTDGKIAFojYK9 nnehi7kOxDERi60j/borhtxQk4t0nu1p8FQmN2x+5+VzEYnaY6hf4+psj5sUdvnIb+HB w3GQ== X-Gm-Message-State: AOAM5304Yhel3vba6w1XJ0/1N96t/c+CdLNDIg0LpvPK3zACV+nOAtJ8 tBo5LjcmNun8Bix0j+ygOI2YQFb7YG2OaWBzaWw= X-Google-Smtp-Source: ABdhPJxcIsNvYPw/kdbWbAQe8WU2n06LO+xqz2p6civsh9f6C/8ERt38zFkXrN6Pstjl8b3+GXKNFEzBj2/XmER58ug= X-Received: by 2002:a05:6830:82b:: with SMTP id t11mr134299ots.319.1632422551641; Thu, 23 Sep 2021 11:42:31 -0700 (PDT) MIME-Version: 1.0 References: <20210923033557.19100-1-justin.he@arm.com> <20210923091644.GA5882@lpieralisi> In-Reply-To: <20210923091644.GA5882@lpieralisi> From: "Rafael J. Wysocki" Date: Thu, 23 Sep 2021 20:42:20 +0200 Message-ID: Subject: Re: [PATCH v3] Revert "ACPI: Add memory semantics to acpi_os_map_memory()" To: Lorenzo Pieralisi , Jia He Cc: Catalin Marinas , Will Deacon , "Rafael J. Wysocki" , Ard Biesheuvel , Len Brown , Robert Moore , Erik Kaneda , Linux ARM , Linux Kernel Mailing List , ACPI Devel Maling List , "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" , Jeremy Linton , Hanjun Guo , "Rafael J . Wysocki" , Harb Abdulhamid Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Sep 23, 2021 at 11:16 AM Lorenzo Pieralisi wrote: > > On Thu, Sep 23, 2021 at 11:35:57AM +0800, Jia He wrote: > > This reverts commit 437b38c51162f8b87beb28a833c4d5dc85fa864e. > > > > The memory semantics added in commit 437b38c51162 causes SystemMemory > > Operation region, whose address range is not described in the EFI memory > > map to be mapped as NormalNC memory on arm64 platforms (through > > acpi_os_map_memory() in acpi_ex_system_memory_space_handler()). > > > > This triggers the following abort on an ARM64 Ampere eMAG machine, > > because presumably the physical address range area backing the Opregion > > does not support NormalNC memory attributes driven on the bus. > > > > Internal error: synchronous external abort: 96000410 [#1] SMP > > Modules linked in: > > CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.14.0+ #462 > > Hardware name: MiTAC RAPTOR EV-883832-X3-0001/RAPTOR, BIOS 0.14 02/22/2019 > > pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) > > [...snip...] > > Call trace: > > acpi_ex_system_memory_space_handler+0x26c/0x2c8 > > acpi_ev_address_space_dispatch+0x228/0x2c4 > > acpi_ex_access_region+0x114/0x268 > > acpi_ex_field_datum_io+0x128/0x1b8 > > acpi_ex_extract_from_field+0x14c/0x2ac > > acpi_ex_read_data_from_field+0x190/0x1b8 > > acpi_ex_resolve_node_to_value+0x1ec/0x288 > > acpi_ex_resolve_to_value+0x250/0x274 > > acpi_ds_evaluate_name_path+0xac/0x124 > > acpi_ds_exec_end_op+0x90/0x410 > > acpi_ps_parse_loop+0x4ac/0x5d8 > > acpi_ps_parse_aml+0xe0/0x2c8 > > acpi_ps_execute_method+0x19c/0x1ac > > acpi_ns_evaluate+0x1f8/0x26c > > acpi_ns_init_one_device+0x104/0x140 > > acpi_ns_walk_namespace+0x158/0x1d0 > > acpi_ns_initialize_devices+0x194/0x218 > > acpi_initialize_objects+0x48/0x50 > > acpi_init+0xe0/0x498 > > > > If the Opregion address range is not present in the EFI memory map there > > is no way for us to determine the memory attributes to use to map it - > > defaulting to NormalNC does not work (and it is not correct on a memory > > region that may have read side-effects) and therefore commit > > 437b38c51162 should be reverted, which means reverting back to the > > original behavior whereby address ranges that are mapped using > > acpi_os_map_memory() default to the safe devicenGnRnE attributes on > > ARM64 if the mapped address range is not defined in the EFI memory map. > > > > Fixes: 437b38c51162 ("ACPI: Add memory semantics to acpi_os_map_memory()") > > Signed-off-by: Jia He > > Cc: Lorenzo Pieralisi > > Cc: Ard Biesheuvel > > Cc: Hanjun Guo > > Cc: Catalin Marinas > > Cc: Rafael J. Wysocki > > Cc: Harb Abdulhamid > > --- > > V3: refine the commit log which came from Lorenzo Pieralisi > > > > arch/arm64/include/asm/acpi.h | 3 --- > > arch/arm64/kernel/acpi.c | 19 +++---------------- > > drivers/acpi/osl.c | 23 +++++++---------------- > > include/acpi/acpi_io.h | 8 -------- > > 4 files changed, 10 insertions(+), 43 deletions(-) > > Acked-by: Lorenzo Pieralisi > > Rafael if possible please apply it, thank you very much. Applied as 5.15-rc material, thanks!