From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF9ABC433E1 for ; Mon, 27 Jul 2020 13:24:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD0132070A for ; Mon, 27 Jul 2020 13:24:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595856256; bh=BxJOFMzzG6sXshNHzF+AjVYbTdNEA1m8isjow/cb+1c=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=HD1vLxoLALryhQKp/QD5GQGbuzWUSwcRhTU/qG1B9qNGBTuiS5djxaaPhkjGEGuoB ZAWidJe2yXtn6dKFTD2S/0J3QDEkLaLQvW0hDoRz7JhZfWWjJK1dIcigana+AQB6Zd fT6JqA4rCw2COoxSYrAaR+uwi4c/Bz8c4Jc0i1O8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728156AbgG0NYQ (ORCPT ); Mon, 27 Jul 2020 09:24:16 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:43802 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726139AbgG0NYQ (ORCPT ); Mon, 27 Jul 2020 09:24:16 -0400 Received: by mail-oi1-f195.google.com with SMTP id l84so1751593oig.10; Mon, 27 Jul 2020 06:24:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vPijsWsA86ncuQ4YsaqIM+LvW4eENySIZkL8qr7mFnI=; b=ui8f+KUTdFarHw/52QqxxNiqpgJdfqXJPxZfP95AoXINyirlI7aroyaPg7OE1OthuO zs5LwuOZuJb1rk1016pERxHMmuP7yHwBNpcoH+yH8FimzhJOqKP+XVPQqOK+vyLlv1kT 1s180zaY1YQiQpFa//RwpgKmq/XUJx4LfpKcEjPFbdBsBIRu3ne+WvdOr9taY3UqCej4 h2ZXRioNPNzOP5hRQakte/Y+OzU5eSF/7+xl2hqxVXZ/HzZDpxu3MSVETuU0jCsqk3DN 3Dxf2BYMlNcm+sarer0muwIkPGdXxrdHrDQq4EyF/ODIk2vvghnh5Uu3Qp/i5eopj7bE 4kqA== X-Gm-Message-State: AOAM533hiMKsdDxHuzIQ+WXHTAC8cw+u0CpoXo3mnlnGvR7RONk1rMt6 C+KWH3Y8C2hNF/fUVaT7DBgIg9uNis27Fj96AkeI+Q== X-Google-Smtp-Source: ABdhPJwxgeTfu25/fNqV/Yp7m4UiuLztNmLGBCv6sgMQ/dSVqrERZH1ePjwzvqq5MtdHN4jGfHFnB4USsnISOTsaoQw= X-Received: by 2002:aca:4a89:: with SMTP id x131mr18906467oia.103.1595856255175; Mon, 27 Jul 2020 06:24:15 -0700 (PDT) MIME-Version: 1.0 References: <20200722170608.960983-1-colin.king@canonical.com> In-Reply-To: <20200722170608.960983-1-colin.king@canonical.com> From: "Rafael J. Wysocki" Date: Mon, 27 Jul 2020 15:24:04 +0200 Message-ID: Subject: Re: [PATCH] ACPI: APEI: remove redundant assignment to variable rc To: Colin King Cc: "Rafael J . Wysocki" , Len Brown , James Morse , Tony Luck , Borislav Petkov , ACPI Devel Maling List , kernel-janitors@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Wed, Jul 22, 2020 at 7:06 PM Colin King wrote: > > From: Colin Ian King > > The variable rc is being initialized with a value that is > never read and it is being updated later with a new value. The > initialization is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > drivers/acpi/apei/hest.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c > index 953a2fae8b15..6e980fe16772 100644 > --- a/drivers/acpi/apei/hest.c > +++ b/drivers/acpi/apei/hest.c > @@ -227,7 +227,7 @@ __setup("hest_disable", setup_hest_disable); > void __init acpi_hest_init(void) > { > acpi_status status; > - int rc = -ENODEV; > + int rc; > unsigned int ghes_count = 0; > > if (hest_disable) { > -- Applied as 5.9 material, thanks!