From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A77BBC76188 for ; Mon, 22 Jul 2019 08:31:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BCC532199C for ; Mon, 22 Jul 2019 08:31:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563784284; bh=OPj3cnLJW/G0PyFXgoZTUSi8XLcyjHWTwc42rlENWJs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=WMio2MUZ13GD3uibqsEVItjiubvJG5LrhAgg8OdgSQHpriI3FjGRIc8Mjhc/DPaMM KwI5BjjKfAoopn0zKFmYJpxxoxf0UoZND4/qS2tGIWhI6TGe0nbnLqsDM6OW/AcITP gcaIjAuIW0SlFw8Qftooxf6RVSNEfq1n3uAAu2i0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728151AbfGVIbY (ORCPT ); Mon, 22 Jul 2019 04:31:24 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:35256 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727304AbfGVIbY (ORCPT ); Mon, 22 Jul 2019 04:31:24 -0400 Received: by mail-ot1-f68.google.com with SMTP id j19so906159otq.2; Mon, 22 Jul 2019 01:31:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qH9X5iNUAvdfUeKpd2p6uIpK5xHWBxmzhoraupHL3oQ=; b=sMenGcp3OTQN/G7+T0j7duv8w8jRGa3Tzbw72xbmVz5KMxSYNxv5IMVATO0rP+7F1C bK9IQwtWZeaGOcXyReF3FSpk7ZLVQuGK1ffQzMX92dYAVpEH6MHwcWwN5NhRu3QJLKkS wrQIOxrlJ2E7bNC2sL8/aEF5HHt223MZqS6oLG4zxSF3eR+wrwJrXFQcWErB6eWzeX5l qY6PWhuPw+Oiqrrdfgrk+7XLmbnpmljzAGg/hKFk0BvkvLyqKwLXFHHI8FzrysK3G3dW l9+zaDndADHJXSlFbJcjsrhOzEmxiAhqTc2ZZSiADLeTIsVlKZHKEn8qNg/+KgRucgXs MRFw== X-Gm-Message-State: APjAAAXpq/wQmLtl2WjomEAXZS5kglXRed+pooCtnnaxU7X26WUGK4mI 0mltvOaDgTFjvgzLZNeFzd7g1HDWpebeWF5QLwI= X-Google-Smtp-Source: APXvYqwVqSP5V8Tus+6+2dAP0uhrF6qtZQqEUYrU6BBe3c5Fb5++tjEKA8b6i/rttuFeFAwAF1qfTViUfKgP2vgQwfw= X-Received: by 2002:a05:6830:8a:: with SMTP id a10mr21838380oto.167.1563784283215; Mon, 22 Jul 2019 01:31:23 -0700 (PDT) MIME-Version: 1.0 References: <20190722023530.67676-1-skunberg.kelsey@gmail.com> <20190722023530.67676-2-skunberg.kelsey@gmail.com> In-Reply-To: <20190722023530.67676-2-skunberg.kelsey@gmail.com> From: "Rafael J. Wysocki" Date: Mon, 22 Jul 2019 10:31:11 +0200 Message-ID: Subject: Re: [PATCH 1/3] ACPI: Remove acpi_has_method() call from acpi_adxl.c To: Kelsey Skunberg Cc: "Rafael J. Wysocki" , Len Brown , ACPI Devel Maling List , Linux Kernel Mailing List , skhan@linuxfoundation.org, linux-kernel-mentees@lists.linuxfoundation.org, bjorn@helgaas.com Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Jul 22, 2019 at 4:36 AM Kelsey Skunberg wrote: > > acpi_check_dsm() will already return an error if the DSM method does not > exist. Checking if the DSM method exists before the acpi_check_dsm() call > is not needed. Remove acpi_has_method() call to avoid additional work. > > Signed-off-by: Kelsey Skunberg > --- > drivers/acpi/acpi_adxl.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/acpi/acpi_adxl.c b/drivers/acpi/acpi_adxl.c > index 13c8f7b50c46..89aac15663fd 100644 > --- a/drivers/acpi/acpi_adxl.c > +++ b/drivers/acpi/acpi_adxl.c > @@ -148,11 +148,6 @@ static int __init adxl_init(void) > return -ENODEV; > } > > - if (!acpi_has_method(handle, "_DSM")) { > - pr_info("No DSM method\n"); And why is printing the message not useful? > - return -ENODEV; > - } > - > if (!acpi_check_dsm(handle, &adxl_guid, ADXL_REVISION, > ADXL_IDX_GET_ADDR_PARAMS | > ADXL_IDX_FORWARD_TRANSLATE)) { > -- > 2.20.1 >