Linux-ACPI Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] acpi: utils: remove unneeded break
@ 2020-10-19 20:04 trix
  2020-10-22 16:59 ` Rafael J. Wysocki
  0 siblings, 1 reply; 2+ messages in thread
From: trix @ 2020-10-19 20:04 UTC (permalink / raw)
  To: rjw, lenb; +Cc: linux-acpi, linux-kernel, Tom Rix

From: Tom Rix <trix@redhat.com>

A break is not needed if it is preceded by a return

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/acpi/utils.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
index 838b719ec7ce..d5411a166685 100644
--- a/drivers/acpi/utils.c
+++ b/drivers/acpi/utils.c
@@ -104,7 +104,6 @@ acpi_extract_package(union acpi_object *package,
 					      " [%c]\n",
 					      i, format_string[i]);
 				return AE_BAD_DATA;
-				break;
 			}
 			break;
 
@@ -129,7 +128,6 @@ acpi_extract_package(union acpi_object *package,
 					      " expecting [%c]\n",
 					      i, format_string[i]);
 				return AE_BAD_DATA;
-				break;
 			}
 			break;
 		case ACPI_TYPE_LOCAL_REFERENCE:
@@ -144,7 +142,6 @@ acpi_extract_package(union acpi_object *package,
 					      " expecting [%c]\n",
 					      i, format_string[i]);
 				return AE_BAD_DATA;
-				break;
 			}
 			break;
 
@@ -155,7 +152,6 @@ acpi_extract_package(union acpi_object *package,
 					  i));
 			/* TBD: handle nested packages... */
 			return AE_SUPPORT;
-			break;
 		}
 	}
 
-- 
2.18.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] acpi: utils: remove unneeded break
  2020-10-19 20:04 [PATCH] acpi: utils: remove unneeded break trix
@ 2020-10-22 16:59 ` Rafael J. Wysocki
  0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2020-10-22 16:59 UTC (permalink / raw)
  To: trix
  Cc: Rafael J. Wysocki, Len Brown, ACPI Devel Maling List,
	Linux Kernel Mailing List

On Mon, Oct 19, 2020 at 10:05 PM <trix@redhat.com> wrote:
>
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/acpi/utils.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
> index 838b719ec7ce..d5411a166685 100644
> --- a/drivers/acpi/utils.c
> +++ b/drivers/acpi/utils.c
> @@ -104,7 +104,6 @@ acpi_extract_package(union acpi_object *package,
>                                               " [%c]\n",
>                                               i, format_string[i]);
>                                 return AE_BAD_DATA;
> -                               break;
>                         }
>                         break;
>
> @@ -129,7 +128,6 @@ acpi_extract_package(union acpi_object *package,
>                                               " expecting [%c]\n",
>                                               i, format_string[i]);
>                                 return AE_BAD_DATA;
> -                               break;
>                         }
>                         break;
>                 case ACPI_TYPE_LOCAL_REFERENCE:
> @@ -144,7 +142,6 @@ acpi_extract_package(union acpi_object *package,
>                                               " expecting [%c]\n",
>                                               i, format_string[i]);
>                                 return AE_BAD_DATA;
> -                               break;
>                         }
>                         break;
>
> @@ -155,7 +152,6 @@ acpi_extract_package(union acpi_object *package,
>                                           i));
>                         /* TBD: handle nested packages... */
>                         return AE_SUPPORT;
> -                       break;
>                 }
>         }
>
> --

Applied as 5.10-rc material with subject and changelog edits, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 20:04 [PATCH] acpi: utils: remove unneeded break trix
2020-10-22 16:59 ` Rafael J. Wysocki

Linux-ACPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-acpi/0 linux-acpi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-acpi linux-acpi/ https://lore.kernel.org/linux-acpi \
		linux-acpi@vger.kernel.org
	public-inbox-index linux-acpi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-acpi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git