From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5347AC4363A for ; Thu, 22 Oct 2020 17:00:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB4112463F for ; Thu, 22 Oct 2020 17:00:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603386013; bh=63qWwpBeCgeHa2kEsx34nQD2nwkJ5cizdfvRKjXISpo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=ImZhRBSDsEC/bDFI8IGWXfqdhsViNAuZlxYlzLQ56BCcmCxbkHJszV9ZLvzW/uY/M HxuA84D9aqQhX1lgMVfZuvQybpPW6SmoRn2AR5LFCTGgNLl0IT9HmkOiXLPwycHcuj NfidUHhF4Ja2PN2v80np3iQA7ztGTU+FQ8VyL2VQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2902190AbgJVRAM (ORCPT ); Thu, 22 Oct 2020 13:00:12 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:43744 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2902192AbgJVRAM (ORCPT ); Thu, 22 Oct 2020 13:00:12 -0400 Received: by mail-ot1-f67.google.com with SMTP id k68so2101624otk.10; Thu, 22 Oct 2020 10:00:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YhY/+goENh+uMPXH9AN4+1ASRSuDIs6jlBTZohR8f0A=; b=lW9knr+tv1BGCH9mEFH+Ro9DvVXZalD3vcbxI6fMrYa6xHYG7NQghGxSBkO+zY1skp b1dwpq8tIkptxBabtcBFbt5MgKY8dYmjC8C1Om1OJXxUsmlWsEXYQEbtYQe388dLpKPP aD0wYbr9yCphG3tqJTikMmzMRkWij1a3kt1oovHvKWHupuDmVcx1Jm+aA0a1garVXoqC X8+lvfSbFFCuQ9WbYg4Mtj5a2SEmwOr7o433bcCYqYfeqt/ntkpWH/5nVd54K4LUcZH5 7Kw2T1lgqsyKa8owh3aR1vzXLGsuk/vlC8/rVx8cFhWO2H00WRg49SHLeoeRNwlrZHxN NdjQ== X-Gm-Message-State: AOAM533fTTOu5tzr+5KvKOG4JVIUicpLHsmXuBH2okYCg3WWCkv0tjkW foSdeRDEhyU5ZAITJGxTCVPkN7e4oRgdlZ1iap0= X-Google-Smtp-Source: ABdhPJwQwFMd5tqWC3eFnRySPxSn75mTBabC9StOcwSledQjIo3+fttoH5OLtoW/qSQ44OLVy/YLy/0huJJpyVchZGE= X-Received: by 2002:a9d:734f:: with SMTP id l15mr2699189otk.260.1603386009213; Thu, 22 Oct 2020 10:00:09 -0700 (PDT) MIME-Version: 1.0 References: <20201019200453.16864-1-trix@redhat.com> In-Reply-To: <20201019200453.16864-1-trix@redhat.com> From: "Rafael J. Wysocki" Date: Thu, 22 Oct 2020 18:59:58 +0200 Message-ID: Subject: Re: [PATCH] acpi: utils: remove unneeded break To: trix@redhat.com Cc: "Rafael J. Wysocki" , Len Brown , ACPI Devel Maling List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Oct 19, 2020 at 10:05 PM wrote: > > From: Tom Rix > > A break is not needed if it is preceded by a return > > Signed-off-by: Tom Rix > --- > drivers/acpi/utils.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c > index 838b719ec7ce..d5411a166685 100644 > --- a/drivers/acpi/utils.c > +++ b/drivers/acpi/utils.c > @@ -104,7 +104,6 @@ acpi_extract_package(union acpi_object *package, > " [%c]\n", > i, format_string[i]); > return AE_BAD_DATA; > - break; > } > break; > > @@ -129,7 +128,6 @@ acpi_extract_package(union acpi_object *package, > " expecting [%c]\n", > i, format_string[i]); > return AE_BAD_DATA; > - break; > } > break; > case ACPI_TYPE_LOCAL_REFERENCE: > @@ -144,7 +142,6 @@ acpi_extract_package(union acpi_object *package, > " expecting [%c]\n", > i, format_string[i]); > return AE_BAD_DATA; > - break; > } > break; > > @@ -155,7 +152,6 @@ acpi_extract_package(union acpi_object *package, > i)); > /* TBD: handle nested packages... */ > return AE_SUPPORT; > - break; > } > } > > -- Applied as 5.10-rc material with subject and changelog edits, thanks!