From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Sasha Levin <sashal@kernel.org>, Stable <stable@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
"Thorsten Leemhuis (regressions address)"
<regressions@leemhuis.info>
Subject: Re: Please revert commit 4287509b4d21e34dc492 from 5.16.y
Date: Thu, 10 Mar 2022 14:01:04 +0100 [thread overview]
Message-ID: <CAJZ5v0ghFyFG3aDRawoVFDvhXLkvjZqiaPeqbtFnRQvhd9T_rA@mail.gmail.com> (raw)
In-Reply-To: <YinyzxnSsty8BDKn@kroah.com>
On Thu, Mar 10, 2022 at 1:45 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Thu, Mar 10, 2022 at 01:26:16PM +0100, Rafael J. Wysocki wrote:
> > Hi Greg & Sasha,
> >
> > Commit 4287509b4d21e34dc492 that went into 5.16.y as a backport of
> > mainline commit dc0075ba7f38 ("ACPI: PM: s2idle: Cancel wakeup before
> > dispatching EC GPE") is causing trouble in 5.16.y, but 5.17-rc7
> > including the original commit is fine.
> >
> > This is most likely due to some other changes that commit dc0075ba7f38
> > turns out to depend on which have not been backported, but because it
> > is not an essential fix (and it was backported, because it carried a
> > Fixes tag and not because it was marked for backporting), IMV it is
> > better to revert it from 5.16.y than to try to pull all of the
> > dependencies in (and risk missing any of them), so please do that.
> >
> > Please see this thread:
> >
> > https://lore.kernel.org/linux-pm/31b9d1cd-6a67-218b-4ada-12f72e6f00dc@redhat.com/
>
> Odd that this is only showing up in 5.16 as this commit also is in 5.4
> and 5.10 and 5.15. Should I drop it from there as well?
It's better to do so, because these series are also likely to be
missing the mainline commits it depends on.
next prev parent reply other threads:[~2022-03-10 13:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 12:26 Please revert commit 4287509b4d21e34dc492 from 5.16.y Rafael J. Wysocki
2022-03-10 12:28 ` Rafael J. Wysocki
2022-03-10 12:45 ` Greg Kroah-Hartman
2022-03-10 12:50 ` Hans de Goede
2022-03-10 13:01 ` Rafael J. Wysocki [this message]
2022-03-10 13:45 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0ghFyFG3aDRawoVFDvhXLkvjZqiaPeqbtFnRQvhd9T_rA@mail.gmail.com \
--to=rafael@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=regressions@leemhuis.info \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).