From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFE2BC433B4 for ; Wed, 21 Apr 2021 16:53:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8744861445 for ; Wed, 21 Apr 2021 16:53:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241257AbhDUQxn (ORCPT ); Wed, 21 Apr 2021 12:53:43 -0400 Received: from mail-oo1-f43.google.com ([209.85.161.43]:38858 "EHLO mail-oo1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235436AbhDUQxn (ORCPT ); Wed, 21 Apr 2021 12:53:43 -0400 Received: by mail-oo1-f43.google.com with SMTP id p12-20020a4a2f0c0000b02901ecdbb16887so2422138oop.5; Wed, 21 Apr 2021 09:53:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+WcdVAWw1wrE0hCoQ+UXML3T7kI52AZNB5+mZJ4YXyA=; b=cQ4bRpTUkpKMKuk/SZmMkvkZhovg70ur5KulEFMV9YTnrLMa9eL8QJATDNtikdem0H VTOd8ICaIePVrtuR3sl4gRUohr+xfsk9+5zxq3jn4Rz7FSoMPJfMivkDuL1AgE/4qdDo VHysH4Nn4kCxs7tPHEkJjJU/sCdlq+p/JpxoQgzEAlufMHuBJBa+w5iJ1FyiDqF3R08s aF3GAgJzG9XGzUUcEs74CY2B1zaS+Un1WiFYaYxEFmUWjjIwln+Gy/L/mSV5YbBzduBF 4zS/h8l0gouaY80wUg1u1zq35oSllGGgCPTCvfDk3vZlsngD+ELnU0Cctq+Wtf+SLx9f V7HQ== X-Gm-Message-State: AOAM5322bKVvbDQxPXPU4IwtMXw4OE6AxvKX5AAZwN64WmsKABfIYOuu 9XYiIssSw+McSI2yCqtIneQUUJYG4dedl+D038U= X-Google-Smtp-Source: ABdhPJxSq8Z7Oay74Ci2aElVdYLnRCXpGGB0j1dzlozKhf7iQegxeIuo8msIODvBqfSxPh1mcqBZT4r7aiHGlWtKT74= X-Received: by 2002:a4a:d781:: with SMTP id c1mr21492266oou.44.1619023989913; Wed, 21 Apr 2021 09:53:09 -0700 (PDT) MIME-Version: 1.0 References: <20210415143758.1962567-1-colin.king@canonical.com> In-Reply-To: <20210415143758.1962567-1-colin.king@canonical.com> From: "Rafael J. Wysocki" Date: Wed, 21 Apr 2021 18:52:58 +0200 Message-ID: Subject: Re: [PATCH] ACPI: APEI: remove redundant assignment to variable rc To: Colin King Cc: "Rafael J . Wysocki" , Len Brown , James Morse , Tony Luck , Borislav Petkov , ACPI Devel Maling List , kernel-janitors@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Apr 15, 2021 at 4:38 PM Colin King wrote: > > From: Colin Ian King > > The variable rc is being assigned a value that is never read, > the assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > drivers/acpi/apei/einj.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/acpi/apei/einj.c b/drivers/acpi/apei/einj.c > index 133156759551..328e8aeece6c 100644 > --- a/drivers/acpi/apei/einj.c > +++ b/drivers/acpi/apei/einj.c > @@ -725,7 +725,6 @@ static int __init einj_init(void) > goto err_release; > } > > - rc = -ENOMEM; > einj_param = einj_get_parameter_address(); > if ((param_extension || acpi5) && einj_param) { > debugfs_create_x32("flags", S_IRUSR | S_IWUSR, einj_debug_dir, > -- Applied as 5.13 material, thanks!