From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50A03C04AB5 for ; Thu, 6 Jun 2019 09:17:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D67C2083E for ; Thu, 6 Jun 2019 09:17:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559812674; bh=UHeE9D1r0uIl8z+ihicEA4KPlsequelmViuEOx87T4Q=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=q08+bOiIQftpnw3MqNsW2IfjBcperpdnq3Yu/QaMuTdKsCaIrz5qHoGv5E/lDAOdU WCamUHU5hd4+6SCmQz1JWqpnK+t0cO5QKfu0sb0qAjKokyn3Wtirv5EYMoDdzZ7iWD gZ+ITGXsFSc7a56FbQQ7LGyqtw5pUgfioBg5l7Tc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727659AbfFFJRx (ORCPT ); Thu, 6 Jun 2019 05:17:53 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:38168 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727540AbfFFJRx (ORCPT ); Thu, 6 Jun 2019 05:17:53 -0400 Received: by mail-ot1-f68.google.com with SMTP id d17so1295315oth.5; Thu, 06 Jun 2019 02:17:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yENjbVk39/wwzHKltPutprMF9DY/I7doCf7SfJRKgi8=; b=It0+PNjNfu9hf2ysUWEID6Ddo/m/1ROgFUoYE1BzrlLq1DJ5ICLUptAs/Pvj/erwj+ UqPr/gflG5rGdX7/0PPxU2RFl1kwNKHDppX43EErtLJR+qVApumfyK/udXI3KAejv1TW 8C0nI32rC54+RrXSCPswTrHerCC2U/nxouNXmtaekQpDOqNfQZI3aHpdAYlTgwBYaXzH 8AoEaxdW5Ahpgl//1QP0UsZ2ErEf0QqVejAl4bbzUxGZA68TvulAPqvnJ4uHUHeaM1Ur TqoT3tevRVuMPx9VPnuDnwgy4OX5itVymAiFKe3i/m22zfoon8vWi0ZPphDO0LHq0H4N dqOQ== X-Gm-Message-State: APjAAAUSvZfFIX3ZzKGjUi8A+mKzOUI+WVogM3tf8JjbojLj+lOoNmWV 16qm9v0ICsVT54R+gBWM0mdYtVpOf4o9ZlO/BCs= X-Google-Smtp-Source: APXvYqwpqt4Y2D/ykZ/hJu7b0Xpsn+y8x9Q8fDqgKz20jFQNzEUdq+RPWEe2mZF6bzoomXq7tP+vR0+dQ/lk+sV4jGk= X-Received: by 2002:a05:6830:150:: with SMTP id j16mr14282814otp.262.1559812672475; Thu, 06 Jun 2019 02:17:52 -0700 (PDT) MIME-Version: 1.0 References: <1559747630-28065-1-git-send-email-suzuki.poulose@arm.com> <1559747630-28065-8-git-send-email-suzuki.poulose@arm.com> In-Reply-To: <1559747630-28065-8-git-send-email-suzuki.poulose@arm.com> From: "Rafael J. Wysocki" Date: Thu, 6 Jun 2019 11:17:41 +0200 Message-ID: Subject: Re: [PATCH 07/13] drivers: Add generic match helper by ACPI_COMPANION device To: Suzuki K Poulose Cc: Linux Kernel Mailing List , Greg Kroah-Hartman , "Rafael J. Wysocki" , Len Brown , ACPI Devel Maling List , linux-spi , Mark Brown Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Wed, Jun 5, 2019 at 5:14 PM Suzuki K Poulose wrote: > > Add a generic helper to match a device by the acpi device. "by its ACPI companion device object", please. Also, it would be good to combine this patch with the patch(es) that cause device_match_acpi_dev() to be actually used. Helpers without any users are arguably not useful. > > Cc: Len Brown > Cc: linux-acpi@vger.kernel.org > Cc: linux-spi@vger.kernel.org > Cc: Mark Brown > Cc: Greg Kroah-Hartman > Cc: "Rafael J. Wysocki" > Signed-off-by: Suzuki K Poulose > --- > drivers/base/core.c | 6 ++++++ > include/linux/device.h | 1 + > 2 files changed, 7 insertions(+) > > diff --git a/drivers/base/core.c b/drivers/base/core.c > index b827ca1..597095b 100644 > --- a/drivers/base/core.c > +++ b/drivers/base/core.c > @@ -3346,3 +3346,9 @@ int device_match_devt(struct device *dev, const void *pdevt) > return dev->devt == *(dev_t *)pdevt; > } > EXPORT_SYMBOL_GPL(device_match_devt); > + > +int device_match_acpi_dev(struct device *dev, const void *adev) > +{ > + return ACPI_COMPANION(dev) == adev; > +} > +EXPORT_SYMBOL(device_match_acpi_dev); > diff --git a/include/linux/device.h b/include/linux/device.h > index f315692..a03b50d 100644 > --- a/include/linux/device.h > +++ b/include/linux/device.h > @@ -166,6 +166,7 @@ void subsys_dev_iter_exit(struct subsys_dev_iter *iter); > int device_match_of_node(struct device *dev, const void *np); > int device_match_fwnode(struct device *dev, const void *fwnode); > int device_match_devt(struct device *dev, const void *pdevt); > +int device_match_acpi_dev(struct device *dev, const void *adev); > > int bus_for_each_dev(struct bus_type *bus, struct device *start, void *data, > int (*fn)(struct device *dev, void *data)); > -- > 2.7.4 >