From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
Vijendar.Mukunda@amd.com,
Alex Deucher <Alexander.Deucher@amd.com>,
Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com,
Mario Limonciello <Mario.Limonciello@amd.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
"open list:ACPI" <linux-acpi@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 2/5] drivers: acpi: acpi_apd: Remove unused device property "is-rv"
Date: Fri, 17 Dec 2021 19:06:51 +0100 [thread overview]
Message-ID: <CAJZ5v0i=LVsz2ZRBB5HzLpw8eR-zLAKtJyc3PFWu_kKCzjzZWw@mail.gmail.com> (raw)
In-Reply-To: <20211212180527.1641362-3-AjitKumar.Pandey@amd.com>
On Sun, Dec 12, 2021 at 7:06 PM Ajit Kumar Pandey
<AjitKumar.Pandey@amd.com> wrote:
>
> Initially "is-rv" device property is added for 48MHz fixed clock
> support on Raven or RV architecture. It's unused now as we moved
> to pci device_id based selection to extend such support on other
> architectures. This change removed unused code from acpi driver.
>
> Signed-off-by: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
> Reviewed-by: Mario Limonciello <Mario.Limonciello@amd.com>
Does this or the next patch depend on the rest of the series, or can I
simply apply them both?
> ---
> drivers/acpi/acpi_apd.c | 3 ---
> include/linux/platform_data/clk-fch.h | 1 -
> 2 files changed, 4 deletions(-)
>
> diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
> index 6e02448d15d9..6913e9712852 100644
> --- a/drivers/acpi/acpi_apd.c
> +++ b/drivers/acpi/acpi_apd.c
> @@ -87,9 +87,6 @@ static int fch_misc_setup(struct apd_private_data *pdata)
> if (ret < 0)
> return -ENOENT;
>
> - if (!acpi_dev_get_property(adev, "is-rv", ACPI_TYPE_INTEGER, &obj))
> - clk_data->is_rv = obj->integer.value;
> -
> list_for_each_entry(rentry, &resource_list, node) {
> clk_data->base = devm_ioremap(&adev->dev, rentry->res->start,
> resource_size(rentry->res));
> diff --git a/include/linux/platform_data/clk-fch.h b/include/linux/platform_data/clk-fch.h
> index b9f682459f08..850ca776156d 100644
> --- a/include/linux/platform_data/clk-fch.h
> +++ b/include/linux/platform_data/clk-fch.h
> @@ -12,7 +12,6 @@
>
> struct fch_clk_data {
> void __iomem *base;
> - u32 is_rv;
> };
>
> #endif /* __CLK_FCH_H */
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-12-17 18:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211212180527.1641362-1-AjitKumar.Pandey@amd.com>
2021-12-12 18:05 ` [PATCH v5 2/5] drivers: acpi: acpi_apd: Remove unused device property "is-rv" Ajit Kumar Pandey
2021-12-17 18:06 ` Rafael J. Wysocki [this message]
2021-12-17 18:19 ` Limonciello, Mario
2021-12-17 18:23 ` Rafael J. Wysocki
2021-12-12 18:05 ` [PATCH v5 3/5] ACPI: APD: Add a fmw property clk-name Ajit Kumar Pandey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0i=LVsz2ZRBB5HzLpw8eR-zLAKtJyc3PFWu_kKCzjzZWw@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=AjitKumar.Pandey@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).