From: "Rafael J. Wysocki" <rafael@kernel.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Dan Williams <dan.j.williams@intel.com>
Cc: Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] acpi: nfit.h: Replace zero-length array with flexible-array member
Date: Wed, 25 Mar 2020 11:05:36 +0100 [thread overview]
Message-ID: <CAJZ5v0iDVL1WWTmmQX+2JDmyAfu2e8nSdLSmCqA-WZV+7pBHvw@mail.gmail.com> (raw)
In-Reply-To: <20200319195046.GA452@embeddedor.com>
On Thu, Mar 19, 2020 at 9:15 PM Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
>
> The current codebase makes use of the zero-length array language
> extension to the C90 standard, but the preferred mechanism to declare
> variable-length types such as these ones is a flexible array member[1][2],
> introduced in C99:
>
> struct foo {
> int stuff;
> struct boo array[];
> };
>
> By making use of the mechanism above, we will get a compiler warning
> in case the flexible array does not occur last in the structure, which
> will help us prevent some kind of undefined behavior bugs from being
> inadvertently introduced[3] to the codebase from now on.
>
> Also, notice that, dynamic memory allocations won't be affected by
> this change:
>
> "Flexible array members have incomplete type, and so the sizeof operator
> may not be applied. As a quirk of the original implementation of
> zero-length arrays, sizeof evaluates to zero."[1]
>
> This issue was found with the help of Coccinelle.
>
> [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
> [2] https://github.com/KSPP/linux/issues/21
> [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Dan,
I'm assuming that you will take care of this one or please let me know
otherwise.
Cheers!
> ---
> drivers/acpi/nfit/nfit.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/acpi/nfit/nfit.h b/drivers/acpi/nfit/nfit.h
> index 24241941181c..af09143ce403 100644
> --- a/drivers/acpi/nfit/nfit.h
> +++ b/drivers/acpi/nfit/nfit.h
> @@ -144,32 +144,32 @@ struct nfit_spa {
> unsigned long ars_state;
> u32 clear_err_unit;
> u32 max_ars;
> - struct acpi_nfit_system_address spa[0];
> + struct acpi_nfit_system_address spa[];
> };
>
> struct nfit_dcr {
> struct list_head list;
> - struct acpi_nfit_control_region dcr[0];
> + struct acpi_nfit_control_region dcr[];
> };
>
> struct nfit_bdw {
> struct list_head list;
> - struct acpi_nfit_data_region bdw[0];
> + struct acpi_nfit_data_region bdw[];
> };
>
> struct nfit_idt {
> struct list_head list;
> - struct acpi_nfit_interleave idt[0];
> + struct acpi_nfit_interleave idt[];
> };
>
> struct nfit_flush {
> struct list_head list;
> - struct acpi_nfit_flush_address flush[0];
> + struct acpi_nfit_flush_address flush[];
> };
>
> struct nfit_memdev {
> struct list_head list;
> - struct acpi_nfit_memory_map memdev[0];
> + struct acpi_nfit_memory_map memdev[];
> };
>
> enum nfit_mem_flags {
> --
> 2.23.0
>
next prev parent reply other threads:[~2020-03-25 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 19:50 [PATCH][next] acpi: nfit.h: Replace zero-length array with flexible-array member Gustavo A. R. Silva
2020-03-25 10:05 ` Rafael J. Wysocki [this message]
2020-03-30 19:54 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0iDVL1WWTmmQX+2JDmyAfu2e8nSdLSmCqA-WZV+7pBHvw@mail.gmail.com \
--to=rafael@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=gustavo@embeddedor.com \
--cc=ira.weiny@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=rjw@rjwysocki.net \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).