From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6D56FA373F for ; Fri, 21 Oct 2022 17:56:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230150AbiJUR4i (ORCPT ); Fri, 21 Oct 2022 13:56:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229808AbiJUR4h (ORCPT ); Fri, 21 Oct 2022 13:56:37 -0400 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4F1B26551F; Fri, 21 Oct 2022 10:56:36 -0700 (PDT) Received: by mail-qk1-f170.google.com with SMTP id t25so2527144qkm.2; Fri, 21 Oct 2022 10:56:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fPM8TKWkSeLqibh2gUQQQJJ62C2z9/V7mCcM5ffseGA=; b=E/TT4g9vzADOh0eObO52uw8qMBxC/bLr7aLszGzr4wsIV0FC1fUUrRyJfb2u7Y9F30 jcsXZpbhswI/rzKTZNALWFKW2esNjeKRnZRPP07YardnHZUSp/8RcTb3QTEl8dobL2Kf /a8ez2OGT2Id2SbBxo0rVoeRknIs7PM4IGLpiELZMColewhtWPNL+3tX5H9isZzyc2lg q4VytRBx6MCgCJKnmg+f4gh/JqkvcHZKJJASTtVC9aufwNpVP7jSlYesYES9L1YGrqTl R/cU8xbzs/LXd8qQcdNfYUVLZ6HpkLVyl44c//fOtXR5AQ3ado5FPJcvuNP40V6Q5Im3 l5ow== X-Gm-Message-State: ACrzQf1GWsY46Cb9j7zCwuv3wpmedpWBr7U8Xtsm/uJvUuWjTqJKzVTk 9sil8aER7rMnjv1t8VgwT5CJOTIa8UjN8cXdW9Be1X33 X-Google-Smtp-Source: AMsMyM4Vt3ZrjuCWRNdfpBz4Z4erUW6gWVRGf1sCjzxago2tQ+T/Zjocx2cLM1a9t7oqLSOgGxTJmNdTg1oZaPwgClY= X-Received: by 2002:a05:620a:450c:b0:6ee:af91:60b2 with SMTP id t12-20020a05620a450c00b006eeaf9160b2mr15639967qkp.480.1666374995779; Fri, 21 Oct 2022 10:56:35 -0700 (PDT) MIME-Version: 1.0 References: <166631003537.1167078.9373680312035292395.stgit@dwillia2-xfh.jf.intel.com> In-Reply-To: <166631003537.1167078.9373680312035292395.stgit@dwillia2-xfh.jf.intel.com> From: "Rafael J. Wysocki" Date: Fri, 21 Oct 2022 19:56:24 +0200 Message-ID: Subject: Re: [PATCH] ACPI: NUMA: Add CXL CFMWS 'nodes' to the possible nodes set To: Dan Williams Cc: linux-cxl@vger.kernel.org, stable@vger.kernel.org, Alison Schofield , "Rafael J. Wysocki" , Vishal Verma , linux-acpi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Fri, Oct 21, 2022 at 1:55 AM Dan Williams wrote: > > The ACPI CEDT.CFMWS indicates a range of possible address where new CXL > regions can appear. Each range is associated with a QTG id (QoS > Throttling Group id). For each range + QTG pair that is not covered by a proximity > domain in the SRAT, Linux creates a new NUMA node. However, the commit > that added the new ranges missed updating the node_possible mask which > causes memory_group_register() to fail. Add the new nodes to the > nodes_possible mask. > > Cc: > Fixes: fd49f99c1809 ("ACPI: NUMA: Add a node and memblk for each CFMWS not in SRAT") > Cc: Alison Schofield > Cc: Rafael J. Wysocki > Reported-by: Vishal Verma > Tested-by: Vishal Verma > Signed-off-by: Dan Williams > --- > Rafael, I can take this through the CXL tree with some other pending > fixes. Sure. Acked-by: Rafael J. Wysocki > drivers/acpi/numa/srat.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c > index 3b818ab186be..1f4fc5f8a819 100644 > --- a/drivers/acpi/numa/srat.c > +++ b/drivers/acpi/numa/srat.c > @@ -327,6 +327,7 @@ static int __init acpi_parse_cfmws(union acpi_subtable_headers *header, > pr_warn("ACPI NUMA: Failed to add memblk for CFMWS node %d [mem %#llx-%#llx]\n", > node, start, end); > } > + node_set(node, numa_nodes_parsed); > > /* Set the next available fake_pxm value */ > (*fake_pxm)++; >