From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9E28C33CB3 for ; Thu, 16 Jan 2020 09:40:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8E75020748 for ; Thu, 16 Jan 2020 09:40:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579167622; bh=fU4iy348VebOCE+8xgICmRkD1LMLcUwcTkD3yaiLZ4I=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=2mILH8Nh8NK77PXLuy2j3luogCzr9kBqchUWd5xKh4qrPcix4t+6GwcVtaFrtr/4j SAd4KKHop38POMiDW+9xRmtKsD7E9fFvjxBoiMXq1Fv023iGWOUzRmi/FplSql0dwe 2kxDvarquvytA9YJWc7Ob7kxH3RNO6DF9sggJAY8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729274AbgAPJkW (ORCPT ); Thu, 16 Jan 2020 04:40:22 -0500 Received: from mail-oi1-f195.google.com ([209.85.167.195]:43259 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726653AbgAPJkW (ORCPT ); Thu, 16 Jan 2020 04:40:22 -0500 Received: by mail-oi1-f195.google.com with SMTP id p125so18317182oif.10; Thu, 16 Jan 2020 01:40:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ehZVRRgGA6K7LYKERYT9m9Kqby1XUIRO5leJf884LQg=; b=tbNAoalcCFQwchIcvadfmk38UTHM9PFnmL7tSpYsOE3/h2lG03b0xJwvX7mOr8KBIc lT/6p/Z4lv02ijdfMbmAy8NZA6jNue6nDAHb7bgULvVJT4HIAUWGvHiMxQE9cDru6Pm1 L9usN7+QSl+6G6Em5TpjK+ZVZeqPzOAapVbNoOAt7CeVJ0RNl5X1e2ZCT8LlUAd/B/Dg XwGmssoLMrppPiyFR4eOH4q+sweyJhf6GhgObkY6OFfae/GYI2thu7OgEnuJadO+SxTF qngHnAuop9Rjdrt2FUd0jTd8G9i91SvKzsljYsRszHjTOc0FvDhJig8vx53Nm55CxU4v mNIA== X-Gm-Message-State: APjAAAWmeHXe7hnEpWHG2IhbMfJqm4PLD5Xq+g7lJGLyhd6P70E4vBLL MV2zBaD6jKBpUPQ76sg9B4gXROh26jA4U/ooVzg= X-Google-Smtp-Source: APXvYqycvvoo15q+FPGQpz1gedkk2HzrTF+WByd8rPEEEg6NgUkf5VAlB3qg+1sxI+fx5OiEllxn+V4E7zXAb2JHu2Y= X-Received: by 2002:aca:cd92:: with SMTP id d140mr3388803oig.68.1579167621279; Thu, 16 Jan 2020 01:40:21 -0800 (PST) MIME-Version: 1.0 References: <20200115232629.GA9231@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> In-Reply-To: <20200115232629.GA9231@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> From: "Rafael J. Wysocki" Date: Thu, 16 Jan 2020 10:40:08 +0100 Message-ID: Subject: Re: [RESEND PATCH] ACPICA: Enable sleep button on ACPI legacy wake To: Anchal Agarwal , Erik Kaneda , Robert Moore Cc: Rafael Wysocki , ACPI Devel Maling List , Linux Kernel Mailing List , Len Brown , "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" , "Singh, Balbir" , fllinden@amazon.com Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Jan 16, 2020 at 12:26 AM Anchal Agarwal wrote: > > Currently we do not see sleep_enable bit set after guest resumes > from hibernation. Hibernation is triggered in guest on receiving > a sleep trigger from the hypervisor(S4 state). We see that power > button is enabled on wake up from S4 state however sleep button > isn't. This causes subsequent invocation of sleep state to fail > in the guest. Any environment going through acpi_hw_legacy_wake() > won't have sleep button enabled. > > Signed-off-by: Anchal Agarwal > Reviewed-by: Balbir Singh > Reviewed-by: Frank van der Linden > --- > drivers/acpi/acpica/hwsleep.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/acpi/acpica/hwsleep.c b/drivers/acpi/acpica/hwsleep.c > index b62db8ec446f..a176c7802760 100644 > --- a/drivers/acpi/acpica/hwsleep.c > +++ b/drivers/acpi/acpica/hwsleep.c > @@ -300,6 +300,17 @@ acpi_status acpi_hw_legacy_wake(u8 sleep_state) > [ACPI_EVENT_POWER_BUTTON]. > status_register_id, ACPI_CLEAR_STATUS); > > + /* Enable sleep button */ > + (void) > + acpi_write_bit_register(acpi_gbl_fixed_event_info > + [ACPI_EVENT_SLEEP_BUTTON]. > + enable_register_id, ACPI_ENABLE_EVENT); > + > + (void) > + acpi_write_bit_register(acpi_gbl_fixed_event_info > + [ACPI_EVENT_SLEEP_BUTTON]. > + status_register_id, ACPI_CLEAR_STATUS); > + > acpi_hw_execute_sleep_method(METHOD_PATHNAME__SST, ACPI_SST_WORKING); > return_ACPI_STATUS(status); > } Erik, Bob, please pick this up if you don't have specific objections against it. I'll wait for it to show up in an upstream release.