From: "Rafael J. Wysocki" <rafael@kernel.org>
To: "Marty E. Plummer" <hanetzer@startmail.com>
Cc: rafael@kernel.org, Pedro Falcato <pedro.falcato@gmail.com>,
lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, rui.zhang@intel.com,
swiftgeek@gmail.com, zh.nvgt@gmail.com
Subject: Re: [PATCH] ACPI: Make custom_method use per-open state
Date: Thu, 2 Feb 2023 10:34:51 +0100 [thread overview]
Message-ID: <CAJZ5v0ifTg24nNYa-jPkVqmg=gjqmow2ahkm2NV2eDy6Z9HEsg@mail.gmail.com> (raw)
In-Reply-To: <CAJZ5v0iXcRFamA+mE837=zHReBT-+8WmMeRDR7L9R+FVpLr25A@mail.gmail.com>
On Thu, Feb 2, 2023 at 2:04 AM Marty E. Plummer <hanetzer@startmail.com> wrote:
>
> From: "Rafael J. Wysocki" <rafael@kernel.org>
>
> > On Wed, Feb 1, 2023 at 12:38 AM Pedro Falcato <pedro.falcato@gmail.com> wrote:
> > >
> > > Make custom_method keep its own per-file-open state instead of global
> > > state in order to avoid race conditions[1] and other possible conflicts
> > > with other concurrent users.
> > >
> > > Link: https://lore.kernel.org/linux-acpi/20221227063335.61474-1-zh.nvgt@gmail.com/ # [1]
> > > Reported-by: Hang Zhang <zh.nvgt@gmail.com>
> > > Cc: Swift Geek <swiftgeek@gmail.com>
> > > Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
> > > ---
> > > This patch addresses Hang's problems plus the ones raised by Rafael in his review (see link above).
> > > https://lore.kernel.org/lkml/2667007.mvXUDI8C0e@kreacher/ was submitted but since there were still people
> > > that wanted this feature, I took my time to write up a patch that should fix the issues.
> > > Hopefully the linux-acpi maintainers have not decided to remove custom_method just yet.
> >
> > Well, thanks for the patch, but yes, they have. Sorry.
>
> Honestly, I think that's a bit of a cop out. This is git. git revert exists,
> and you're crippling the abilities of quite a lot of coreboot/etc development.
Perhaps they can try to use the ACPI debugger that's in the kernel now
instead of a known-broken interface?
prev parent reply other threads:[~2023-02-02 9:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 23:37 [PATCH] ACPI: Make custom_method use per-open state Pedro Falcato
2023-02-01 18:34 ` Rafael J. Wysocki
2023-02-02 7:49 ` Sebastian Grzywna
2023-02-02 10:03 ` Rafael J. Wysocki
2023-02-02 10:44 ` Rafael J. Wysocki
2023-02-02 15:48 ` Pedro Falcato
2023-03-13 23:45 ` Pedro Falcato
2023-02-03 6:42 ` Sebastian Grzywna
2023-02-02 9:34 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0ifTg24nNYa-jPkVqmg=gjqmow2ahkm2NV2eDy6Z9HEsg@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=hanetzer@startmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pedro.falcato@gmail.com \
--cc=rui.zhang@intel.com \
--cc=swiftgeek@gmail.com \
--cc=zh.nvgt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).