From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCC75C433DB for ; Mon, 25 Jan 2021 16:26:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A8BE221E5 for ; Mon, 25 Jan 2021 16:26:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729808AbhAYQ02 (ORCPT ); Mon, 25 Jan 2021 11:26:28 -0500 Received: from mail-oo1-f42.google.com ([209.85.161.42]:39147 "EHLO mail-oo1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730770AbhAYQ0D (ORCPT ); Mon, 25 Jan 2021 11:26:03 -0500 Received: by mail-oo1-f42.google.com with SMTP id z36so1463211ooi.6; Mon, 25 Jan 2021 08:25:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eFwTq+OScXIcVonxGOjBlHjUqwMYEvu6XWhum3jN8NI=; b=CL7M/oUzUcl5VtJNC1eEZNqlaTiTMo25p60mGtRGfBkTI4YgONPaJehJWyXipQ4Wh3 HmlGnnu6Cq/wSBkKrTnr+Kb8XSlkwANRR/H14shTP2lnz571+KV4zPcZTGam+YdY2ULj 4tJ5r14ODIRv4O1MwltyFZxfSFVwFyt1tnsHjQKdps6xmE5RIN78sA+cwEoJhvAxcrwE /A6+ihoLEI/Kg0VR4H02ezY2zB1oxAwUGIrMb2YfSnyQVtZrqUva89r6ejpjymPwghp8 IjKJe+mzdS0VI727P4v9rn9Dtn0BNf3yB1iEPUaM9jrNLslh4VzU5ZZul5ce5chAB4DW INew== X-Gm-Message-State: AOAM530+Kz8jRR4xJg4YpqkdTKEiIcXMCb55BtObKSSXHZuVLQqtQhuo uqel/MSI8wtOb4x+89bD7640S9II8dxjYVFxFlU= X-Google-Smtp-Source: ABdhPJw94FS2sVkIv7zvr5rZNd8U07Htu+OFlLA4/p6peeom+asbQeBkITEoCKvoQ4I4CyzSQUvYE2e5xtNUlRgxMmc= X-Received: by 2002:a4a:9873:: with SMTP id z48mr1015923ooi.44.1611591922626; Mon, 25 Jan 2021 08:25:22 -0800 (PST) MIME-Version: 1.0 References: <87blkbx1gt.fsf@gmx.net> <9709109.MH8tSaV5v9@kreacher> <87eej0iuf0.fsf@gmx.net> <87wnw278ds.fsf@gmx.net> In-Reply-To: <87wnw278ds.fsf@gmx.net> From: "Rafael J. Wysocki" Date: Mon, 25 Jan 2021 17:25:11 +0100 Message-ID: Subject: Re: power-off delay/hang due to commit 6d25be57 (mainline) To: Stephen Berman Cc: "Rafael J. Wysocki" , Sebastian Andrzej Siewior , Zhang Rui , Robert Moore , Erik Kaneda , Len Brown , Thomas Gleixner , Peter Zijlstra , Linux Kernel Mailing List , ACPI Devel Maling List , "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" , "Rafael J. Wysocki" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Sun, Jan 24, 2021 at 2:49 PM Stephen Berman wrote: > > On Mon, 04 Jan 2021 16:38:43 +0100 Stephen Berman wrote: > > > On Thu, 31 Dec 2020 21:46:11 +0100 "Rafael J. Wysocki" wrote: > > > >> ATM, I'm tempted to do something like the patch below (with the rationale > >> that it shouldn't be necessary to read the temperature right after updating > >> the trip points if polling is in use, because the next update through polling > >> will cause it to be read anyway and it will trigger trip point actions as > >> needed). > >> > >> Stephen, can you give it a go, please? > > > > On Sat, 02 Jan 2021 12:03:17 +0100 "Rafael J. Wysocki" wrote: > > > >> There is one more way to address this, probably better: instead of checking the > >> temperature right away in acpi_thermal_notify(), queue that on > >> acpi_thermal_pm_queue > >> and so only if another thermal check is not pending. > >> > >> This way there will be at most one temperature check coming from > >> acpi_thermal_notify() queued up at any time which should prevent the > >> build-up of work items from taking place. > >> > >> So something like this: > > > > Thanks for the patches. I'll try them as soon as I can. > > FTR, since this is the thread I started for this bug, I've confirmed in > https://lore.kernel.org/lkml/87y2gi78sg.fsf@gmx.net/T/#t that the latest > patch fixes the bug. OK, thanks! The patch has been applied as 5.11-rc material.