From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93CD2C433B4 for ; Mon, 19 Apr 2021 11:35:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6368E6108B for ; Mon, 19 Apr 2021 11:35:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235872AbhDSLfj (ORCPT ); Mon, 19 Apr 2021 07:35:39 -0400 Received: from mail-oi1-f170.google.com ([209.85.167.170]:42959 "EHLO mail-oi1-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230272AbhDSLfi (ORCPT ); Mon, 19 Apr 2021 07:35:38 -0400 Received: by mail-oi1-f170.google.com with SMTP id n140so35079298oig.9; Mon, 19 Apr 2021 04:35:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7K5odPDOES5CPhUMgYhbew2lZw0WkcvFtDvEI9ulVZg=; b=YLUvRdaiVLDSeBY35KjuRS9H5IQq/MktX32t8XzXP9D3WQhtXdaetEvTyQ0meMfS/W ed+KW7afk7qRjipiKxwN8/YTgFywau19z2VaiJ/DHhfb6uLyRn0HJ9W/0apGIJlKwGYO qVpuEt4G9zczbaHGmxG9dYC8nRn/2oZZTog3PhhV5ZXQt7XaUzFqnEpVbPO3NF8u99gq gs72NWEQFpLwbXXix2dZZ1bYsXOaix1APQ04iDJeubxuE1paO3cdCboi+ikmbICzsVdl pCcxueUEiU10wxMYF12mZDJnzWVITTb2/5DvuoPUUGVgVSvO3tDiPJE0Y0m611xhQVAj GIBw== X-Gm-Message-State: AOAM532gAv1g6l6JHg1WF2FlgJFCqPCFFdzrs4Uzgigh/L1b95vgRtxm ODvZIVgoiWxrDy72lJnADNQVBs55LY7L/YdM+gi+9xzc X-Google-Smtp-Source: ABdhPJz3p17brhXUQ7rZMATBBQvPGVxjO/I3EzHx4zT8TmUVuAaxzKSCyQ/ZH+jigKdzsnoddz6wlqngdaCz5S6R8Qc= X-Received: by 2002:a54:4501:: with SMTP id l1mr15746077oil.157.1618832108958; Mon, 19 Apr 2021 04:35:08 -0700 (PDT) MIME-Version: 1.0 References: <20210419090750.1272562-1-kai.heng.feng@canonical.com> In-Reply-To: <20210419090750.1272562-1-kai.heng.feng@canonical.com> From: "Rafael J. Wysocki" Date: Mon, 19 Apr 2021 13:34:52 +0200 Message-ID: Subject: Re: [PATCH] ACPI: PM: s2idle: Invoke _PTS for s2idle To: Kai-Heng Feng Cc: "Rafael J. Wysocki" , Len Brown , "open list:ACPI" , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Apr 19, 2021 at 11:08 AM Kai-Heng Feng wrote: > > HP EliteBook 840 G8 reboots on s2idle resume, and HP EliteBook 845 G8 > wakes up immediately on s2idle. Both are caused by the XMM7360 WWAN PCI > card. > > There's a WWAN specific method to really turn off the WWAN via EC: > Method (_PTS, 1, NotSerialized) // _PTS: Prepare To Sleep > { > ... > If (CondRefOf (\_SB.PCI0.GP12.PTS)) > { > \_SB.PCI0.GP12.PTS (Arg0) > } > ... > } > > Scope (_SB.PCI0.GP12) > { > ... > Method (PTS, 1, Serialized) > { > If (^^LPCB.EC0.ECRG) > { > If ((PDID == 0xFFFF)) > { > Return (Zero) > } > > POFF () > SGIO (WWBR, One) > Sleep (0x1E) > Acquire (^^LPCB.EC0.ECMX, 0xFFFF) > ^^LPCB.EC0.WWP = One > Release (^^LPCB.EC0.ECMX) > Sleep (0x01F4) > } > > Return (Zero) > } > ... > } > > So let's also invok _PTS for s2idle. > > Signed-off-by: Kai-Heng Feng > --- > drivers/acpi/sleep.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c > index 09fd13757b65..7e84b4b09919 100644 > --- a/drivers/acpi/sleep.c > +++ b/drivers/acpi/sleep.c > @@ -698,6 +698,7 @@ int acpi_s2idle_prepare(void) > } > > acpi_enable_wakeup_devices(ACPI_STATE_S0); > + acpi_enter_sleep_state_prep(ACPI_STATE_S0); The system is in S0 already at this point, so not really. Please use a quirk to address this. > > /* Change the configuration of GPEs to avoid spurious wakeup. */ > acpi_enable_all_wakeup_gpes(); > --