From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BDE2ECE58C for ; Fri, 11 Oct 2019 10:39:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 716D92089F for ; Fri, 11 Oct 2019 10:39:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570790342; bh=5rhBL3QPB3LDlKRZEvA7m79jcTNQUF761bud+b8RYUo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=gpOXea4fT5kB8S5GvYBxdLRc4XyF2/XtzWzrqIJGRqS7gEWktvyDrCZ0l2QCE/zdY oTGueXV4Rx6wkCDjpGglaxE/nGcPXmtvLle2D0lBbdYeb1lEKGSWAj24/S0tATwfOm lmHxTBez/yoVoX7WQiFbTYS5KQwLoxnAprRpYzJY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727149AbfJKKjC (ORCPT ); Fri, 11 Oct 2019 06:39:02 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:37009 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726290AbfJKKjB (ORCPT ); Fri, 11 Oct 2019 06:39:01 -0400 Received: by mail-oi1-f195.google.com with SMTP id i16so7600364oie.4; Fri, 11 Oct 2019 03:39:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+tb4OyPeBvddVVgZ3mAAcmtLcYtmURpW+oNgkhTLycc=; b=gNx6TnFWJfQv4bwHZ8QhYfn3NI44sWyxs+AlLC/iYVLn9kCof/sIpkbzLl2agu+OpV ikkc6zhLez+OYL/RMw0GLgJ2z3xKcxA39w8ZlUVM1v2+oodD+lTbCFhd49P3DEkiKDLv N45TqpTui2t7xJycakrao246LPqNVvJ4N/SxVKGK59tdheRWn7ZuSBBOa/hx3buJMs/B VU8QQ62Z/BkXQOs9oi4xuOQAhGwTVZfTwMlTQO+oZp/K8QUbU1RJXVaV72fORMxoGooI lDSp7UyqKtPMjvG6dEreS4o10As5HfKJPYWOmh/vkD5ee2uRv6IMRTGO+SD6TRV70YNN I4wg== X-Gm-Message-State: APjAAAVPe1bOQnBvPPC8Y1eiTJX50/BhuuBXFrp7M+KAklvP38/pkp8d hekB1lltxsvwRarVFu2Od4IQcilBPqMe201UumzB8A== X-Google-Smtp-Source: APXvYqxQJUnKRLLcrN7dm7Pyw1dBZn5rts9p263jE4FizkPGHP2kBVS1voppc6S+ATQ1vRGvdZx6uZtLUGnDOLoVDvY= X-Received: by 2002:aca:5885:: with SMTP id m127mr11800131oib.110.1570790340768; Fri, 11 Oct 2019 03:39:00 -0700 (PDT) MIME-Version: 1.0 References: <20191009130433.29134-1-sameo@linux.intel.com> <20191009130433.29134-2-sameo@linux.intel.com> In-Reply-To: <20191009130433.29134-2-sameo@linux.intel.com> From: "Rafael J. Wysocki" Date: Fri, 11 Oct 2019 12:38:49 +0200 Message-ID: Subject: Re: [PATCH 1/2] acpi: Fail GED probe when not on hardware-reduced To: Samuel Ortiz Cc: Len Brown , "Rafael J . Wysocki" , Linux Kernel Mailing List , ACPI Devel Maling List Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Wed, Oct 9, 2019 at 3:04 PM Samuel Ortiz wrote: > > The Generic Event Device (GED) is a hardware-reduced platform device. No, it is not AFAICS. The spec doesn't say that GED cannot be used on platforms that aren't HW-reduced and if evged.c is going to be built in unconditionally, the kernel will be able to handle GED regardless. > Probing this driver on fixed platforms should fail. > > Signed-off-by: Samuel Ortiz > --- > drivers/acpi/evged.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/acpi/evged.c b/drivers/acpi/evged.c > index aba0d0027586..55de4b2d2fee 100644 > --- a/drivers/acpi/evged.c > +++ b/drivers/acpi/evged.c > @@ -127,6 +127,9 @@ static int ged_probe(struct platform_device *pdev) > struct acpi_ged_device *geddev; > acpi_status acpi_ret; > > + if (!acpi_gbl_reduced_hardware) > + return -ENODEV; > + > geddev = devm_kzalloc(&pdev->dev, sizeof(*geddev), GFP_KERNEL); > if (!geddev) > return -ENOMEM; > -- > 2.21.0 >