From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D819BC433B4 for ; Thu, 8 Apr 2021 15:04:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0E2B61103 for ; Thu, 8 Apr 2021 15:04:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232068AbhDHPFA (ORCPT ); Thu, 8 Apr 2021 11:05:00 -0400 Received: from mail-ot1-f50.google.com ([209.85.210.50]:35665 "EHLO mail-ot1-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232052AbhDHPEz (ORCPT ); Thu, 8 Apr 2021 11:04:55 -0400 Received: by mail-ot1-f50.google.com with SMTP id v24-20020a9d69d80000b02901b9aec33371so2605891oto.2; Thu, 08 Apr 2021 08:04:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Lz31zLZWAqCN/8o9830TFwS7tMhL2r4G2foyIgDy9Rc=; b=s51zz718Tpw6xGEVsvnqShsrDQAT/aNhIATHfXKIPXWwnFq2RPFXPJq1iqy7WHUPAb 7Hgkjnd2xSMybuvEEb3rPS6sPSQJB3RuzB7QGdSjsX00xoR3LdtR+sWedGBZff/8IFHT s5vaatg0Gh1KX4/ovBu8lnjdm42FlQDF9JZbfKa9PqFUQ6in5VLL6rbDPw0cJvjSkwiP ZG+gvhuAECIsh5NxnD0IaNo0ZKksxHNsd+LwKzhFnb0xQ5qkb0JeQQahHEAhq0JPMjj9 oDlg+d79btAftHGKJ34ZjCyte5yhku8BsR7kM4e24FtdkaMpOYSb0WcrUcw3F5OL9Jk6 KZAw== X-Gm-Message-State: AOAM530zahIRutyGUO2vJd8EUP8Z/l3hJRK61P5OCoA0b7hF5nZKQfkF hAqv/yD9iDoQWvlKCSRBOeo5LbW7iP6dF4SW280= X-Google-Smtp-Source: ABdhPJz3KoxJanp0wZDxXk9EhO+2ND46HZ78Kw+J9fAjM5vdN7PwyWK8BDOj8yCHhbpr2450dX7BejS8n5of3oHlIZo= X-Received: by 2002:a9d:4811:: with SMTP id c17mr8269736otf.206.1617894282947; Thu, 08 Apr 2021 08:04:42 -0700 (PDT) MIME-Version: 1.0 References: <20210329151207.36619-1-andriy.shevchenko@linux.intel.com> In-Reply-To: From: "Rafael J. Wysocki" Date: Thu, 8 Apr 2021 17:04:32 +0200 Message-ID: Subject: Re: [PATCH v2 1/6] software node: Free resources explicitly when swnode_register() fails To: Andy Shevchenko Cc: "Rafael J. Wysocki" , Heikki Krogerus , Daniel Scally , Linux Kernel Mailing List , Linux Media Mailing List , ACPI Devel Maling List , Greg Kroah-Hartman , Yong Zhi , Sakari Ailus , Bingbu Cao , Tianshu Qiu , Mauro Carvalho Chehab Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Apr 8, 2021 at 4:50 PM Andy Shevchenko wrote: > > On Thu, Apr 08, 2021 at 04:15:37PM +0200, Rafael J. Wysocki wrote: > > On Wed, Mar 31, 2021 at 1:06 PM Heikki Krogerus > > wrote: > > > > > > On Mon, Mar 29, 2021 at 06:12:02PM +0300, Andy Shevchenko wrote: > > > > Currently we have a slightly twisted logic in swnode_register(). > > > > It frees resources that it doesn't allocate on error path and > > > > in once case it relies on the ->release() implementation. > > > > > > > > Untwist the logic by freeing resources explicitly when swnode_register() > > > > fails. Currently it happens only in fwnode_create_software_node(). > > > > > > > > Signed-off-by: Andy Shevchenko > > > > > > It all looks OK to me. FWIW, for the whole series: > > > > > > Reviewed-by: Heikki Krogerus > > > > Whole series applied (with some minor changelog edits) as 5.13 material, thanks! > > It seems Greg applied it already. Was it dropped there? Did he? OK, so please let me know if it's still there in the Greg's tree.