linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Linux ACPI <linux-acpi@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Hanjun Gou <gouhanjun@huawei.com>
Subject: Re: [PATCH v1 2/2] ACPI: OSL: Clean up printing messages
Date: Tue, 9 Feb 2021 15:55:06 +0100	[thread overview]
Message-ID: <CAJZ5v0j0xRHxEN=m3_NcSUgGOD491_DPFfc-1dK2hTixzBRHJA@mail.gmail.com> (raw)
In-Reply-To: <337f970b0643d2f67f9a388ff8bbddcf673a1c6b.camel@perches.com>

On Mon, Feb 8, 2021 at 9:49 PM Joe Perches <joe@perches.com> wrote:
>
> On Mon, 2021-02-08 at 19:59 +0100, Rafael J. Wysocki wrote:
> > Replace the ACPI_DEBUG_PRINT() instance in osl.c unrelated to the
> > ACPICA debug with acpi_handle_debug(), add a pr_fmt() definition
> > to osl.c and replace direct printk() usage in that file with the
> > suitable pr_*() calls.
> []
> > ===================================================================
> > --- linux-pm.orig/drivers/acpi/osl.c
> > +++ linux-pm/drivers/acpi/osl.c
> []
> > @@ -528,13 +531,13 @@ acpi_os_predefined_override(const struct
> >
> >
> >       *new_val = NULL;
> >       if (!memcmp(init_val->name, "_OS_", 4) && strlen(acpi_os_name)) {
> > -             printk(KERN_INFO PREFIX "Overriding _OS definition to '%s'\n",
> > +             pr_info("Overriding _OS definition to '%s'\n",
> >                      acpi_os_name);
>
> If you do more of these, perhaps rewrap lines to 80 columns when possible.
>
>                 pr_info("Overriding _OS definition to '%s'\n", acpi_os_name);
>
> etc...

I've overlooked this one, will fix it up in the final commit.

Thanks!

      reply	other threads:[~2021-02-09 14:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-08 18:56 [PATCH v1 0/2] ACPI: OSL: SImplify acpi_check_resource_confllict() and clean up printing messages Rafael J. Wysocki
2021-02-08 18:58 ` [PATCH v1 1/2] ACPI: OSL: Rework acpi_check_resource_conflict() Rafael J. Wysocki
2021-02-08 18:59 ` [PATCH v1 2/2] ACPI: OSL: Clean up printing messages Rafael J. Wysocki
2021-02-08 20:45   ` Joe Perches
2021-02-09 14:55     ` Rafael J. Wysocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJZ5v0j0xRHxEN=m3_NcSUgGOD491_DPFfc-1dK2hTixzBRHJA@mail.gmail.com' \
    --to=rafael@kernel.org \
    --cc=gouhanjun@huawei.com \
    --cc=joe@perches.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).