From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D1AAC433E0 for ; Wed, 24 Feb 2021 15:40:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD6E564DD3 for ; Wed, 24 Feb 2021 15:40:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233463AbhBXPhb (ORCPT ); Wed, 24 Feb 2021 10:37:31 -0500 Received: from mail-ot1-f45.google.com ([209.85.210.45]:41533 "EHLO mail-ot1-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235807AbhBXOOL (ORCPT ); Wed, 24 Feb 2021 09:14:11 -0500 Received: by mail-ot1-f45.google.com with SMTP id s107so2229618otb.8; Wed, 24 Feb 2021 06:13:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h2j1OQcC6pRu4C41Nua1+DvIa5S64jnvnHsOlfkQ42c=; b=aAnhsL8N4SYAXxg0/PzkuAK3iqnRK22E+15zEMwVfZEerBCUbM7OojH5bhJdp20Yx6 rSZkr4ANrvDIROVLK+Ah0TbnAPHxXOYlWpKfKugEsH80I3FWDebpbu7Awlkn8EYj+P7L hMt7U+Yn+uXfK1Y6H/vDG0A2QIf5yK0mIq1KM1h6mbnpEt+VcA61WzET9G15NHPxRG/E 7uiIsmz0POhJy7yqBn2+DHyf5ZXliEs1nEAEFtzXjLmsw2owOA0VLAKLTJVbxJh19tcM a27ZFPtRVmHUNWNHwMroM+k9dlJAyHtEfq3yUj7aZXfDMjQeHBDdgHeLYpAkH4cTwRtD EhSw== X-Gm-Message-State: AOAM5311TqekiOAQM4S6LLiphFjAz4wG+D5PlH+wYnXZ5tpVECRBMQ+F 9KPASTV2d17uyvz+QOUJBa+Of4nBEn/YYu5YO0E= X-Google-Smtp-Source: ABdhPJwvdZOlEtOKLC0PNT9kUvhCQfrphgGal8P+NdAQdhH5NsOW12uNdq36+aQScRQqmeJ1yorxtFSKbOD58QmUBr8= X-Received: by 2002:a9d:22a5:: with SMTP id y34mr20919807ota.321.1614176009175; Wed, 24 Feb 2021 06:13:29 -0800 (PST) MIME-Version: 1.0 References: <20210211201703.658240-1-luzmaximilian@gmail.com> <898aa498-8256-d59f-9e72-0e1199b3a62a@redhat.com> <510803ab-b5b8-ce2c-e956-5539874d00bf@redhat.com> <8435cc87-d92f-e1c3-97c7-e2113e0ff3a9@redhat.com> In-Reply-To: <8435cc87-d92f-e1c3-97c7-e2113e0ff3a9@redhat.com> From: "Rafael J. Wysocki" Date: Wed, 24 Feb 2021 15:13:18 +0100 Message-ID: Subject: Re: [PATCH v2 0/4] platform/surface: Add platform profile driver for Surface devices To: Hans de Goede Cc: "Rafael J. Wysocki" , Maximilian Luz , "Rafael J. Wysocki" , Mark Gross , Len Brown , Mark Pearson , Jiaxun Yang , Platform Driver , ACPI Devel Maling List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Feb 15, 2021 at 5:36 PM Hans de Goede wrote: > > Hi, > > On 2/15/21 4:29 PM, Rafael J. Wysocki wrote: > > On Mon, Feb 15, 2021 at 4:22 PM Hans de Goede wrote: > >> > >> Hi, > >> > >> On 2/15/21 3:54 PM, Rafael J. Wysocki wrote: > >>> On Mon, Feb 15, 2021 at 3:36 PM Hans de Goede wrote: > >>>> > >>>> Hi, > >>>> > >>>> On 2/11/21 9:16 PM, Maximilian Luz wrote: > >>>>> This series adds a driver to provide platform profile support on 5th- > >>>>> and later generation Microsoft Surface devices with a Surface System > >>>>> Aggregator Module. On those devices, the platform profile can be used to > >>>>> influence cooling behavior and power consumption. > >>>>> > >>>>> To achieve this, a new platform profile is introduced: the > >>>>> 'balanced-performance' profile. > >>>>> > >>>>> In addition, a couple of fix-ups are performed: > >>>>> - Hide CONFIG_ACPI_PLATFORM_PROFILE and change drivers so that it is > >>>>> selected instead of depended on. > >>>>> - Fix some references to documentation in a comment. > >>>>> > >>>>> Note: This series (or more specifically "platform/surface: Add platform > >>>>> profile driver") depends on the "platform/surface: Add Surface > >>>>> Aggregator device registry" series. > >>>>> > >>>>> Changes in v2: > >>>>> - Introduce new 'balanced-performance' platform profile and change > >>>>> profile mapping in driver. > >>>>> - Perform some fix-ups for the ACPI platform profile implementation: > >>>>> - Fix some references to documentation in a comment. > >>>>> - Hide CONFIG_ACPI_PLATFORM_PROFILE > >>>> > >>>> Thanks, the entire series looks good to me, so for the series: > >>>> > >>>> Reviewed-by: Hans de Goede > >>>> > >>>> Rafael, can you (once 5.12-rc1 is out) pick 1-3/4 and then provide a > >>>> stable branch for me to merge? > >>> > >>> Since [1-3/4] appear to be uncontroversial, so IMO it would be better > >>> to merge them during the merge window, so they are present in > >>> 5.12-rc1. > >> > >> So I just realized one problem with this plan, patch 1/4 depends > >> on (modifies) Kconfig bits which are only in my tree / my 5.12 pull-req > >> (which I send out earlier today). > > > > That should be fine. > > > > I will be sending the first batch of pull requests tomorrow. Then I > > will wait for them to be merged and I will merge the mainline back at > > that point. The new patches will be applied on top of that merge, so > > if your 5.12 material is included in it, they should build without > > problems. > > Ok, that sounds good to me. The [1-3/4] have just been applied (as 5.12-rc material), thanks!